lane-wetmore cdbb0c49cc
UI: Vault update client count charts to show new clients only (#30506)
* increase bar width, show new clients only, add timestamp to header, update bar color

* remove extra timestamps, switch to basic bar chart

* update docs and styling

* remove unneeded timestamp args

* show new client running totatls

* initial test updates

* update test

* clean up new client total calc into util fn

* bits of clean up and todos

* update tests

* update to avoid activity call when in CE and missing either start or end time

* update todos

* update tests

* tidying

* move new client total onto payload for easier access

* update more tests to align with copy changes and new client totals

* remove addressed TODOs

* Update comment

* add changelog entry

* revert to using total, update tests and clean up

* Update ui/app/components/clients/page/counts.hbs

Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>

* remove duplicate charts and update descriptions

* update tests after removing extra charts

* tidy

* update instances of byMonthActivityData to use byMonthNewClients and update tests

* Update ui/app/components/clients/running-total.ts

Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>

* update chart styles

---------

Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
2025-05-19 15:57:32 -05:00

184 lines
6.9 KiB
JavaScript

/**
* Copyright (c) HashiCorp, Inc.
* SPDX-License-Identifier: BUSL-1.1
*/
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { setupMirage } from 'ember-cli-mirage/test-support';
import { setRunOptions } from 'ember-a11y-testing/test-support';
import { render, findAll } from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile';
import clientsHandler, { LICENSE_START, STATIC_NOW } from 'vault/mirage/handlers/clients';
import { getUnixTime } from 'date-fns';
import { GENERAL } from 'vault/tests/helpers/general-selectors';
import { CLIENT_COUNT, CHARTS } from 'vault/tests/helpers/clients/client-count-selectors';
import { formatNumber } from 'core/helpers/format-number';
import { assertBarChart } from 'vault/tests/helpers/clients/client-count-helpers';
const START_TIME = getUnixTime(LICENSE_START);
const END_TIME = getUnixTime(STATIC_NOW);
const { statText, usageStats } = CLIENT_COUNT;
module('Integration | Component | clients | Clients::Page::Acme', function (hooks) {
setupRenderingTest(hooks);
setupMirage(hooks);
hooks.beforeEach(async function () {
clientsHandler(this.server);
this.store = this.owner.lookup('service:store');
const activityQuery = {
start_time: { timestamp: START_TIME },
end_time: { timestamp: END_TIME },
};
// set this to 0
this.activity = await this.store.queryRecord('clients/activity', activityQuery);
this.startTimestamp = START_TIME;
this.endTimestamp = END_TIME;
this.renderComponent = () =>
render(hbs`
<Clients::Page::Acme
@activity={{this.activity}}
@versionHistory={{this.versionHistory}}
@startTimestamp={{this.startTimestamp}}
@endTimestamp={{this.endTimestamp}}
@namespace={{this.countsController.ns}}
@mountPath={{this.countsController.mountPath}}
/>
`);
// Fails on #ember-testing-container
setRunOptions({
rules: {
'scrollable-region-focusable': { enabled: false },
},
});
});
test('it should render with full month activity data charts', async function (assert) {
const monthCount = this.activity.byMonth.length;
assert.expect(3 + monthCount);
const expectedTotal = formatNumber([this.activity.total.acme_clients]);
await this.renderComponent();
assert
.dom(statText('Total ACME clients'))
.hasText(
`Total ACME clients The total number of ACME requests made to Vault during this time period. ${expectedTotal}`,
`renders correct total acme stat ${expectedTotal}`
);
assertBarChart(assert, 'ACME usage', this.activity.byMonth);
});
test('it should render stats without chart for a single month', async function (assert) {
assert.expect(2);
const activityQuery = { start_time: { timestamp: END_TIME }, end_time: { timestamp: END_TIME } };
this.activity = await this.store.queryRecord('clients/activity', activityQuery);
const expectedTotal = formatNumber([this.activity.total.acme_clients]);
await this.renderComponent();
assert.dom(CHARTS.chart('ACME usage')).doesNotExist('total usage chart does not render');
assert
.dom(usageStats('ACME usage'))
.hasText(
`ACME usage Usage metrics tutorial ACME clients which interacted with Vault for the first time each month. Each bar represents the total new ACME clients for that month. Total ACME clients ${expectedTotal}`,
'it renders usage stats with single month copy'
);
});
// EMPTY STATES
test('it should render empty state when ACME data does not exist for a date range', async function (assert) {
assert.expect(7);
// this happens when a user queries historical data that predates the monthly breakdown (added in 1.11)
// only entity + non-entity clients existed then, so we show an empty state for ACME clients
// because the activity response just returns { acme_clients: 0 } which isn't very clear
this.activity.byMonth = [];
await this.renderComponent();
assert.dom(GENERAL.emptyStateTitle).hasText('No ACME clients');
assert
.dom(GENERAL.emptyStateMessage)
.hasText('There is no ACME client data available for this date range.');
assert.dom(CHARTS.chart('ACME usage')).doesNotExist('vertical bar chart does not render');
assert.dom(CHARTS.container('Monthly new')).doesNotExist('monthly new chart does not render');
assert.dom(statText('Total ACME clients')).doesNotExist();
assert.dom(statText('Average new ACME clients per month')).doesNotExist();
assert.dom(usageStats('ACME usage')).doesNotExist();
});
test('it should render empty state when ACME data does not exist for a single month', async function (assert) {
assert.expect(1);
const activityQuery = { start_time: { timestamp: START_TIME }, end_time: { timestamp: START_TIME } };
this.activity = await this.store.queryRecord('clients/activity', activityQuery);
this.activity.byMonth = [];
await this.renderComponent();
assert.dom(GENERAL.emptyStateMessage).hasText('There is no ACME client data available for this month.');
});
test('it should render empty total usage chart when monthly counts are null or 0', async function (assert) {
assert.expect(8);
// manually stub because mirage isn't setup to handle mixed data yet
const counts = {
acme_clients: 0,
clients: 19,
entity_clients: 0,
non_entity_clients: 19,
secret_syncs: 0,
};
this.activity.byMonth = [
{
month: '3/24',
timestamp: '2024-03-01T00:00:00Z',
namespaces: [],
new_clients: {
month: '3/24',
timestamp: '2024-03-01T00:00:00Z',
namespaces: [],
},
},
{
month: '4/24',
timestamp: '2024-04-01T00:00:00Z',
...counts,
namespaces: [],
new_clients: {
month: '4/24',
timestamp: '2024-04-01T00:00:00Z',
namespaces: [],
},
},
];
this.activity.total = counts;
await this.renderComponent();
assert.dom(CHARTS.chart('ACME usage')).exists('renders empty ACME usage chart');
assert
.dom(statText('Total ACME clients'))
.hasTextContaining('The total number of ACME requests made to Vault during this time period. 0');
findAll(`${CHARTS.chart('ACME usage')} ${CHARTS.xAxisLabel}`).forEach((e, i) => {
assert
.dom(e)
.hasText(
`${this.activity.byMonth[i].month}`,
`renders x-axis labels for empty bar chart: ${this.activity.byMonth[i].month}`
);
});
findAll(`${CHARTS.chart('ACME usage')} ${CHARTS.verticalBar}`).forEach((e, i) => {
assert.dom(e).isNotVisible(`does not render data bar for: ${this.activity.byMonth[i].month}`);
});
assert
.dom(CHARTS.container('Monthly new'))
.doesNotExist('empty monthly new chart does not render at all');
assert.dom(statText('Average new ACME clients per month')).doesNotExist();
});
});