mirror of
https://github.com/hashicorp/vault.git
synced 2025-08-26 00:51:08 +02:00
f61bd3230c
* enos(artifactory): unify dev and test scenario artifactory metadata into new module There was previously a lot of shared logic between `build_artifactory_artifact` and `build_artifactory_package` as it regards to building an artifact name. When it comes down to it, both modules are very similar and their only major difference is searching for any artifact (released or not) by either a combination of `revision`, `edition`, `version`, and `type` vs. searching for a released artifact with a combination of `version`, `edition`, and `type`. Rather than bolt on new `s390x` and `fips1403` artifact metadata to both, I factored their metadata for package names and such into a unified and shared `artifact/metadata` module that is now called by both. This was tricky as dev and test scenarios currently differ in what we pass in as the `vault_version`, but we hope to remove that difference soon. We also add metadata support for the forthcoming FIPS 140-3. This commit was tested extensively, along with other test scenarios in support for `s390x but will be useful immediately for FIPS 140-3 so I've extracted it out. Signed-off-by: Ryan Cragun <me@ryan.ec> * Fix artifactory metadata before merge The initial pass of the artifactory metadata was largely untested and extracted from a different branch. After testing, this commit fixes a few issues with the metadata module. In order to test this I also had to fix an issue where AWS secrets engine testing became a requirement but is impossible unless you exectue against a blessed AWS account that has required roles. Instead, we now make those verification opt-in via a new variable. We also make some improvements to the pki-verify-certificates script so that it works reliably against all our supported distros. We also update our dynamic configuration to use the updated versions in samples. Signed-off-by: Ryan Cragun <me@ryan.ec>