mirror of
https://github.com/hashicorp/vault.git
synced 2025-08-07 07:07:05 +02:00
* remove intercepting helpText * add subtext directly to StringList input component * update tests and add coverage for new openapi-attrs util * update test * add warning validation to input * lol is this right i dont know go * literally no idea what im doing * add Description to display attrs struct * update struct comment * add descriptions to remaining go fields * add missing comma * remaining commas..." * add description to display attrs * update tests * update tests * add changelog; * Update ui/app/utils/openapi-to-attrs.js * update tests following backend changes * clearly name variable * format files * no longer need to test for modified tooltip since coming from backend now
296 lines
7.9 KiB
JavaScript
296 lines
7.9 KiB
JavaScript
/**
|
|
* Copyright (c) HashiCorp, Inc.
|
|
* SPDX-License-Identifier: MPL-2.0
|
|
*/
|
|
|
|
import { attr } from '@ember-data/model';
|
|
import { expandOpenApiProps, combineAttributes, combineFieldGroups } from 'vault/utils/openapi-to-attrs';
|
|
import { module, test } from 'qunit';
|
|
import { camelize } from '@ember/string';
|
|
|
|
module('Unit | Util | OpenAPI Data Utilities', function () {
|
|
const OPENAPI_RESPONSE_PROPS = {
|
|
ttl: {
|
|
type: 'string',
|
|
format: 'seconds',
|
|
description: 'this is a TTL!',
|
|
'x-vault-displayAttrs': {
|
|
name: 'TTL',
|
|
},
|
|
},
|
|
'awesome-people': {
|
|
type: 'array',
|
|
items: {
|
|
type: 'string',
|
|
},
|
|
'x-vault-displayAttrs': {
|
|
value: 'Grace Hopper,Lady Ada',
|
|
},
|
|
},
|
|
'favorite-ice-cream': {
|
|
type: 'string',
|
|
enum: ['vanilla', 'chocolate', 'strawberry'],
|
|
},
|
|
'default-value': {
|
|
default: 30,
|
|
'x-vault-displayAttrs': {
|
|
value: 300,
|
|
},
|
|
type: 'integer',
|
|
},
|
|
default: {
|
|
'x-vault-displayAttrs': {
|
|
value: 30,
|
|
},
|
|
type: 'integer',
|
|
},
|
|
'super-secret': {
|
|
type: 'string',
|
|
'x-vault-displayAttrs': {
|
|
sensitive: true,
|
|
},
|
|
description: 'A really secret thing',
|
|
},
|
|
};
|
|
const EXPANDED_PROPS = {
|
|
ttl: {
|
|
helpText: 'this is a TTL!',
|
|
editType: 'ttl',
|
|
label: 'TTL',
|
|
fieldGroup: 'default',
|
|
},
|
|
awesomePeople: {
|
|
editType: 'stringArray',
|
|
defaultValue: 'Grace Hopper,Lady Ada',
|
|
fieldGroup: 'default',
|
|
},
|
|
favoriteIceCream: {
|
|
editType: 'string',
|
|
type: 'string',
|
|
possibleValues: ['vanilla', 'chocolate', 'strawberry'],
|
|
fieldGroup: 'default',
|
|
},
|
|
defaultValue: {
|
|
editType: 'number',
|
|
type: 'number',
|
|
defaultValue: 300,
|
|
fieldGroup: 'default',
|
|
},
|
|
default: {
|
|
editType: 'number',
|
|
type: 'number',
|
|
defaultValue: 30,
|
|
fieldGroup: 'default',
|
|
},
|
|
superSecret: {
|
|
type: 'string',
|
|
editType: 'string',
|
|
sensitive: true,
|
|
helpText: 'A really secret thing',
|
|
fieldGroup: 'default',
|
|
},
|
|
};
|
|
|
|
const EXISTING_MODEL_ATTRS = [
|
|
{
|
|
key: 'name',
|
|
value: {
|
|
isAttribute: true,
|
|
name: 'name',
|
|
options: {
|
|
editType: 'string',
|
|
label: 'Role name',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
key: 'awesomePeople',
|
|
value: {
|
|
isAttribute: true,
|
|
name: 'awesomePeople',
|
|
options: {
|
|
label: 'People Who Are Awesome',
|
|
},
|
|
},
|
|
},
|
|
];
|
|
|
|
const COMBINED_ATTRS = {
|
|
name: attr('string', {
|
|
editType: 'string',
|
|
type: 'string',
|
|
label: 'Role name',
|
|
}),
|
|
ttl: attr('string', {
|
|
editType: 'ttl',
|
|
label: 'TTL',
|
|
helpText: 'this is a TTL!',
|
|
}),
|
|
awesomePeople: attr({
|
|
label: 'People Who Are Awesome',
|
|
editType: 'stringArray',
|
|
defaultValue: 'Grace Hopper,Lady Ada',
|
|
}),
|
|
favoriteIceCream: attr('string', {
|
|
type: 'string',
|
|
editType: 'string',
|
|
possibleValues: ['vanilla', 'chocolate', 'strawberry'],
|
|
}),
|
|
superSecret: attr('string', {
|
|
type: 'string',
|
|
editType: 'string',
|
|
sensitive: true,
|
|
description: 'A really secret thing',
|
|
}),
|
|
};
|
|
|
|
const NEW_FIELDS = ['one', 'two', 'three'];
|
|
|
|
const OPENAPI_DESCRIPTIONS = {
|
|
token_bound_cidrs: {
|
|
type: 'array',
|
|
description:
|
|
'Comma separated string or JSON list of CIDR blocks. If set, specifies the blocks of IP addresses which are allowed to use the generated token.',
|
|
items: {
|
|
type: 'string',
|
|
},
|
|
'x-vault-displayAttrs': {
|
|
description:
|
|
'List of CIDR blocks. If set, specifies the blocks of IP addresses which are allowed to use the generated token.',
|
|
name: "Generated Token's Bound CIDRs",
|
|
group: 'Tokens',
|
|
},
|
|
},
|
|
blah_blah: {
|
|
type: 'array',
|
|
description: 'Comma-separated list of policies',
|
|
items: {
|
|
type: 'string',
|
|
},
|
|
'x-vault-displayAttrs': {
|
|
name: "Generated Token's Policies",
|
|
group: 'Tokens',
|
|
},
|
|
},
|
|
only_display_description: {
|
|
type: 'array',
|
|
items: {
|
|
type: 'string',
|
|
},
|
|
'x-vault-displayAttrs': {
|
|
description: 'Hello there, you look nice today',
|
|
},
|
|
},
|
|
};
|
|
|
|
const STRING_ARRAY_DESCRIPTIONS = {
|
|
token_bound_cidrs: {
|
|
helpText:
|
|
'List of CIDR blocks. If set, specifies the blocks of IP addresses which are allowed to use the generated token.',
|
|
},
|
|
blah_blah: {
|
|
helpText: 'Comma-separated list of policies',
|
|
},
|
|
only_display_description: {
|
|
helpText: 'Hello there, you look nice today',
|
|
},
|
|
};
|
|
|
|
test('it creates objects from OpenAPI schema props', function (assert) {
|
|
assert.expect(6);
|
|
const generatedProps = expandOpenApiProps(OPENAPI_RESPONSE_PROPS);
|
|
for (const propName in EXPANDED_PROPS) {
|
|
assert.deepEqual(EXPANDED_PROPS[propName], generatedProps[propName], `correctly expands ${propName}`);
|
|
}
|
|
});
|
|
|
|
test('it combines OpenAPI props with existing model attrs', function (assert) {
|
|
assert.expect(3);
|
|
const combined = combineAttributes(EXISTING_MODEL_ATTRS, EXPANDED_PROPS);
|
|
for (const propName in EXISTING_MODEL_ATTRS) {
|
|
assert.deepEqual(COMBINED_ATTRS[propName], combined[propName]);
|
|
}
|
|
});
|
|
|
|
test('it adds new fields from OpenAPI to fieldGroups except for exclusions', function (assert) {
|
|
assert.expect(3);
|
|
const modelFieldGroups = [
|
|
{ default: ['name', 'awesomePeople'] },
|
|
{
|
|
Options: ['ttl'],
|
|
},
|
|
];
|
|
const excludedFields = ['two'];
|
|
const expectedGroups = [
|
|
{ default: ['name', 'awesomePeople', 'one', 'three'] },
|
|
{
|
|
Options: ['ttl'],
|
|
},
|
|
];
|
|
const newFieldGroups = combineFieldGroups(modelFieldGroups, NEW_FIELDS, excludedFields);
|
|
for (const groupName in modelFieldGroups) {
|
|
assert.deepEqual(
|
|
newFieldGroups[groupName],
|
|
expectedGroups[groupName],
|
|
'it incorporates all new fields except for those excluded'
|
|
);
|
|
}
|
|
});
|
|
test('it adds all new fields from OpenAPI to fieldGroups when excludedFields is empty', function (assert) {
|
|
assert.expect(3);
|
|
const modelFieldGroups = [
|
|
{ default: ['name', 'awesomePeople'] },
|
|
{
|
|
Options: ['ttl'],
|
|
},
|
|
];
|
|
const excludedFields = [];
|
|
const expectedGroups = [
|
|
{ default: ['name', 'awesomePeople', 'one', 'two', 'three'] },
|
|
{
|
|
Options: ['ttl'],
|
|
},
|
|
];
|
|
const nonExcludedFieldGroups = combineFieldGroups(modelFieldGroups, NEW_FIELDS, excludedFields);
|
|
for (const groupName in modelFieldGroups) {
|
|
assert.deepEqual(
|
|
nonExcludedFieldGroups[groupName],
|
|
expectedGroups[groupName],
|
|
'it incorporates all new fields'
|
|
);
|
|
}
|
|
});
|
|
test('it keeps fields the same when there are no brand new fields from OpenAPI', function (assert) {
|
|
assert.expect(3);
|
|
const modelFieldGroups = [
|
|
{ default: ['name', 'awesomePeople', 'two', 'one', 'three'] },
|
|
{
|
|
Options: ['ttl'],
|
|
},
|
|
];
|
|
const excludedFields = [];
|
|
const expectedGroups = [
|
|
{ default: ['name', 'awesomePeople', 'two', 'one', 'three'] },
|
|
{
|
|
Options: ['ttl'],
|
|
},
|
|
];
|
|
const fieldGroups = combineFieldGroups(modelFieldGroups, NEW_FIELDS, excludedFields);
|
|
for (const groupName in modelFieldGroups) {
|
|
assert.deepEqual(fieldGroups[groupName], expectedGroups[groupName], 'it incorporates all new fields');
|
|
}
|
|
});
|
|
|
|
test('it uses the description from the display attrs block if it exists', async function (assert) {
|
|
assert.expect(3);
|
|
const generatedProps = expandOpenApiProps(OPENAPI_DESCRIPTIONS);
|
|
for (const propName in STRING_ARRAY_DESCRIPTIONS) {
|
|
assert.strictEqual(
|
|
generatedProps[camelize(propName)].helpText,
|
|
STRING_ARRAY_DESCRIPTIONS[propName].helpText,
|
|
`correctly updates helpText for ${propName}`
|
|
);
|
|
}
|
|
});
|
|
});
|