Vault Automation 5ead15b8f2
UI: Add month filtering to client count dashboard (#9148) (#9255)
* delete activity component, convert date-formatters to ts

* add "month" filter to overview tab

* add test coverage for date range dropdown

* add month filtering to client-list

* remove old comment

* wire up clients to route filters for client-list

* adds changelog

* only link to client-list for enterprise versions

* add refresh page link

* render all tabs, add custom empty state for secret sycn clients

* cleanup unused service imports

* revert billing periods as first of the month

* first round of test updates

* update client count utils test

* fix comment typo

* organize tests

Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
2025-09-10 18:09:20 +00:00

239 lines
8.5 KiB
JavaScript

/**
* Copyright (c) HashiCorp, Inc.
* SPDX-License-Identifier: BUSL-1.1
*/
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { setupMirage } from 'ember-cli-mirage/test-support';
import { render, click, findAll, fillIn } from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile';
import clientsHandler, {
LICENSE_START,
STATIC_NOW,
STATIC_PREVIOUS_MONTH,
} from 'vault/mirage/handlers/clients';
import { GENERAL } from 'vault/tests/helpers/general-selectors';
import { CLIENT_COUNT } from 'vault/tests/helpers/clients/client-count-selectors';
import timestamp from 'core/utils/timestamp';
import sinon from 'sinon';
import { allowAllCapabilitiesStub } from 'vault/tests/helpers/stubs';
const START_TIME = LICENSE_START.toISOString();
const END_TIME = STATIC_PREVIOUS_MONTH.toISOString();
const START_ISO = LICENSE_START.toISOString();
const END_ISO = STATIC_PREVIOUS_MONTH.toISOString();
module('Integration | Component | clients | Page::Counts', function (hooks) {
setupRenderingTest(hooks);
setupMirage(hooks);
hooks.beforeEach(async function () {
sinon.replace(timestamp, 'now', sinon.fake.returns(STATIC_NOW));
clientsHandler(this.server);
this.server.post('/sys/capabilities-self', allowAllCapabilitiesStub());
this.store = this.owner.lookup('service:store');
const activityQuery = {
start_time: START_TIME,
end_time: END_TIME,
};
this.activity = await this.store.queryRecord('clients/activity', activityQuery);
this.config = await this.store.queryRecord('clients/config', {});
this.startTimestamp = START_ISO;
this.endTimestamp = END_ISO;
this.versionHistory = [];
this.renderComponent = () =>
render(hbs`
<Clients::Page::Counts
@activity={{this.activity}}
@activityError={{this.activityError}}
@config={{this.config}}
@versionHistory={{this.versionHistory}}
@startTimestamp={{this.startTimestamp}}
@endTimestamp={{this.endTimestamp}}
@onFilterChange={{this.onFilterChange}}
>
<div data-test-yield>Yield block</div>
</Clients::Page::Counts>
`);
});
test('it should populate start and end month displays', async function (assert) {
await this.renderComponent();
assert.dom(CLIENT_COUNT.dateRange.dateDisplay('start')).hasText('July 2023', 'Start month renders');
assert.dom(CLIENT_COUNT.dateRange.dateDisplay('end')).hasText('December 2023', 'End month renders');
});
test('it should render no data empty state', async function (assert) {
this.activity = { id: 'no-data' };
await this.renderComponent();
assert.dom(GENERAL.emptyStateTitle).hasText('No data received', 'No data empty state renders');
});
test('it should render activity error', async function (assert) {
this.activity = null;
this.activityError = { httpStatus: 403 };
await this.renderComponent();
assert
.dom(GENERAL.emptyStateTitle)
.hasText('You are not authorized', 'Activity error empty state renders');
});
test('it should render config disabled alert', async function (assert) {
this.config.enabled = 'Off';
await this.renderComponent();
assert
.dom(CLIENT_COUNT.counts.configDisabled)
.hasText('Tracking is disabled', 'Config disabled alert renders');
});
const jan23start = '2023-01-01T00:00:00Z';
// license start is July 2, 2024 on date change it recalculates start to beginning of the month
const july23start = '2023-07-01T00:00:00Z';
const dec23end = '2023-12-31T23:59:59Z';
const testCases = [
{
scenario: 'changing start only',
expected: { start_time: jan23start, end_time: dec23end },
editStart: '2023-01',
expectedStart: 'January 2023',
expectedEnd: 'December 2023',
},
{
scenario: 'changing end only',
expected: { start_time: july23start, end_time: dec23end },
editEnd: '2023-12',
expectedStart: 'July 2023',
expectedEnd: 'December 2023',
},
{
scenario: 'changing both',
expected: { start_time: jan23start, end_time: dec23end },
editStart: '2023-01',
editEnd: '2023-12',
expectedStart: 'January 2023',
expectedEnd: 'December 2023',
},
];
testCases.forEach((testCase) => {
test(`it should send correct timestamp on filter change when ${testCase.scenario}`, async function (assert) {
assert.expect(5);
this.owner.lookup('service:version').type = 'community';
this.onFilterChange = (params) => {
assert.deepEqual(params, testCase.expected, 'Correct values sent on filter change');
this.set('startTimestamp', params?.start_time ? params.start_time : START_ISO);
this.set('endTimestamp', params?.end_time ? params.end_time : END_ISO);
};
await this.renderComponent();
await click(CLIENT_COUNT.dateRange.edit);
// page starts with default billing dates, which are july 23 - dec 23
assert.dom(CLIENT_COUNT.dateRange.editDate('start')).hasValue('2023-07');
assert.dom(CLIENT_COUNT.dateRange.editDate('end')).hasValue('2023-12');
if (testCase.editStart) {
await fillIn(CLIENT_COUNT.dateRange.editDate('start'), testCase.editStart);
}
if (testCase.editEnd) {
await fillIn(CLIENT_COUNT.dateRange.editDate('end'), testCase.editEnd);
}
if (testCase.reset) {
await click(CLIENT_COUNT.dateRange.reset);
}
await click(GENERAL.submitButton);
assert.dom(CLIENT_COUNT.dateRange.dateDisplay('start')).hasText(testCase.expectedStart);
assert.dom(CLIENT_COUNT.dateRange.dateDisplay('end')).hasText(testCase.expectedEnd);
});
});
test('it renders alert if upgrade happened within queried activity', async function (assert) {
assert.expect(5);
this.versionHistory = await this.store.findAll('clients/version-history').then((resp) => {
return resp.map(({ version, previousVersion, timestampInstalled }) => {
return {
version,
previousVersion,
timestampInstalled,
};
});
});
await this.renderComponent();
assert
.dom(CLIENT_COUNT.upgradeWarning)
.hasTextContaining(
`Client count data contains 3 upgrades Vault was upgraded during this time period. Keep this in mind while looking at the data. Visit our Client count FAQ for more information.`,
'it renders title and subtext'
);
const [first, second, third] = findAll(`${CLIENT_COUNT.upgradeWarning} li`);
assert
.dom(first)
.hasText(
`1.9.1 (upgraded on Aug 2, 2023) - We introduced changes to non-entity token and local auth mount logic for client counting in 1.9.`,
'alert includes 1.9.1 upgrade'
);
assert
.dom(second)
.hasTextContaining(
`1.10.1 (upgraded on Sep 2, 2023) - We added monthly breakdowns and mount level attribution starting in 1.10.`,
'alert includes 1.10.1 upgrade'
);
assert
.dom(third)
.hasTextContaining(
`1.17.0 (upgraded on Dec 2, 2023) - We separated ACME clients from non-entity clients starting in 1.17.`,
'alert includes 1.17.0 upgrade'
);
assert
.dom(`${CLIENT_COUNT.upgradeWarning} ul`)
.doesNotHaveTextContaining(
'1.10.3',
'Warning does not include subsequent patch releases (e.g. 1.10.3) of the same notable upgrade.'
);
});
test('it should render empty state for no start or no end when CE', async function (assert) {
this.owner.lookup('service:version').type = 'community';
this.startTimestamp = null;
this.activity = {};
await this.renderComponent();
assert
.dom(GENERAL.emptyStateTitle)
.hasText('Input the start and end dates to view client attribution by path.', 'Empty state renders');
assert.dom(CLIENT_COUNT.dateRange.edit).hasText('Set date range');
});
test('it should render catch all empty state', async function (assert) {
this.activity.total = null;
await this.renderComponent();
assert.dom(GENERAL.emptyStateTitle).hasText('No data received', 'Empty state renders');
});
test('it resets the tracked values on close', async function (assert) {
await this.renderComponent();
const DATE_RANGE = CLIENT_COUNT.dateRange;
await click(DATE_RANGE.edit);
await fillIn(DATE_RANGE.editDate('start'), '2017-04');
await fillIn(DATE_RANGE.editDate('end'), '2018-05');
await click(GENERAL.cancelButton);
await click(DATE_RANGE.edit);
assert.dom(DATE_RANGE.editDate('start')).hasValue('2023-07');
assert.dom(DATE_RANGE.editDate('end')).hasValue('2023-12');
});
});