vault/ui/tests/integration/components/string-list-test.js
Vault Automation 0e13196509
UI: Clarifies warning alert for string list input when a comma is intentional (#11046) (#11099)
* clarify warning message for scenarios where a comma is intentional

* add test

Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
2025-12-03 10:23:29 -08:00

182 lines
7.4 KiB
JavaScript

/**
* Copyright IBM Corp. 2016, 2025
* SPDX-License-Identifier: BUSL-1.1
*/
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { render, click, fillIn, triggerKeyEvent } from '@ember/test-helpers';
import sinon from 'sinon';
import hbs from 'htmlbars-inline-precompile';
import { GENERAL } from 'vault/tests/helpers/general-selectors';
module('Integration | Component | string list', function (hooks) {
setupRenderingTest(hooks);
hooks.beforeEach(function () {
this.spy = sinon.spy();
});
const assertBlank = function (assert) {
assert.dom('[data-test-string-list-input]').exists({ count: 1 }, 'renders 1 input');
assert.dom('[data-test-string-list-input]').hasValue('', 'the input is blank');
};
const assertFoo = function (assert) {
assert.dom('[data-test-string-list-input]').exists({ count: 2 }, 'renders 2 inputs');
assert.dom('[data-test-string-list-input="0"]').hasValue('foo', 'first input has the inputValue');
assert.dom('[data-test-string-list-input="1"]').hasValue('', 'second input is blank');
};
const assertFooBar = function (assert) {
assert.dom('[data-test-string-list-input]').exists({ count: 3 }, 'renders 3 inputs');
assert.dom('[data-test-string-list-input="0"]').hasValue('foo');
assert.dom('[data-test-string-list-input="1"]').hasValue('bar');
assert.dom('[data-test-string-list-input="2"]').hasValue('', 'last input is blank');
};
test('it renders the label', async function (assert) {
assert.expect(4);
await render(hbs`<StringList @label="foo" @onChange={{this.spy}} />`);
assert.dom('[data-test-string-list-label]').hasText('foo', 'renders the label when provided');
await render(hbs`<StringList />`);
assert.dom('[data-test-string-list-label]').doesNotExist('does not render the label');
assertBlank(assert);
});
test('it renders the tooltip', async function (assert) {
assert.expect(4);
await render(
hbs`<StringList @label="CRL distribution points" @helpText="this is my help text" @onChange={{this.spy}} />`
);
await click(GENERAL.tooltip('string-list'));
assert
.dom(GENERAL.tooltipText)
.hasText('this is my help text', 'renders the help text in a tooltip when provided');
await render(hbs`<StringList />`);
assert.dom(GENERAL.tooltip('string-list')).doesNotExist('does not render the tooltip');
assertBlank(assert);
});
test('it renders inputValue from empty string', async function (assert) {
assert.expect(2);
await render(hbs`<StringList @inputValue="" />`);
assertBlank(assert);
});
test('it renders inputValue from string with one value', async function (assert) {
assert.expect(3);
await render(hbs`<StringList @inputValue="foo" />`);
assertFoo(assert);
});
test('it renders inputValue from comma-separated string', async function (assert) {
assert.expect(4);
await render(hbs`<StringList @inputValue="foo,bar" />`);
assertFooBar(assert);
});
test('it renders inputValue from a blank array', async function (assert) {
assert.expect(2);
this.set('inputValue', []);
await render(hbs`<StringList @inputValue={{this.inputValue}} />`);
assertBlank(assert);
});
test('it renders inputValue array with a single item', async function (assert) {
assert.expect(3);
this.set('inputValue', ['foo']);
await render(hbs`<StringList @inputValue={{this.inputValue}} />`);
assertFoo(assert);
});
test('it renders inputValue array with a multiple items', async function (assert) {
assert.expect(4);
this.set('inputValue', ['foo', 'bar']);
await render(hbs`<StringList @inputValue={{this.inputValue}} />`);
assertFooBar(assert);
});
test('it adds a new row only when the last row is not blank', async function (assert) {
assert.expect(5);
await render(hbs`<StringList @inputValue="" @onChange={{this.spy}}/>`);
await click('[data-test-string-list-button="add"]');
assertBlank(assert);
await fillIn('[data-test-string-list-input="0"]', 'foo');
await triggerKeyEvent('[data-test-string-list-input="0"]', 'keyup', 14);
await click('[data-test-string-list-button="add"]');
assertFoo(assert);
});
test('it trims input values', async function (assert) {
await render(hbs`<StringList @inputValue="" @onChange={{this.spy}}/>`);
await fillIn('[data-test-string-list-input="0"]', 'foo');
await triggerKeyEvent('[data-test-string-list-input="0"]', 'keyup', 14);
assert.dom('[data-test-string-list-input="0"]').hasValue('foo');
});
test('it calls onChange with array when editing', async function (assert) {
assert.expect(2);
this.set('inputValue', ['foo']);
this.set('onChange', function (val) {
assert.deepEqual(val, ['foo', 'bar'], 'calls onChange with expected value');
});
await render(hbs`<StringList @inputValue={{this.inputValue}} @onChange={{this.onChange}} />`);
await fillIn('[data-test-string-list-input="1"]', 'bar');
await triggerKeyEvent('[data-test-string-list-input="1"]', 'keyup', 14);
});
test('it calls onChange with string when editing', async function (assert) {
assert.expect(2);
this.set('inputValue', 'foo');
this.set('onChange', function (val) {
assert.strictEqual(val, 'foo,bar', 'calls onChange with expected value');
});
await render(
hbs`<StringList @type="string" @inputValue={{this.inputValue}} @onChange={{this.onChange}}/>`
);
await fillIn('[data-test-string-list-input="1"]', 'bar');
await triggerKeyEvent('[data-test-string-list-input="1"]', 'keyup', 14);
});
test('it removes a row', async function (assert) {
assert.expect(4);
this.set('inputValue', ['foo', 'bar']);
this.set('onChange', function (val) {
assert.deepEqual(val, ['bar'], 'calls onChange with expected value');
});
await render(hbs`<StringList @inputValue={{this.inputValue}} @onChange={{this.onChange}} />`);
await click('[data-test-string-list-row="0"] [data-test-string-list-button="delete"]');
assert.dom('[data-test-string-list-input]').exists({ count: 2 }, 'renders 2 inputs');
assert.dom('[data-test-string-list-input="0"]').hasValue('bar');
assert.dom('[data-test-string-list-input="1"]').hasValue('');
});
test('it shows a warning when input contains a comma', async function (assert) {
await render(
hbs`<StringList @inputValue={{this.inputValue}} @onChange={{this.spy}} @attrName="paramA" />`
);
await fillIn('[data-test-string-list-input="0"]', 'foo,bar');
await click('[data-test-string-list-button="add"]');
await fillIn('[data-test-string-list-input="1"]', 'no comma');
assert
.dom(GENERAL.validationWarningByAttr('paramA'))
.exists()
.hasText(
'Input contains a comma. To enter multiple values, use separate rows. If commas are part of your value, disregard this message.'
);
assert
.dom(`[data-test-string-list-row="0"] ${GENERAL.icon('alert-triangle')}`)
.exists('input containing comma has an alert icon');
assert
.dom(`[data-test-string-list-row="1"] ${GENERAL.icon('alert-triangle')}`)
.doesNotExist('input without comma does NOT have an alert icon');
// Update input to assert warning disappears
await fillIn('[data-test-string-list-input="0"]', 'foobar');
assert.dom(GENERAL.validationWarningByAttr('paramA')).doesNotExist();
assert.dom(GENERAL.icon('alert-triangle')).doesNotExist();
});
});