mirrors/vault
1
0
Fork 0
mirror of https://github.com/hashicorp/vault.git synced 2025-12-25 03:11:40 +01:00
Code Issues Projects Releases Wiki Activity
20,484 Commits 2,850 Branches 460 Tags
Commit Graph

208 Commits

Author SHA1 Message Date
Yoko Hyakuna
dc40b23d9a
[Docs] Move the tutorial content to the docs (#28894) 
* Move the tutorial content to the docs

* Split the usage doc from the overview

* Change 'Key Management' to 'key management' where appropriate
 2024-11-15 09:05:30 -08:00
Violet Hynes
aa09d0cec5
Product usage reporting docs (#28858) 
* First draft of product usage reporting docs

* Table data, fix issues

* Changelog
 2024-11-12 09:15:52 -05:00
Steven Clark
8403f00caa
Add 1.19.x upgrade note around Transit API change for Ed25519ph signatures (#28847) 2024-11-12 09:06:38 -05:00
Yoko Hyakuna
69b1a615fb
[Docs] Add recommended patterns (#28843) 
* Content conversion from tutorial to doc - seal

* Add AppRole best practices

* Clean up the reference list

* Updated the title

* match the titles

* Add namespaces best practices

* Update the table style
 2024-11-07 13:17:43 -08:00
Sarah Chavis
f439a1eece
Refresh CLI docs: vault agent family (#28770) 
* save progress

* fix file name

* save progress

* save progress

* remove uneeded subheader

* Fix build error

* fix another build error
 2024-10-25 09:47:17 -07:00
Jonathan Frappier
3349dc745d
Add SAML example to docs (#27121) 
* Add SAML example

* Docs/add saml edits (#28732)

* editing suggestions (start)

* save edits

* Update website/content/docs/auth/saml/adfs.mdx

* Update website/content/docs/auth/saml/index.mdx

* Update website/content/docs/auth/saml/adfs.mdx

* Update website/content/docs/auth/saml/troubleshoot-adfs/index.mdx

---------

Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>

* Fix content errors

* missed one >_<

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
 2024-10-24 11:47:33 -07:00
Yoko Hyakuna
a2390d3234
[Docs] Add usage metrics page (#28723) 
* Add UI screenshots

* Add 'usage metrics' page

* Align the step instruction and its screenshot

* Additional notes

* Add link to API docs
 2024-10-18 08:18:45 -07:00
Sarah Chavis
d3ef02b778
VAULT-29153: Update docs with IPv6 compliance info (#28707) 
* update matrix doc and add IPv6 info

---------

Co-authored-by: Ryan Cragun <me@ryan.ec>
 2024-10-15 16:34:16 -07:00
Sarah Chavis
927d1758e6
CLI content refresh - audit commands (#28642) 
First CLI command doc updates:
* Rewrite CLI usage page
* Rewrite token helper page
* Move and rewrite CLI emulator doc
* Rewrite `vault audit` command family docs
 2024-10-11 16:29:15 -07:00
davidadeleon
ef967a0d8c
update AOP docs (#28686) 
Co-authored-by: davidadeleon <ddeleon@hashicorp.com>
 2024-10-11 09:29:07 -04:00
Sarah Chavis
25ce991234
Add release notes for 1.18 (#28646) 
* Add release notes for 1.18

* Make corrections per feedback

* Update website/content/docs/release-notes/1.18.0.mdx

Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>

---------

Co-authored-by: Jonathan Frappier <92055993+jonathanfrappier@users.noreply.github.com>
 2024-10-08 21:30:39 -07:00
Mike Palmiotto
6a145af82a
CE: Remove RequestLimiter config plumbing (#28592) 
This PR provides some plumbing for the enterprise counterpart PR:
hashicorp/vault-enterprise#6791
 2024-10-04 13:48:16 -04:00
Jonathan Frappier
66fa7606ac
Add set up vault service doc (#28272) 
* Add set up vault service doc
* Suggestions/edits (#28394)
---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
 2024-09-18 11:12:06 -07:00
Steven Clark
10df48b3e1
Remove beta tags from CMPv2 docs (#28339) 2024-09-10 16:18:38 -04:00
Scott Miller
6fe1b88401
Remove the BETA badge from EST in documentation (#28265) 
* Remove the BETA badge from EST

* Add ent badge
 2024-09-10 17:35:13 +00:00
Scott Miller
047ec756c0
Document CMPv2 (#27915) 
* CMPv2 Documentation, and restructuring of Issuance Protocols into its own section for PKI.

* title

* CMPv2 API

* Add default path policy

* Update website/content/docs/secrets/pki/cmpv2.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/secrets/pki/cmpv2.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/secrets/pki/cmpv2.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/secrets/pki/cmpv2.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* respond to some PR feedback

* pr feedback

* Fix nav and add key_usage

* Update website/content/docs/secrets/pki/cmpv2.mdx

Co-authored-by: Steven Clark <steven.clark@hashicorp.com>

* Update website/content/docs/secrets/pki/cmpv2.mdx

Co-authored-by: Steven Clark <steven.clark@hashicorp.com>

* Update website/content/api-docs/secret/pki/issuance.mdx

Co-authored-by: Steven Clark <steven.clark@hashicorp.com>

* Docs fixes

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
 2024-09-04 17:24:50 -05:00
davidadeleon
259b3ac9ec
VAULT-29658: Docs update for AOP (#28238) 
* docs change

* Update website/content/docs/concepts/adaptive-overload-protection/index.mdx

Co-authored-by: Paul Banks <pbanks@hashicorp.com>

* Update website/content/docs/concepts/adaptive-overload-protection/index.mdx

Co-authored-by: Paul Banks <pbanks@hashicorp.com>

* Update website/content/docs/concepts/adaptive-overload-protection/index.mdx

Co-authored-by: Paul Banks <pbanks@hashicorp.com>

* adjust some replication verbiage

---------

Co-authored-by: Paul Banks <pbanks@hashicorp.com>
 2024-08-30 16:08:24 -04:00
Yoko Hyakuna
454d639916
Add the instruction for tuning the lease TTL (#28193) 
* Add the instruction for tuning the lease TTL

* Fix a typo

* Add the help command
 2024-08-27 08:07:38 -07:00
Ken Keller
19eaf0282a
adding consul 2 raft storage migration (#28143) 
* initial commit

* fix urls

* update location of guide

* update names

* update names

* Update website/content/docs/platform/k8s/consul-to-raft.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

* Update website/content/docs/platform/k8s/consul-to-raft.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

* Update website/content/docs/platform/k8s/consul-to-raft.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

* Update website/content/docs/platform/k8s/consul-to-raft.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

* Update website/content/docs/platform/k8s/consul-to-raft.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

* Apply suggestions from code review

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

* fix change to package-lock

* Apply suggestions from code review

yoko's suggestions

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

---------

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
 2024-08-27 09:57:04 -05:00
Yoko Hyakuna
34a1796d03
[Docs] Create 'Troubleshoot' section (#28028) 
* Create 'Troubleshoot' section

* Remove extra spaces

* Update redirects.js

* Remove extra comma

* Change the title

* Update website/content/docs/troubleshoot/generate-root-token.mdx

Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>

* Update website/content/docs/troubleshoot/generate-root-token.mdx

Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>

* Update website/content/docs/troubleshoot/generate-root-token.mdx

Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>

* Update website/content/docs/troubleshoot/generate-root-token.mdx

Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>

* Update website/content/docs/troubleshoot/generate-root-token.mdx

Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>

* Update website/content/docs/troubleshoot/generate-root-token.mdx

Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>

* Update website/content/docs/troubleshoot/generate-root-token.mdx

Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>

* Update website/content/docs/troubleshoot/generate-root-token.mdx

Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>

* Update website/content/docs/troubleshoot/generate-root-token.mdx

Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>

* Update website/content/docs/troubleshoot/generate-root-token.mdx

Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>

* edit suggestions (#28047)

* Fix the relative path - add missing '/'

* Fix a typo

---------

Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
 2024-08-09 14:21:41 -07:00
akshya96
e1d3c322e7
Auto-rolling billing start docs PR (#27926) 
* auto-roll docs changes

* addressing comments

* address comments

* Update website/content/api-docs/system/internal-counters.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* addressing some changes

* update docs

* update docs with common explanation file

* updated note info

* fix 1.18 upgrade doc

* fix content-check error

* Update website/content/partials/auto-roll-billing-start-example.mdx

Co-authored-by: miagilepner <mia.epner@hashicorp.com>

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: miagilepner <mia.epner@hashicorp.com>
 2024-08-06 16:09:00 +00:00
Jonathan Frappier
1fb20dbc3d
Add regular (e.g. not API) doc for cross namespace (#27975) 
* Add regular (e.g. not API) doc for cross namespace

* Update website/content/docs/enterprise/namespaces/configure-cross-namespace-access.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

* Update website/content/docs/enterprise/namespaces/configure-cross-namespace-access.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

* Update website/content/docs/enterprise/namespaces/configure-cross-namespace-access.mdx

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>

---------

Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com>
 2024-08-05 16:31:56 -04:00
Ben Ash
137bba2b70
VSO: update docs for VaultAuthGlobals (#27797) 
---------

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
 2024-07-22 11:03:33 -04:00
Theron Voran
7235c269b7
docs/vso: instant updates (#27668) 2024-07-22 11:01:52 -04:00
Yoko Hyakuna
1a0474d27b
Remove 'BETA' on Seal HA (#27492) 
* Remove 'BETA' on Seal HA

* Fix the outline color
 2024-06-13 10:36:48 -07:00
Scott Miller
1a8e6791da
Update documentation to add the Transform import CLI command (#27487) 2024-06-13 11:35:39 -05:00
Sarah Chavis
495d617b01
draft release notes and explicit anchors for easier linking (#27431) 2024-06-11 13:29:55 -07:00
Peter Wilson
3f11c24c13
VAULT-23335: Audit - Exclusion Docs (Draft) (#26696) 
* Added exclusion draft docs

* added message to link exported types RequestEntry and ResponseEntry to website docs

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* `an` => `a`

* quotes

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/enterprise/audit/exclusion.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/partials/audit-options-common.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* JSON {} 'objects'

* condition is optional

* Update website/content/docs/enterprise/audit/exclusion.mdx

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
 2024-06-11 08:39:54 +01:00
divyaac
59320bb60b
Deprecated default_report_months (#27350) 
* Deprecated default_report_months through docs and upgrade guides

* Added upgraade doc

* Update website/content/docs/upgrading/upgrade-to-1.18.x.mdx

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

* Update website/content/api-docs/system/internal-counters.mdx

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Update website/content/docs/upgrading/upgrade-to-1.18.x.mdx

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

* Update vault/logical_system_activity.go

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

* updated code sample

* Added changelog

* Update website/content/docs/upgrading/upgrade-to-1.18.x.mdx

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

* Update changelog/27350.txt

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

* Update website/content/docs/upgrading/index.mdx

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

* Update upgrade-to-1.18.x.mdx

* Update upgrade-to-1.18.x.mdx

* Added docs nav

* Edited docs nav

* Edited docs

---------

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
 2024-06-06 21:58:54 +00:00
Jonathan Frappier
ef10c1a2a4
Add TCP TLS guide (#27318) 
* Add TCP TLS guide

* Fix example listener stanza missing }

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <jfinnigan@hashicorp.com>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <jfinnigan@hashicorp.com>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <jfinnigan@hashicorp.com>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <jfinnigan@hashicorp.com>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <jfinnigan@hashicorp.com>

* Update website/content/docs/configuration/listener/tcp-tls.mdx

Co-authored-by: Jamie Finnigan <jfinnigan@hashicorp.com>

* Suggestions for TCP-TLS docs (#27335)

* recreating edits

* Fix nav entry

---------

Co-authored-by: Jamie Finnigan <jfinnigan@hashicorp.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
 2024-06-05 09:48:10 -04:00
Brian Shumate
39a0dea8ad
Docs: Add recommended patterns (#27257) 
* Docs: Add recommended patterns

- Create security folder
- Move security model to security folder as index page
- Add recommended patterns page to security folder
- Update navigation

* Add diagram content

* Rework navigation placement
 2024-05-29 11:06:16 -04:00
Sarah Chavis
53ec4d5f7b
[DOCS] Manage resources with TF (#27171) 
---------

Co-authored-by: CJ <105300705+cjobermaier@users.noreply.github.com>
Co-authored-by: Brian Shumate <brianshumate@users.noreply.github.com>
 2024-05-24 09:55:27 -07:00
CJ
5787c17b97
Docs/waf vault tf (#26515) 
---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Chris Stella <chris.stella.84@gmail.com>
 2024-05-13 08:21:06 -07:00
Sarah Chavis
b38fdef012
Add reading guide for designing Vault clusters (#26947) 2024-05-10 17:41:32 -07:00
Paul Banks
0a06215d1a
Documentation for Adaptive Overload Protection (#26690) 
* Document enabling config

* Fix nav data JSON after disabling over-zealous prettifier

* Address review feedback

* Add warning about reloading config during overload

* Bad metrics links

* Another bad link

* Add upgrade note about deprecation

---------

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
 2024-05-10 17:55:57 +01:00
Steven Clark
0637f5e316
PKI: Change sign-intermediate to truncate notAfter by default (behavior change) (#26796) 
* PKI: Change sign-intermediate to truncate notAfter by default

 - The PKI sign-intermediate API allowed an end-user to request a TTL
   value that would extend beyond the signing issuer's notAfter. This would
   generate an invalid CA chain when properly validated.
 - We are now changing the default behavior to truncate the returned certificate
   to the signing issuer's notAfter.
 - End-users can get the old behavior by configuring the signing issuer's
   leaf_not_after_behavior field to permit, and call sign-intermediary
   with the new argument enforce_leaf_not_after_behavior to true. The
   new argument could also be used to enforce an error instead of truncating
   behavior if the signing issuer's leaf_not_after_behavior is set to err.

* Add cl

* Add cl and upgrade note

* Apply suggestions from code review

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
 2024-05-09 11:22:04 -04:00
Sarah Chavis
643028f931
[DOCS] Update deprecation pages (#26597) 
Co-authored-by: Meggie <meggie@hashicorp.com>
 2024-04-24 09:28:49 -07:00
Brian Shumate
5aaa489f80
Docs: migrate key metrics from WAF to telemetry (#26499) 
- Add key metrics document to telemetry internals documentation
 2024-04-18 11:45:37 -04:00
Dylan Staley
34d7fc39a0
fix: add missing comma (#26379) 2024-04-11 13:59:11 -04:00
Brian Shumate
ba6a9c2160
Docs: WAF: initial cloud access management content (#26321) 
Co-authored-by: CJ <105300705+cjobermaier@users.noreply.github.com>
 2024-04-10 12:11:28 -04:00
Sarah Chavis
038aaa3ff7
1.16 release notes and beta cleanup (#26247) 
Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
 2024-04-03 22:18:40 +01:00
Sarah Chavis
262997a532
[DOCS] LTS overview (#25945) 
Co-authored-by: Jared Kirschner <85913323+jkirschner-hashicorp@users.noreply.github.com>
 2024-04-03 12:26:29 -07:00
Tom Proctor
dbe6e4ee2d
Docs: Fix SQL Server EKM Provider KEK rotation instructions (#25255) 2024-04-03 11:35:31 +01:00
Theron Voran
92c58476ee
docs/vault-secrets-operator: encrypted client cache storage (#25475) 
Adding a howto guide for enabling the encrypted Vault client cache
storage for helm and OperatorHub installs. Add more detail about
client caching to the main Vault source page, with a link to the
guide.

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
 2024-04-01 14:45:13 -07:00
Scott Miller
f319d98665
Re-add beta designation (#26190) 
* Re-add beta designation

* nl

* mark the migration section beta too

* beta
 2024-03-27 15:16:27 -04:00
Robert
5fac327dae
Secrets Import documentation (#25594) 
* Start import docs

* Use hideClipboard block on output

* Reorganize mappings and source docs

* Change experimental to alpha

* Change list tag to alpha

* Apply suggestions from code review

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
 2024-03-27 09:35:29 -05:00
Josh Black
6d69761751
raft-wal docs (#25572) 
* starting on docs

* add docs for raft-wal

* some tweaks

* Apply suggestions from code review

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

* Edits for Raft WAL (#26123)

* not just one filename

* update file pattern for wal files

---------

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
 2024-03-25 16:42:48 -07:00
Christopher Swenson
74c350474b
docs: Adding events to a plugin (#26083) 
This adds a short doc describing the basic process
of adding event notifications to a plugin as well
as some examples and best practices.

Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
 2024-03-25 16:50:49 +00:00
Max Coulombe
fa469f8bdc
- removed beta badges (#26120) 2024-03-22 17:00:30 -04:00
Steven Clark
43f8c7a6f0
PKI EST docs (#25521) 
* PKI EST docs

 Initial draft of the PKI EST setup and API docs for feedback

* Add missing enable_sentinel_parsing param to API docs

* Update grammar

* Some API doc feedback

* Note about dedicated auth mounts

* Additional PR feedback

---------

Co-authored-by: Scott G. Miller <smiller@hashicorp.com>
 2024-03-07 14:27:59 -05:00