From dc5070904b3ab6a8f7876360faada622c49ffdf2 Mon Sep 17 00:00:00 2001
From: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
Date: Fri, 23 Feb 2024 13:11:07 -0800
Subject: [PATCH] UI: add default granularity depending on type, add optional
 to secret_name_template (#25611)

* add default granularity depending on type

* move default setting to helper

* add test coverage for default granularity

* update mirage

* update secret name template

* remove has-text-black class which was making help tooltip black as well
---
 ui/app/models/sync/destination.js             | 11 ++++++----
 ui/lib/core/addon/components/form-field.hbs   |  2 +-
 .../core/addon/helpers/sync-destinations.ts   | 18 ++++++++++++++--
 .../destinations/create/destination.ts        |  7 +++++--
 ui/mirage/factories/sync-destination.js       |  3 ++-
 .../sync/secrets/destinations-test.js         | 21 +++++++++++++++++++
 ui/types/vault/helpers/sync-destinations.ts   |  1 +
 7 files changed, 53 insertions(+), 10 deletions(-)

diff --git a/ui/app/models/sync/destination.js b/ui/app/models/sync/destination.js
index f040e68c2f..086bd69e22 100644
--- a/ui/app/models/sync/destination.js
+++ b/ui/app/models/sync/destination.js
@@ -18,13 +18,17 @@ const validations = {
 
 @withModelValidations(validations)
 export default class SyncDestinationModel extends Model {
-  @attr('string', { subText: 'Specifies the name for this destination.', editDisabled: true }) name;
+  @attr('string', { subText: 'Specifies the name for this destination.', editDisabled: true })
+  name;
+
   @attr type;
+
   @attr('string', {
     subText:
-      'Go-template string that indicates how to format the secret name at the destination. The default template varies by destination type but is generally in the form of "vault-<accessor_id>-<secret_path>" e.g. "vault-kv-1234-my-secret-1".',
+      'Go-template string that indicates how to format the secret name at the destination. The default template varies by destination type but is generally in the form of "vault-{{ .MountAccessor }}-{{ .SecretPath }}" e.g. "vault-kv_9a8f68ad-my-secret-1". Optional.',
   })
   secretNameTemplate;
+
   @attr('string', {
     editType: 'radio',
     label: 'Secret sync granularity',
@@ -42,9 +46,8 @@ export default class SyncDestinationModel extends Model {
         value: 'secret-key',
       },
     ],
-    defaultValue: 'secret-path',
   })
-  granularity;
+  granularity; // default value depends on type and is set in create route
 
   // only present if delete action has been initiated
   @attr('string') purgeInitiatedAt;
diff --git a/ui/lib/core/addon/components/form-field.hbs b/ui/lib/core/addon/components/form-field.hbs
index 03cd70cb08..fb63d2e4ff 100644
--- a/ui/lib/core/addon/components/form-field.hbs
+++ b/ui/lib/core/addon/components/form-field.hbs
@@ -37,7 +37,7 @@
             <div class="has-left-margin-xs">
               <label
                 for="{{or val.value val}}"
-                class="has-left-margin-xs has-text-black is-size-7"
+                class="has-left-margin-xs is-size-7"
                 data-test-radio-label={{or val.label val.value val}}
               >
                 {{or val.label val.value val}}
diff --git a/ui/lib/core/addon/helpers/sync-destinations.ts b/ui/lib/core/addon/helpers/sync-destinations.ts
index 1ce6c23659..5581437e37 100644
--- a/ui/lib/core/addon/helpers/sync-destinations.ts
+++ b/ui/lib/core/addon/helpers/sync-destinations.ts
@@ -8,8 +8,7 @@ import { helper as buildHelper } from '@ember/component/helper';
 import type { SyncDestination, SyncDestinationType } from 'vault/vault/helpers/sync-destinations';
 
 /* 
-This helper is referenced in the base sync destination model
-to return static display attributes that rely on type
+This helper is referenced in the base sync destination model and elsewhere to set attributes that rely on type
 maskedParams: attributes for sensitive data, the API returns these values as '*****'
 */
 
@@ -20,6 +19,9 @@ const SYNC_DESTINATIONS: Array<SyncDestination> = [
     icon: 'aws-color',
     category: 'cloud',
     maskedParams: ['accessKeyId', 'secretAccessKey'],
+    defaultValues: {
+      granularity: 'secret-path',
+    },
   },
   {
     name: 'Azure Key Vault',
@@ -27,6 +29,9 @@ const SYNC_DESTINATIONS: Array<SyncDestination> = [
     icon: 'azure-color',
     category: 'cloud',
     maskedParams: ['clientSecret'],
+    defaultValues: {
+      granularity: 'secret-path',
+    },
   },
   {
     name: 'Google Secret Manager',
@@ -34,6 +39,9 @@ const SYNC_DESTINATIONS: Array<SyncDestination> = [
     icon: 'gcp-color',
     category: 'cloud',
     maskedParams: ['credentials'],
+    defaultValues: {
+      granularity: 'secret-path',
+    },
   },
   {
     name: 'Github Actions',
@@ -41,6 +49,9 @@ const SYNC_DESTINATIONS: Array<SyncDestination> = [
     icon: 'github-color',
     category: 'dev-tools',
     maskedParams: ['accessToken'],
+    defaultValues: {
+      granularity: 'secret-key',
+    },
   },
   {
     name: 'Vercel Project',
@@ -48,6 +59,9 @@ const SYNC_DESTINATIONS: Array<SyncDestination> = [
     icon: 'vercel-color',
     category: 'dev-tools',
     maskedParams: ['accessToken'],
+    defaultValues: {
+      granularity: 'secret-key',
+    },
   },
 ];
 
diff --git a/ui/lib/sync/addon/routes/secrets/destinations/create/destination.ts b/ui/lib/sync/addon/routes/secrets/destinations/create/destination.ts
index bc94f74b81..ebb04b6167 100644
--- a/ui/lib/sync/addon/routes/secrets/destinations/create/destination.ts
+++ b/ui/lib/sync/addon/routes/secrets/destinations/create/destination.ts
@@ -5,11 +5,13 @@
 
 import Route from '@ember/routing/route';
 import { service } from '@ember/service';
+import { findDestination } from 'core/helpers/sync-destinations';
 
 import type StoreService from 'vault/services/store';
+import type { SyncDestinationType } from 'vault/vault/helpers/sync-destinations';
 
 interface Params {
-  type: string;
+  type: SyncDestinationType;
 }
 
 export default class SyncSecretsDestinationsCreateDestinationRoute extends Route {
@@ -17,6 +19,7 @@ export default class SyncSecretsDestinationsCreateDestinationRoute extends Route
 
   model(params: Params) {
     const { type } = params;
-    return this.store.createRecord(`sync/destinations/${type}`, { type });
+    const defaultValues = findDestination(type)?.defaultValues;
+    return this.store.createRecord(`sync/destinations/${type}`, { type, ...defaultValues });
   }
 }
diff --git a/ui/mirage/factories/sync-destination.js b/ui/mirage/factories/sync-destination.js
index 535d8e80cd..27180d16f3 100644
--- a/ui/mirage/factories/sync-destination.js
+++ b/ui/mirage/factories/sync-destination.js
@@ -16,7 +16,7 @@ export default Factory.extend({
     role_arn: 'test-role',
     external_id: 'id12345',
     // options
-    granularity: 'secret-path', // default option (same for all destinations) so edit test can update to 'secret-key'
+    granularity: 'secret-path', // default varies per destination, but setting all as secret-path so edit test loop updates each to 'secret-key'
     secret_name_template: 'vault-{{ .MountAccessor }}-{{ .SecretPath }}',
     custom_tags: { foo: 'bar' },
   }),
@@ -66,6 +66,7 @@ export default Factory.extend({
     team_id: 'team_12345',
     deployment_environments: ['development', 'preview'], // 'production' is also an option, but left out for testing to assert form changes value
     // options
+    granularity: 'secret-path',
     secret_name_template: 'vault-{{ .MountAccessor }}-{{ .SecretPath }}',
   }),
 });
diff --git a/ui/tests/acceptance/sync/secrets/destinations-test.js b/ui/tests/acceptance/sync/secrets/destinations-test.js
index c9e68d9f6b..6885acd5fe 100644
--- a/ui/tests/acceptance/sync/secrets/destinations-test.js
+++ b/ui/tests/acceptance/sync/secrets/destinations-test.js
@@ -11,6 +11,9 @@ import syncHandlers from 'vault/mirage/handlers/sync';
 import authPage from 'vault/tests/pages/auth';
 import { click, visit, fillIn, currentURL, currentRouteName } from '@ember/test-helpers';
 import { PAGE as ts } from 'vault/tests/helpers/sync/sync-selectors';
+import { syncDestinations } from 'vault/helpers/sync-destinations';
+
+const SYNC_DESTINATIONS = syncDestinations();
 
 // sync is an enterprise feature but since mirage is used the enterprise label has been intentionally omitted from the module name
 module('Acceptance | sync | destinations', function (hooks) {
@@ -43,6 +46,24 @@ module('Acceptance | sync | destinations', function (hooks) {
     );
   });
 
+  for (const destination of SYNC_DESTINATIONS) {
+    const { type, defaultValues } = destination;
+    test(`it should render default values for destination: ${type}`, async function (assert) {
+      // remove destinations from mirage so cta shows when 404 is returned
+      this.server.db.syncDestinations.remove();
+
+      await click(ts.navLink('Secrets Sync'));
+      await click(ts.cta.button);
+      await click(ts.selectType(type));
+
+      // check default values
+      const attr = 'granularity';
+      assert
+        .dom(`${ts.inputByAttr(attr)} input#${defaultValues[attr]}`)
+        .isChecked(`${defaultValues[attr]} is checked`);
+    });
+  }
+
   test('it should filter destinations list', async function (assert) {
     await visit('vault/sync/secrets/destinations');
     assert.dom(ts.listItem).exists({ count: 6 }, 'All destinations render');
diff --git a/ui/types/vault/helpers/sync-destinations.ts b/ui/types/vault/helpers/sync-destinations.ts
index 9749b00864..b8859cd9ea 100644
--- a/ui/types/vault/helpers/sync-destinations.ts
+++ b/ui/types/vault/helpers/sync-destinations.ts
@@ -17,4 +17,5 @@ export interface SyncDestination {
   icon: 'aws-color' | 'azure-color' | 'gcp-color' | 'github-color' | 'vercel-color';
   category: 'cloud' | 'dev-tools';
   maskedParams: Array<string>;
+  defaultValues: object;
 }