From c8cbd33f748f2630a7cc23957aaa4a047df76c0c Mon Sep 17 00:00:00 2001 From: Matt Hurne Date: Fri, 1 Jul 2016 13:55:06 -0400 Subject: [PATCH] mongodb secret backend: Parse ssl URI option as a boolean rather than relying on string comparison --- builtin/logical/mongodb/util.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/builtin/logical/mongodb/util.go b/builtin/logical/mongodb/util.go index 14a05fab61..d5968bcdbe 100644 --- a/builtin/logical/mongodb/util.go +++ b/builtin/logical/mongodb/util.go @@ -55,7 +55,11 @@ func parseMongoURI(rawUri string) (*mgo.DialInfo, error) { } info.PoolLimit = poolLimit case "ssl": - if value == "true" { + ssl, err := strconv.ParseBool(value) + if err != nil { + return nil, errors.New("bad value for ssl: " + value) + } + if ssl { info.DialServer = func(addr *mgo.ServerAddr) (net.Conn, error) { return tls.Dial("tcp", addr.String(), &tls.Config{}) }