diff --git a/ui/app/app.js b/ui/app/app.js index fc0a415d03..75cde8edd4 100644 --- a/ui/app/app.js +++ b/ui/app/app.js @@ -15,7 +15,7 @@ export default class App extends Application { engines = { 'config-ui': { dependencies: { - services: ['auth', 'flash-messages', 'namespace', 'router', 'store', 'version', 'customMessages'], + services: ['auth', 'flash-messages', 'namespace', 'router', 'store', 'version', 'custom-messages'], }, }, 'open-api-explorer': { diff --git a/ui/app/helpers/tabs-for-auth-section.js b/ui/app/helpers/tabs-for-auth-section.js index eb93653d83..77a1b92388 100644 --- a/ui/app/helpers/tabs-for-auth-section.js +++ b/ui/app/helpers/tabs-for-auth-section.js @@ -99,7 +99,7 @@ export function tabsForAuthSection([authMethodModel, sectionType = 'authSettings tabs.push({ label: 'Method Options', route: 'vault.cluster.settings.auth.configure.section', - routeParams: ['options'], + routeParams: [authMethodModel.id, 'options'], }); return tabs; } diff --git a/ui/app/models/identity/group-alias.js b/ui/app/models/identity/group-alias.js index 1573de4620..e3f8f12e8e 100644 --- a/ui/app/models/identity/group-alias.js +++ b/ui/app/models/identity/group-alias.js @@ -14,7 +14,7 @@ export default IdentityModel.extend({ formFields: computed(function () { return ['name', 'mountAccessor']; }), - group: belongsTo('identity/group', { readOnly: true, async: false }), + group: belongsTo('identity/group', { readOnly: true, async: false, inverse: 'alias' }), name: attr('string'), canonicalId: attr('string'), diff --git a/ui/app/routes/vault/cluster/logout.js b/ui/app/routes/vault/cluster/logout.js index 03d386c361..9214fb8f90 100644 --- a/ui/app/routes/vault/cluster/logout.js +++ b/ui/app/routes/vault/cluster/logout.js @@ -45,9 +45,8 @@ export default Route.extend(ModelBoundaryRoute, { queryParams.namespace = ns; } if (Ember.testing) { - // TODO: cleanup this replaceWith instance. Using router.replaceWith causes test failures // Don't redirect on the test - this.replaceWith('vault.cluster.auth', { queryParams }); + this.router.replaceWith('vault.cluster.auth', { queryParams }); } else { const { cluster_name } = this.paramsFor('vault.cluster'); location.assign(this.router.urlFor('vault.cluster.auth', cluster_name, { queryParams })); diff --git a/ui/lib/config-ui/addon/components/messages/page/create-and-edit.js b/ui/lib/config-ui/addon/components/messages/page/create-and-edit.js index e59b9476e3..b71ce31ba1 100644 --- a/ui/lib/config-ui/addon/components/messages/page/create-and-edit.js +++ b/ui/lib/config-ui/addon/components/messages/page/create-and-edit.js @@ -37,12 +37,12 @@ export default class MessagesList extends Component { @tracked userConfirmation = ''; willDestroy() { - super.willDestroy(); const noTeardown = this.store && !this.store.isDestroying; const { model } = this; if (noTeardown && model && model.isDirty && !model.isDestroyed && !model.isDestroying) { model.rollbackAttributes(); } + super.willDestroy(); } validate() { diff --git a/ui/lib/config-ui/addon/engine.js b/ui/lib/config-ui/addon/engine.js index 2eedbf9a9b..cd9cfb604c 100644 --- a/ui/lib/config-ui/addon/engine.js +++ b/ui/lib/config-ui/addon/engine.js @@ -16,7 +16,7 @@ export default class ConfigUiEngine extends Engine { modulePrefix = modulePrefix; Resolver = Resolver; dependencies = { - services: ['auth', 'store', 'flash-messages', 'namespace', 'router', 'version', 'customMessages'], + services: ['auth', 'store', 'flash-messages', 'namespace', 'router', 'version', 'custom-messages'], }; } diff --git a/ui/lib/core/addon/components/message-error.js b/ui/lib/core/addon/components/message-error.js index 1318df0ea0..8a78b4bf1e 100644 --- a/ui/lib/core/addon/components/message-error.js +++ b/ui/lib/core/addon/components/message-error.js @@ -39,7 +39,7 @@ class MessageError extends Component { if (!adapterError) { return null; } - if (adapterError.errors.length > 0) { + if (adapterError.errors?.length > 0) { return adapterError.errors.map((e) => { if (typeof e === 'object') return e.title || e.message || JSON.stringify(e); return e; diff --git a/ui/lib/core/addon/components/secret-list-header.hbs b/ui/lib/core/addon/components/secret-list-header.hbs index 67359ae8d2..10d4c0562f 100644 --- a/ui/lib/core/addon/components/secret-list-header.hbs +++ b/ui/lib/core/addon/components/secret-list-header.hbs @@ -39,7 +39,7 @@