From a29ba45a3a59626bf97e08a48ccac2a5dbd60f96 Mon Sep 17 00:00:00 2001 From: miagilepner Date: Tue, 11 Jul 2023 15:35:10 +0200 Subject: [PATCH] VAULT-15958: Fix pr/no-milestone (#21713) * fix milestone * only pr milestone check and fix actionlint * fix actionlint * add comments saying that the event types work --- .github/workflows/actionlint.yml | 3 +++ .github/workflows/milestone-checker.yml | 7 +++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index 35dddb56a5..8b466e7172 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -12,3 +12,6 @@ jobs: - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 - name: "Check workflow files" uses: docker://docker.mirror.hashicorp.services/rhysd/actionlint@sha256:93834930f56ca380be3e9a3377670d7aa5921be251b9c774891a39b3629b83b8 + with: + # milestoned and demilestoned work (https://github.com/github/docs/issues/23909) but they aren't listed in the github documentation, so actionlint complains about them + args: "-ignore=\"invalid activity type \\\"demilestoned\\\" for \\\"pull_request\\\" Webhook event\" -ignore=\"invalid activity type \\\"milestoned\\\" for \\\"pull_request\\\" Webhook event\"" diff --git a/.github/workflows/milestone-checker.yml b/.github/workflows/milestone-checker.yml index 89654956b1..c3eed2a1e4 100644 --- a/.github/workflows/milestone-checker.yml +++ b/.github/workflows/milestone-checker.yml @@ -5,19 +5,18 @@ name: Check Milestone on: pull_request: - types: [opened, synchronize, labeled, unlabeled] + # milestoned and demilestoned work (https://github.com/github/docs/issues/23909) but they aren't listed in the github documentation + types: [opened, synchronize, labeled, unlabeled, milestoned, demilestoned] # Runs on PRs to main and release branches branches: - main - release/** - issues: - types: [milestoned, demilestoned] jobs: # checks that a milestone entry is present for a PR milestone-check: # If there is a `pr/no-milestone` label we ignore this check - if: "! ( contains(github.event.pull_request.labels.*.name, 'pr/no-milestone') || ( github.event.name == 'labeled' && github.event.label == 'pr/no-milestone' ) )" + if: "!contains(github.event.pull_request.labels.*.name, 'pr/no-milestone')" runs-on: ubuntu-latest steps: - name: Checkout Actions