From 9efa76ac4ce9e0dbf498054bbf356aae96f53ead Mon Sep 17 00:00:00 2001 From: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com> Date: Tue, 23 Apr 2024 09:36:08 -0500 Subject: [PATCH] UI: Add necessary params to links in Access & KV v2 (#26561) * refactor tabs-for-auth-section helper * Fill out route params in generated-item + list compoenents * Add optional route params to ListView pagination * Add backend to KV breadcrumb link route models * fix links in kv v2 pages, update kv-breadcrumbs-test * remove todo --- ui/app/components/section-tabs.hbs | 2 +- ui/app/helpers/tabs-for-auth-section.js | 63 ++++++++++++------- .../vault/cluster/access/method/index.js | 10 +-- .../vault/cluster/access/method/item/edit.js | 2 + .../vault/cluster/access/method/item/show.js | 2 + .../cluster/settings/auth/configure/index.js | 2 +- .../components/generated-item-list.hbs | 20 +++--- .../templates/components/generated-item.hbs | 7 ++- .../cluster/access/method/item/create.hbs | 2 +- .../vault/cluster/access/method/item/edit.hbs | 2 +- .../vault/cluster/access/method/item/show.hbs | 2 +- ui/lib/core/addon/components/list-view.hbs | 1 + .../addon/templates/credentials/index.hbs | 8 ++- ui/lib/kv/addon/components/page/list.hbs | 42 ++++++++++--- .../addon/components/page/secret/details.hbs | 33 ++++++++-- .../page/secret/metadata/details.hbs | 30 +++++++-- .../page/secret/metadata/version-history.hbs | 31 +++++++-- .../kv/addon/components/page/secret/paths.hbs | 30 +++++++-- ui/lib/kv/addon/routes/configuration.js | 2 +- ui/lib/kv/addon/routes/create.js | 4 +- ui/lib/kv/addon/routes/error.js | 2 +- ui/lib/kv/addon/routes/list-directory.js | 4 +- ui/lib/kv/addon/routes/secret/details/edit.js | 4 +- .../kv/addon/routes/secret/details/index.js | 4 +- .../kv/addon/routes/secret/metadata/diff.js | 4 +- .../kv/addon/routes/secret/metadata/edit.js | 4 +- .../kv/addon/routes/secret/metadata/index.js | 4 +- .../addon/routes/secret/metadata/versions.js | 4 +- ui/lib/kv/addon/routes/secret/paths.js | 4 +- ui/lib/kv/addon/templates/list-directory.hbs | 1 + ui/lib/kv/addon/templates/list.hbs | 1 + .../templates/secret/metadata/versions.hbs | 1 + ui/lib/kv/addon/utils/kv-breadcrumbs.js | 8 +-- ui/tests/unit/utils/kv-breadcrumbs-test.js | 33 +++++----- 34 files changed, 262 insertions(+), 111 deletions(-) diff --git a/ui/app/components/section-tabs.hbs b/ui/app/components/section-tabs.hbs index 60ee2e2096..3323d2d3ec 100644 --- a/ui/app/components/section-tabs.hbs +++ b/ui/app/components/section-tabs.hbs @@ -10,7 +10,7 @@