From 8071d6e6ca71f970352bbd7fe7cfeb948e2d60a2 Mon Sep 17 00:00:00 2001
From: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
Date: Tue, 6 Jun 2023 08:38:12 -0700
Subject: [PATCH] rename classes and delete unused files (#21003)

---
 ui/app/styles/components/linkable-item.scss     | 17 -----------------
 ui/app/styles/components/linked-block.scss      | 13 +++++++++++++
 ui/app/styles/components/read-more.scss         |  2 +-
 ui/app/styles/core.scss                         |  1 -
 .../vault/cluster/secrets/backends.hbs          | 13 ++++++-------
 .../addon/components/info-table-item-array.hbs  |  4 ++--
 .../addon/templates/components/read-more.hbs    |  2 +-
 .../app/components/linkable-item/content.js     |  6 ------
 .../core/app/components/linkable-item/menu.js   |  6 ------
 9 files changed, 23 insertions(+), 41 deletions(-)
 delete mode 100644 ui/app/styles/components/linkable-item.scss
 delete mode 100644 ui/lib/core/app/components/linkable-item/content.js
 delete mode 100644 ui/lib/core/app/components/linkable-item/menu.js

diff --git a/ui/app/styles/components/linkable-item.scss b/ui/app/styles/components/linkable-item.scss
deleted file mode 100644
index e531bc2f1f..0000000000
--- a/ui/app/styles/components/linkable-item.scss
+++ /dev/null
@@ -1,17 +0,0 @@
-/**
- * Copyright (c) HashiCorp, Inc.
- * SPDX-License-Identifier: MPL-2.0
- */
-
-.linkable-item {
-  display: grid;
-  grid-template-columns: minmax(0, 1fr) 50px 35px;
-  gap: 1em 1em;
-}
-
-.linkable-item-menu {
-  box-sizing: border-box;
-  grid-column: 3;
-  grid-row: 1;
-  align-self: center;
-}
diff --git a/ui/app/styles/components/linked-block.scss b/ui/app/styles/components/linked-block.scss
index a5b40abf0f..5b21d2564e 100644
--- a/ui/app/styles/components/linked-block.scss
+++ b/ui/app/styles/components/linked-block.scss
@@ -10,3 +10,16 @@
 .linked-block .columns {
   @extend .is-flex-center;
 }
+
+.linked-block-item {
+  display: grid;
+  grid-template-columns: minmax(0, 1fr) 50px 35px;
+  gap: 1em 1em;
+}
+
+.linked-block-popup-menu {
+  box-sizing: border-box;
+  grid-column: 3;
+  grid-row: 1;
+  align-self: center;
+}
diff --git a/ui/app/styles/components/read-more.scss b/ui/app/styles/components/read-more.scss
index 5348a27987..7ce07892c0 100644
--- a/ui/app/styles/components/read-more.scss
+++ b/ui/app/styles/components/read-more.scss
@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: MPL-2.0
  */
 
-.linkable-item-seemore {
+.linked-block-seemore {
   grid-column: 2;
   grid-row: 1;
   align-self: baseline;
diff --git a/ui/app/styles/core.scss b/ui/app/styles/core.scss
index d3c970716f..94fb005d21 100644
--- a/ui/app/styles/core.scss
+++ b/ui/app/styles/core.scss
@@ -77,7 +77,6 @@
 @import './components/kmip-role-edit';
 @import './components/known-secondaries-card.scss';
 @import './components/license-banners';
-@import './components/linkable-item';
 @import './components/linked-block';
 @import './components/list-item-row';
 @import './components/list-pagination';
diff --git a/ui/app/templates/vault/cluster/secrets/backends.hbs b/ui/app/templates/vault/cluster/secrets/backends.hbs
index 429813f6a5..c766eed5b8 100644
--- a/ui/app/templates/vault/cluster/secrets/backends.hbs
+++ b/ui/app/templates/vault/cluster/secrets/backends.hbs
@@ -43,16 +43,16 @@
 {{#each this.sortedDisplayableBackends as |backend|}}
   <LinkedBlock
     @params={{array backend.backendLink backend.id}}
-    class="list-item-row linkable-item is-no-underline"
+    class="list-item-row linked-block-item is-no-underline"
     data-test-auth-backend-link={{backend.id}}
     @disabled={{if backend.isSupportedBackend false true}}
   >
-    <div class="linkable-item-content" data-test-linkable-item-content>
+    <div>
       <div class="has-text-grey">
         {{#if backend.icon}}
           <ToolTip @horizontalPosition="left" as |T|>
             <T.Trigger>
-              <Icon @name={{backend.icon}} class="has-text-grey-light" data-test-linkable-item-glyph />
+              <Icon @name={{backend.icon}} class="has-text-grey-light" />
             </T.Trigger>
             <T.Content @defaultClass="tool-tip">
               <div class="box">
@@ -77,19 +77,18 @@
         {{/if}}
       </div>
       {{#if backend.accessor}}
-        <code class="has-text-grey is-size-8" data-test-linkable-item-accessor>
+        <code class="has-text-grey is-size-8">
           {{backend.accessor}}
         </code>
       {{/if}}
       {{#if backend.description}}
-        <ReadMore data-test-linkable-item-description>
+        <ReadMore>
           {{backend.description}}
         </ReadMore>
       {{/if}}
-      {{yield}}
     </div>
     {{! meatball sandwich menu }}
-    <div class="linkable-item-menu" data-test-linkable-item-menu={{backend.path}}>
+    <div class="linked-block-popup-menu">
       <PopupMenu @name="engine-menu">
         <Confirm as |c|>
           <nav class="menu" aria-label="{{if backend.isSupportedBackend 'supported' 'unsupported'}} secrets engine menu">
diff --git a/ui/lib/core/addon/components/info-table-item-array.hbs b/ui/lib/core/addon/components/info-table-item-array.hbs
index 5a3f1e3c7f..aed30d39c2 100644
--- a/ui/lib/core/addon/components/info-table-item-array.hbs
+++ b/ui/lib/core/addon/components/info-table-item-array.hbs
@@ -1,5 +1,5 @@
-{{! the class linkable-item is needed for the read-more component }}
-<div data-test-info-table-item-array {{did-insert this.fetchOptions}} class="linkable-item">
+{{! the class linked-block-item is needed for the read-more component }}
+<div data-test-info-table-item-array {{did-insert this.fetchOptions}} class="linked-block-item">
   {{#if @isLink}}
     <div data-test-row-value={{@label}}>
       {{#if this.fetchComplete}}
diff --git a/ui/lib/core/addon/templates/components/read-more.hbs b/ui/lib/core/addon/templates/components/read-more.hbs
index 541e4f3bc3..381d783531 100644
--- a/ui/lib/core/addon/templates/components/read-more.hbs
+++ b/ui/lib/core/addon/templates/components/read-more.hbs
@@ -8,7 +8,7 @@
     {{yield}}
   </span>
   {{#if this.hasOverflow}}
-    <div class="linkable-item-seemore" data-test-readmore-toggle>
+    <div class="linked-block-seemore" data-test-readmore-toggle>
       <button {{on "click" this.toggleOpen}} class="link link-plain" type="button">
         {{#if this.isOpen}}
           See Less
diff --git a/ui/lib/core/app/components/linkable-item/content.js b/ui/lib/core/app/components/linkable-item/content.js
deleted file mode 100644
index b44c617b9e..0000000000
--- a/ui/lib/core/app/components/linkable-item/content.js
+++ /dev/null
@@ -1,6 +0,0 @@
-/**
- * Copyright (c) HashiCorp, Inc.
- * SPDX-License-Identifier: MPL-2.0
- */
-
-export { default } from 'core/components/linkable-item/content';
diff --git a/ui/lib/core/app/components/linkable-item/menu.js b/ui/lib/core/app/components/linkable-item/menu.js
deleted file mode 100644
index 706e41ecd7..0000000000
--- a/ui/lib/core/app/components/linkable-item/menu.js
+++ /dev/null
@@ -1,6 +0,0 @@
-/**
- * Copyright (c) HashiCorp, Inc.
- * SPDX-License-Identifier: MPL-2.0
- */
-
-export { default } from 'core/components/linkable-item/menu';