mirrors/vault
1
0
Fork 0
mirror of https://github.com/hashicorp/vault.git synced 2026-05-07 13:26:27 +02:00
Code Issues Projects Releases Wiki Activity

[UI][Bugfix] VAULT-43725 Add validations for LDAP roles create / edit forms (#13757) (#13863) (#13964)

Browse Source 
* LDAP create role name field should only contain lowercase and alphanumeric characters

* Add changelog..

* Fix controller issue

Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com>
This commit is contained in:
Vault Automation 2026-04-15 15:15:59 -04:00 committed by GitHub
parent f62942aa3a
commit 7e75a27f68
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 34 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changelog/_13757.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bug
ui: Add name field validation to LDAP create and edit roles forms.
```

13
ui/app/forms/secrets/ldap/roles/dynamic.ts
View File

@ -84,7 +84,18 @@ export default class LdapDynamicRoleForm extends Form<LdapDynamicRoleFormData> {
];
validations: Validations = {
name: [{ type: 'presence', message: 'Name is required' }],
name: [
{ type: 'presence', message: 'Name is required' },
{
validator: ({ name }: LdapDynamicRoleFormData) => {
// Allow alphanumeric, hyphens, underscores, periods, and forward slashes
const validPattern = /^[a-z0-9\-_./]+$/;
return validPattern.test(name);
},
message:
'Name must be lowercase and can only contain alphanumeric characters, hyphens, underscores, periods, and forward slashes.',
},
],
creation_ldif: [{ type: 'presence', message: 'Creation LDIF is required.' }],
deletion_ldif: [{ type: 'presence', message: 'Deletion LDIF is required.' }],
};

17
ui/app/forms/secrets/ldap/roles/static.ts
View File

@ -8,11 +8,11 @@ import FormField from 'vault/utils/forms/field';
import type { Validations } from 'vault/app-types';
import type { LdapWriteStaticRoleRequest } from '@hashicorp/vault-client-typescript';
type LdapDynamicRoleFormData = LdapWriteStaticRoleRequest & {
type LdapStaticRoleFormData = LdapWriteStaticRoleRequest & {
name: string;
};
export default class LdapStaticRoleForm extends Form<LdapDynamicRoleFormData> {
export default class LdapStaticRoleForm extends Form<LdapStaticRoleFormData> {
formFields = [
new FormField('name', 'string', {
label: 'Role name',
@ -38,7 +38,18 @@ export default class LdapStaticRoleForm extends Form<LdapDynamicRoleFormData> {
];
validations: Validations = {
name: [{ type: 'presence', message: 'Name is required' }],
name: [
{ type: 'presence', message: 'Name is required' },
{
validator: ({ name }: LdapStaticRoleFormData) => {
// Allow alphanumeric, hyphens, underscores, periods, and forward slashes
const validPattern = /^[a-z0-9\-_./]+$/;
return validPattern.test(name);
},
message:
'Name must be lowercase and can only contain alphanumeric characters, hyphens, underscores, periods, and forward slashes.',
},
],
username: [{ type: 'presence', message: 'Username is required.' }],
rotation_period: [{ type: 'presence', message: 'Rotation Period is required.' }],
};

8
ui/lib/ldap/addon/routes/error.ts
View File

@ -8,14 +8,15 @@ import { service } from '@ember/service';
import type Transition from '@ember/routing/transition';
import type AdapterError from '@ember-data/adapter/error';
import type SecretEngineModel from 'vault/models/secret-engine';
import type SecretsEngineResource from 'vault/resources/secrets/engine';
import type { Breadcrumb } from 'vault/vault/app-types';
import type Controller from '@ember/controller';
import type SecretMountPath from 'vault/services/secret-mount-path';
import type { LdapApplicationModel } from './application';
interface LdapErrorController extends Controller {
breadcrumbs: Array<Breadcrumb>;
backend: SecretEngineModel;
backend: SecretsEngineResource;
}
export default class LdapErrorRoute extends Route {
@ -28,6 +29,7 @@ export default class LdapErrorRoute extends Route {
{ label: 'Secrets engines', route: 'secrets', linkExternal: true },
{ label: this.secretMountPath.currentPath, route: 'overview' },
];
controller.backend = this.modelFor('application') as SecretEngineModel;
const { secretsEngine } = this.modelFor('application') as LdapApplicationModel;
controller.backend = secretsEngine;
}
}