mirrors/vault
1
0
Fork 0
mirror of https://github.com/hashicorp/vault.git synced 2025-11-28 22:21:30 +01:00
Code Issues Projects Releases Wiki Activity

[UI] clear policies in cli (#8291)

Browse Source 
* fix: entity policies cleared from empty string in UI console

* add test for new use case of empty value
This commit is contained in:
Chelsea Shaw 2020-02-06 12:37:38 -06:00 committed by GitHub
parent 436c9635f6
commit 482ad0a094
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui/app/lib/console-helpers.js
View File

@ -10,7 +10,8 @@ export function extractDataAndFlags(data, flags) {
(accumulator, val) => { (accumulator, val) => {
// will be "key=value" or "-flag=value" or "foo=bar=baz" // will be "key=value" or "-flag=value" or "foo=bar=baz"
// split on the first = // split on the first =
let [item, value] = val.split(/=(.+)/); // default to value of empty string
let [item, value = ''] = val.split(/=(.+)?/);
if (item.startsWith('-')) { if (item.startsWith('-')) {
let flagName = item.replace(/^-/, ''); let flagName = item.replace(/^-/, '');
if (flagName === 'wrap-ttl') { if (flagName === 'wrap-ttl') {
@ -26,7 +27,6 @@ export function extractDataAndFlags(data, flags) {
return accumulator; return accumulator;
} }
accumulator.data[item] = value; accumulator.data[item] = value;
return accumulator; return accumulator;
}, },
{ data: {}, flags: {} } { data: {}, flags: {} }

11
ui/tests/unit/lib/console-helpers-test.js
View File

@ -166,6 +166,17 @@ module('Unit | Lib | console helpers', function() {
flags: {}, flags: {},
}, },
}, },
{
name: 'data with empty values',
input: [[`foo=`, 'some=thing'], []],
expected: {
data: {
foo: '',
some: 'thing',
},
flags: {},
},
},
]; ];
testExtractCases.forEach(function(testCase) { testExtractCases.forEach(function(testCase) {