VAULT-33008: ipv6: always display RFC-5952 §4 conformant addresses (#29228)

USGv6[0] requires implementing §4.1.1 of the NISTv6-r1 profile[1] for
IPv6-Only capabilities. This section requires that whenever Vault
displays IPv6 addresses (including CLI output, Web UI, logs, etc.) that
_all_ IPv6 addresses must conform to RFC-5952 §4 text representation
recommendations[2].

These recommendations do not prevent us from accepting RFC-4241[3] IPv6
addresses, however, whenever these same addresses are displayed they
must conform to the strict RFC-5952 §4 guidelines.

This PR implements handling of IPv6 address conformance in our
`vault server` routine. We handle conformance normalization for all
server, http_proxy, listener, seal, storage and telemetry
configuration where an input could contain an IPv6 address, whether
configured via an HCL file or via corresponding environment variables.

The approach I've taken is to handle conformance normalization at
parse time to ensure that all log output and subsequent usage
inside of Vaults various subsystems always reference a conformant
address, that way we don't need concern ourselves with conformance
later. This approach ought to be backwards compatible to prior loose
address configuration requirements, with the understanding that
going forward all IPv6 representation will be strict regardless of
what has been configured.

In many cases I've updated our various parser functions to call the
new `configutil.NormalizeAddr()` to apply conformance normalization.
Others required no changes because they rely on standard library URL
string output, which always displays IPv6 URLs in a conformant way.

Not included in this changes is any other vault exec mode other than
server. Client, operator commands, agent mode, proxy mode, etc. will
be included in subsequent changes if necessary.

[0]: https://www.nist.gov/publications/usgv6-profile
[1]: https://www.nist.gov/publications/nist-ipv6-profile
[2]: https://www.rfc-editor.org/rfc/rfc5952.html#section-4
[3]: https://www.rfc-editor.org/rfc/rfc4291

Signed-off-by: Ryan Cragun <me@ryan.ec>
This commit is contained in:
Ryan Cragun 2025-01-27 14:14:28 -07:00 committed by GitHub
parent 9456671f04
commit 012cd5a42a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
20 changed files with 1423 additions and 141 deletions

3
changelog/29228.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:change
server/config: Configuration values including IPv6 addresses will be automatically translated and displayed conformant to RFC-5952 §4.
```

View File

@ -190,23 +190,23 @@ func TestMigration(t *testing.T) {
cmd := new(OperatorMigrateCommand) cmd := new(OperatorMigrateCommand)
cfgName := filepath.Join(t.TempDir(), "migrator") cfgName := filepath.Join(t.TempDir(), "migrator")
os.WriteFile(cfgName, []byte(` os.WriteFile(cfgName, []byte(`
storage_source "src_type" { storage_source "consul" {
path = "src_path" path = "src_path"
} }
storage_destination "dest_type" { storage_destination "raft" {
path = "dest_path" path = "dest_path"
}`), 0o644) }`), 0o644)
expCfg := &migratorConfig{ expCfg := &migratorConfig{
StorageSource: &server.Storage{ StorageSource: &server.Storage{
Type: "src_type", Type: "consul",
Config: map[string]string{ Config: map[string]string{
"path": "src_path", "path": "src_path",
}, },
}, },
StorageDestination: &server.Storage{ StorageDestination: &server.Storage{
Type: "dest_type", Type: "raft",
Config: map[string]string{ Config: map[string]string{
"path": "dest_path", "path": "dest_path",
}, },
@ -230,41 +230,41 @@ storage_destination "dest_type" {
// missing source // missing source
verifyBad(` verifyBad(`
storage_destination "dest_type" { storage_destination "raft" {
path = "dest_path" path = "dest_path"
}`) }`)
// missing destination // missing destination
verifyBad(` verifyBad(`
storage_source "src_type" { storage_source "consul" {
path = "src_path" path = "src_path"
}`) }`)
// duplicate source // duplicate source
verifyBad(` verifyBad(`
storage_source "src_type" { storage_source "consul" {
path = "src_path" path = "src_path"
} }
storage_source "src_type2" { storage_source "raft" {
path = "src_path" path = "src_path"
} }
storage_destination "dest_type" { storage_destination "raft" {
path = "dest_path" path = "dest_path"
}`) }`)
// duplicate destination // duplicate destination
verifyBad(` verifyBad(`
storage_source "src_type" { storage_source "consul" {
path = "src_path" path = "src_path"
} }
storage_destination "dest_type" { storage_destination "raft" {
path = "dest_path" path = "dest_path"
} }
storage_destination "dest_type2" { storage_destination "consul" {
path = "dest_path" path = "dest_path"
}`) }`)
}) })

View File

@ -514,7 +514,7 @@ func (c *ServerCommand) runRecoveryMode() int {
} }
if config.Storage.Type == storageTypeRaft || (config.HAStorage != nil && config.HAStorage.Type == storageTypeRaft) { if config.Storage.Type == storageTypeRaft || (config.HAStorage != nil && config.HAStorage.Type == storageTypeRaft) {
if envCA := os.Getenv("VAULT_CLUSTER_ADDR"); envCA != "" { if envCA := os.Getenv("VAULT_CLUSTER_ADDR"); envCA != "" {
config.ClusterAddr = envCA config.ClusterAddr = configutil.NormalizeAddr(envCA)
} }
if len(config.ClusterAddr) == 0 { if len(config.ClusterAddr) == 0 {
@ -742,9 +742,9 @@ func (c *ServerCommand) runRecoveryMode() int {
func logProxyEnvironmentVariables(logger hclog.Logger) { func logProxyEnvironmentVariables(logger hclog.Logger) {
proxyCfg := httpproxy.FromEnvironment() proxyCfg := httpproxy.FromEnvironment()
cfgMap := map[string]string{ cfgMap := map[string]string{
"http_proxy": proxyCfg.HTTPProxy, "http_proxy": configutil.NormalizeAddr(proxyCfg.HTTPProxy),
"https_proxy": proxyCfg.HTTPSProxy, "https_proxy": configutil.NormalizeAddr(proxyCfg.HTTPSProxy),
"no_proxy": proxyCfg.NoProxy, "no_proxy": configutil.NormalizeAddr(proxyCfg.NoProxy),
} }
for k, v := range cfgMap { for k, v := range cfgMap {
u, err := url.Parse(v) u, err := url.Parse(v)
@ -2243,7 +2243,7 @@ func (c *ServerCommand) detectRedirect(detect physical.RedirectDetect,
} }
// Return the URL string // Return the URL string
return url.String(), nil return configutil.NormalizeAddr(url.String()), nil
} }
func (c *ServerCommand) Reload(lock *sync.RWMutex, reloadFuncs *map[string][]reloadutil.ReloadFunc, configPath []string, core *vault.Core) error { func (c *ServerCommand) Reload(lock *sync.RWMutex, reloadFuncs *map[string][]reloadutil.ReloadFunc, configPath []string, core *vault.Core) error {
@ -2749,11 +2749,11 @@ func initHaBackend(c *ServerCommand, config *server.Config, coreConfig *vault.Co
func determineRedirectAddr(c *ServerCommand, coreConfig *vault.CoreConfig, config *server.Config) error { func determineRedirectAddr(c *ServerCommand, coreConfig *vault.CoreConfig, config *server.Config) error {
var retErr error var retErr error
if envRA := os.Getenv("VAULT_API_ADDR"); envRA != "" { if envRA := os.Getenv("VAULT_API_ADDR"); envRA != "" {
coreConfig.RedirectAddr = envRA coreConfig.RedirectAddr = configutil.NormalizeAddr(envRA)
} else if envRA := os.Getenv("VAULT_REDIRECT_ADDR"); envRA != "" { } else if envRA := os.Getenv("VAULT_REDIRECT_ADDR"); envRA != "" {
coreConfig.RedirectAddr = envRA coreConfig.RedirectAddr = configutil.NormalizeAddr(envRA)
} else if envAA := os.Getenv("VAULT_ADVERTISE_ADDR"); envAA != "" { } else if envAA := os.Getenv("VAULT_ADVERTISE_ADDR"); envAA != "" {
coreConfig.RedirectAddr = envAA coreConfig.RedirectAddr = configutil.NormalizeAddr(envAA)
} }
// Attempt to detect the redirect address, if possible // Attempt to detect the redirect address, if possible
@ -2785,7 +2785,7 @@ func determineRedirectAddr(c *ServerCommand, coreConfig *vault.CoreConfig, confi
if c.flagDevTLS { if c.flagDevTLS {
protocol = "https" protocol = "https"
} }
coreConfig.RedirectAddr = fmt.Sprintf("%s://%s", protocol, config.Listeners[0].Address) coreConfig.RedirectAddr = configutil.NormalizeAddr(fmt.Sprintf("%s://%s", protocol, config.Listeners[0].Address))
} }
return retErr return retErr
} }
@ -2794,7 +2794,7 @@ func findClusterAddress(c *ServerCommand, coreConfig *vault.CoreConfig, config *
if disableClustering { if disableClustering {
coreConfig.ClusterAddr = "" coreConfig.ClusterAddr = ""
} else if envCA := os.Getenv("VAULT_CLUSTER_ADDR"); envCA != "" { } else if envCA := os.Getenv("VAULT_CLUSTER_ADDR"); envCA != "" {
coreConfig.ClusterAddr = envCA coreConfig.ClusterAddr = configutil.NormalizeAddr(envCA)
} else { } else {
var addrToUse string var addrToUse string
switch { switch {
@ -2826,7 +2826,7 @@ func findClusterAddress(c *ServerCommand, coreConfig *vault.CoreConfig, config *
u.Host = net.JoinHostPort(host, strconv.Itoa(nPort+1)) u.Host = net.JoinHostPort(host, strconv.Itoa(nPort+1))
// Will always be TLS-secured // Will always be TLS-secured
u.Scheme = "https" u.Scheme = "https"
coreConfig.ClusterAddr = u.String() coreConfig.ClusterAddr = configutil.NormalizeAddr(u.String())
} }
CLUSTER_SYNTHESIS_COMPLETE: CLUSTER_SYNTHESIS_COMPLETE:

View File

@ -11,6 +11,7 @@ import (
"math" "math"
"os" "os"
"path/filepath" "path/filepath"
"slices"
"strconv" "strconv"
"strings" "strings"
"time" "time"
@ -934,33 +935,49 @@ func ParseStorage(result *Config, list *ast.ObjectList, name string) error {
} }
m := make(map[string]string) m := make(map[string]string)
for key, val := range config { for k, v := range config {
valStr, ok := val.(string) vStr, ok := v.(string)
if ok { if ok {
m[key] = valStr var err error
continue m[k], err = normalizeStorageConfigAddresses(key, k, vStr)
}
valBytes, err := json.Marshal(val)
if err != nil { if err != nil {
return err return err
} }
m[key] = string(valBytes) continue
}
var err error
var vBytes []byte
// Raft's retry_join requires special normalization due to its complexity
if key == "raft" && k == "retry_join" {
vBytes, err = normalizeRaftRetryJoin(v)
if err != nil {
return err
}
} else {
vBytes, err = json.Marshal(v)
if err != nil {
return err
}
}
m[k] = string(vBytes)
} }
// Pull out the redirect address since it's common to all backends // Pull out the redirect address since it's common to all backends
var redirectAddr string var redirectAddr string
if v, ok := m["redirect_addr"]; ok { if v, ok := m["redirect_addr"]; ok {
redirectAddr = v redirectAddr = configutil.NormalizeAddr(v)
delete(m, "redirect_addr") delete(m, "redirect_addr")
} else if v, ok := m["advertise_addr"]; ok { } else if v, ok := m["advertise_addr"]; ok {
redirectAddr = v redirectAddr = configutil.NormalizeAddr(v)
delete(m, "advertise_addr") delete(m, "advertise_addr")
} }
// Pull out the cluster address since it's common to all backends // Pull out the cluster address since it's common to all backends
var clusterAddr string var clusterAddr string
if v, ok := m["cluster_addr"]; ok { if v, ok := m["cluster_addr"]; ok {
clusterAddr = v clusterAddr = configutil.NormalizeAddr(v)
delete(m, "cluster_addr") delete(m, "cluster_addr")
} }
@ -997,6 +1014,120 @@ func ParseStorage(result *Config, list *ast.ObjectList, name string) error {
return nil return nil
} }
// storageAddressKeys maps a storage backend type to its associated
// configuration whose values are URLs, IP addresses, or host:port style
// addresses. All physical storage types must have an entry in this map,
// otherwise our normalization check will fail when parsing the storage entry
// config. Physical storage types which don't contain such keys should include
// an empty array.
var storageAddressKeys = map[string][]string{
"aerospike": {"hostname"},
"alicloudoss": {"endpoint"},
"azure": {"arm_endpoint"},
"cassandra": {"hosts"},
"cockroachdb": {"connection_url"},
"consul": {"address", "service_address"},
"couchdb": {"endpoint"},
"dynamodb": {"endpoint"},
"etcd": {"address", "discovery_srv"},
"file": {},
"filesystem": {},
"foundationdb": {},
"gcs": {},
"inmem": {},
"inmem_ha": {},
"inmem_transactional": {},
"inmem_transactional_ha": {},
"manta": {"url"},
"mssql": {"server"},
"mysql": {"address"},
"oci": {},
"postgresql": {"connection_url"},
"raft": {}, // retry_join is handled separately in normalizeRaftRetryJoin()
"s3": {"endpoint"},
"spanner": {},
"swift": {"auth_url", "storage_url"},
"zookeeper": {"address"},
}
// normalizeStorageConfigAddresses takes a storage name, a configuration key
// and it's associated value and will normalize any URLs, IP addresses, or
// host:port style addresses.
func normalizeStorageConfigAddresses(storage string, key string, value string) (string, error) {
keys, ok := storageAddressKeys[storage]
if !ok {
return "", fmt.Errorf("unknown storage type %s", storage)
}
if slices.Contains(keys, key) {
return configutil.NormalizeAddr(value), nil
}
return value, nil
}
// normalizeRaftRetryJoin takes the hcl decoded value representation of a
// retry_join stanza and normalizes any URLs, IP addresses, or host:port style
// addresses, and returns the value encoded as JSON.
func normalizeRaftRetryJoin(val any) ([]byte, error) {
res := []map[string]any{}
// Depending on whether the retry_join stanzas were configured as an attribute,
// a block, or a mixture of both, we'll get different values from which we
// need to extract our individual retry joins stanzas.
stanzas := []map[string]any{}
if retryJoin, ok := val.([]map[string]any); ok {
// retry_join stanzas are defined as blocks
stanzas = retryJoin
} else {
// retry_join stanzas are defined as attributes or attributes and blocks
retryJoin, ok := val.([]any)
if !ok {
// retry_join stanzas have not been configured correctly
return nil, fmt.Errorf("malformed retry_join stanza: %v", val)
}
for _, stanza := range retryJoin {
stanzaVal, ok := stanza.(map[string]any)
if !ok {
return nil, fmt.Errorf("malformed retry_join stanza: %v", stanza)
}
stanzas = append(stanzas, stanzaVal)
}
}
for _, stanza := range stanzas {
normalizedStanza := map[string]any{}
for k, v := range stanza {
switch k {
case "auto_join":
pairs := strings.Split(v.(string), " ")
for i, pair := range pairs {
pairParts := strings.Split(pair, "=")
if len(pairParts) != 2 {
return nil, fmt.Errorf("malformed auto_join pair %s, expected key=value", pair)
}
// These are auto_join keys that are valid for the provider in go-discover
if slices.Contains([]string{"domain", "auth_url", "url", "host"}, pairParts[0]) {
pairParts[1] = configutil.NormalizeAddr(pairParts[1])
pair = strings.Join(pairParts, "=")
pairs[i] = pair
}
}
normalizedStanza[k] = strings.Join(pairs, " ")
case "leader_api_addr":
normalizedStanza[k] = configutil.NormalizeAddr(v.(string))
default:
normalizedStanza[k] = v
}
}
res = append(res, normalizedStanza)
}
return json.Marshal(res)
}
func parseHAStorage(result *Config, list *ast.ObjectList, name string) error { func parseHAStorage(result *Config, list *ast.ObjectList, name string) error {
if len(list.Items) > 1 { if len(list.Items) > 1 {
return fmt.Errorf("only one %q block is permitted", name) return fmt.Errorf("only one %q block is permitted", name)
@ -1016,33 +1147,49 @@ func parseHAStorage(result *Config, list *ast.ObjectList, name string) error {
} }
m := make(map[string]string) m := make(map[string]string)
for key, val := range config { for k, v := range config {
valStr, ok := val.(string) vStr, ok := v.(string)
if ok { if ok {
m[key] = valStr var err error
continue m[k], err = normalizeStorageConfigAddresses(key, k, vStr)
}
valBytes, err := json.Marshal(val)
if err != nil { if err != nil {
return err return err
} }
m[key] = string(valBytes) continue
}
var err error
var vBytes []byte
// Raft's retry_join requires special normalization due to its complexity
if key == "raft" && k == "retry_join" {
vBytes, err = normalizeRaftRetryJoin(v)
if err != nil {
return err
}
} else {
vBytes, err = json.Marshal(v)
if err != nil {
return err
}
}
m[k] = string(vBytes)
} }
// Pull out the redirect address since it's common to all backends // Pull out the redirect address since it's common to all backends
var redirectAddr string var redirectAddr string
if v, ok := m["redirect_addr"]; ok { if v, ok := m["redirect_addr"]; ok {
redirectAddr = v redirectAddr = configutil.NormalizeAddr(v)
delete(m, "redirect_addr") delete(m, "redirect_addr")
} else if v, ok := m["advertise_addr"]; ok { } else if v, ok := m["advertise_addr"]; ok {
redirectAddr = v redirectAddr = configutil.NormalizeAddr(v)
delete(m, "advertise_addr") delete(m, "advertise_addr")
} }
// Pull out the cluster address since it's common to all backends // Pull out the cluster address since it's common to all backends
var clusterAddr string var clusterAddr string
if v, ok := m["cluster_addr"]; ok { if v, ok := m["cluster_addr"]; ok {
clusterAddr = v clusterAddr = configutil.NormalizeAddr(v)
delete(m, "cluster_addr") delete(m, "cluster_addr")
} }
@ -1096,6 +1243,12 @@ func parseServiceRegistration(result *Config, list *ast.ObjectList, name string)
return multierror.Prefix(err, fmt.Sprintf("%s.%s:", name, key)) return multierror.Prefix(err, fmt.Sprintf("%s.%s:", name, key))
} }
if key == "consul" {
if addr, ok := m["address"]; ok {
m["address"] = configutil.NormalizeAddr(addr)
}
}
result.ServiceRegistration = &ServiceRegistration{ result.ServiceRegistration = &ServiceRegistration{
Type: strings.ToLower(key), Type: strings.ToLower(key),
Config: m, Config: m,

View File

@ -65,6 +65,14 @@ func TestParseStorage(t *testing.T) {
testParseStorageTemplate(t) testParseStorageTemplate(t)
} }
// TestParseStorageURLConformance tests that all config attrs whose values can be
// URLs, IP addresses, or host:port addresses, when configured with an IPv6
// address, the normalized to be conformant with RFC-5942 §4
// See: https://rfc-editor.org/rfc/rfc5952.html
func TestParseStorageURLConformance(t *testing.T) {
testParseStorageURLConformance(t)
}
// TestConfigWithAdministrativeNamespace tests that .hcl and .json configurations are correctly parsed when the administrative_namespace_path is present. // TestConfigWithAdministrativeNamespace tests that .hcl and .json configurations are correctly parsed when the administrative_namespace_path is present.
func TestConfigWithAdministrativeNamespace(t *testing.T) { func TestConfigWithAdministrativeNamespace(t *testing.T) {
testConfigWithAdministrativeNamespaceHcl(t) testConfigWithAdministrativeNamespaceHcl(t)

View File

@ -4,6 +4,7 @@
package server package server
import ( import (
"encoding/json"
"fmt" "fmt"
"reflect" "reflect"
"sort" "sort"
@ -29,36 +30,53 @@ func boolPointer(x bool) *bool {
return &x return &x
} }
// testConfigRaftRetryJoin decodes and normalizes retry_join stanzas.
func testConfigRaftRetryJoin(t *testing.T) { func testConfigRaftRetryJoin(t *testing.T) {
config, err := LoadConfigFile("./test-fixtures/raft_retry_join.hcl") t.Parallel()
if err != nil {
t.Fatal(err) retryJoinExpected := []map[string]string{
{"leader_api_addr": "http://127.0.0.1:8200"},
{"leader_api_addr": "http://[2001:db8::2:1]:8200"},
{"auto_join": "provider=mdns service=consul domain=2001:db8::2:1"},
{"auto_join": "provider=os tag_key=consul tag_value=server username=foo password=bar auth_url=https://[2001:db8::2:1]/auth"},
{"auto_join": "provider=triton account=testaccount url=https://[2001:db8::2:1] key_id=1234 tag_key=consul-role tag_value=server"},
{"auto_join": "provider=packet auth_token=token project=uuid url=https://[2001:db8::2:1] address_type=public_v6"},
{"auto_join": "provider=vsphere category_name=consul-role tag_name=consul-server host=https://[2001:db8::2:1] user=foo password=bar insecure_ssl=false"},
} }
retryJoinConfig := `[{"leader_api_addr":"http://127.0.0.1:8200"},{"leader_api_addr":"http://127.0.0.2:8200"},{"leader_api_addr":"http://127.0.0.3:8200"}]` for _, cfg := range []string{
expected := &Config{ "attr",
SharedConfig: &configutil.SharedConfig{ "block",
Listeners: []*configutil.Listener{ "mixed",
} {
t.Run(cfg, func(t *testing.T) {
t.Parallel()
config, err := LoadConfigFile(fmt.Sprintf("./test-fixtures/raft_retry_join_%s.hcl", cfg))
require.NoError(t, err)
retryJoinJSON, err := json.Marshal(retryJoinExpected)
require.NoError(t, err)
expected := NewConfig()
expected.SharedConfig.Listeners = []*configutil.Listener{
{ {
Type: "tcp", Type: "tcp",
Address: "127.0.0.1:8200", Address: "127.0.0.1:8200",
CustomResponseHeaders: DefaultCustomHeaders, CustomResponseHeaders: DefaultCustomHeaders,
}, },
}, }
DisableMlock: true, expected.SharedConfig.DisableMlock = true
}, expected.Storage = &Storage{
Storage: &Storage{
Type: "raft", Type: "raft",
Config: map[string]string{ Config: map[string]string{
"path": "/storage/path/raft", "path": "/storage/path/raft",
"node_id": "raft1", "node_id": "raft1",
"retry_join": retryJoinConfig, "retry_join": string(retryJoinJSON),
},
}, },
} }
config.Prune() config.Prune()
if diff := deep.Equal(config, expected); diff != nil { require.EqualValues(t, expected.SharedConfig, config.SharedConfig)
t.Fatal(diff) require.EqualValues(t, expected.Storage, config.Storage)
})
} }
} }
@ -144,6 +162,7 @@ func testLoadConfigFile_topLevel(t *testing.T, entropy *configutil.Entropy) {
Type: "consul", Type: "consul",
Config: map[string]string{ Config: map[string]string{
"foo": "bar", "foo": "bar",
"address": "https://[2001:db8::1]:8500",
}, },
}, },
@ -1124,6 +1143,313 @@ ha_storage "consul" {
} }
} }
// testParseStorageURLConformance verifies that any storage configuration that
// takes a URL, IP Address, or host:port address conforms to RFC-5942 §4 when
// configured with an IPv6 address. See: https://rfc-editor.org/rfc/rfc5952.html
func testParseStorageURLConformance(t *testing.T) {
t.Parallel()
for name, tc := range map[string]struct {
config string
expected *Storage
shouldFail bool
}{
"aerospike": {
config: `
storage "aerospike" {
hostname = "2001:db8:0:0:0:0:2:1"
port = "3000"
namespace = "test"
set = "vault"
username = "admin"
password = "admin"
}`,
expected: &Storage{
Type: "aerospike",
Config: map[string]string{
"hostname": "2001:db8::2:1",
"port": "3000",
"namespace": "test",
"set": "vault",
"username": "admin",
"password": "admin",
},
},
},
"alicloudoss": {
config: `
storage "alicloudoss" {
access_key = "abcd1234"
secret_key = "defg5678"
endpoint = "2001:db8:0:0:0:0:2:1"
bucket = "my-bucket"
}`,
expected: &Storage{
Type: "alicloudoss",
Config: map[string]string{
"access_key": "abcd1234",
"secret_key": "defg5678",
"endpoint": "2001:db8::2:1",
"bucket": "my-bucket",
},
},
},
"azure": {
config: `
storage "azure" {
accountName = "my-storage-account"
accountKey = "abcd1234"
arm_endpoint = "2001:db8:0:0:0:0:2:1"
container = "container-efgh5678"
environment = "AzurePublicCloud"
}`,
expected: &Storage{
Type: "azure",
Config: map[string]string{
"accountName": "my-storage-account",
"accountKey": "abcd1234",
"arm_endpoint": "2001:db8::2:1",
"container": "container-efgh5678",
"environment": "AzurePublicCloud",
},
},
},
"cassandra": {
config: `
storage "cassandra" {
hosts = "2001:db8:0:0:0:0:2:1"
consistency = "LOCAL_QUORUM"
protocol_version = 3
}`,
expected: &Storage{
Type: "cassandra",
Config: map[string]string{
"hosts": "2001:db8::2:1",
"consistency": "LOCAL_QUORUM",
"protocol_version": "3",
},
},
},
"cockroachdb": {
config: `
storage "cockroachdb" {
connection_url = "postgres://user123:secret123!@2001:db8:0:0:0:0:2:1:5432/vault"
table = "vault_kv_store"
}`,
expected: &Storage{
Type: "cockroachdb",
Config: map[string]string{
"connection_url": "postgres://user123:secret123%21@[2001:db8::2:1]:5432/vault",
"table": "vault_kv_store",
},
},
},
"consul": {
config: `
storage "consul" {
address = "2001:db8:0:0:0:0:2:1:8500"
path = "vault/"
}`,
expected: &Storage{
Type: "consul",
Config: map[string]string{
"address": "2001:db8::2:1:8500",
"path": "vault/",
},
},
},
"couchdb": {
config: `
storage "couchdb" {
endpoint = "https://[2001:db8:0:0:0:0:2:1]:5984/my-database"
username = "admin"
password = "admin"
}`,
expected: &Storage{
Type: "couchdb",
Config: map[string]string{
"endpoint": "https://[2001:db8::2:1]:5984/my-database",
"username": "admin",
"password": "admin",
},
},
},
"dynamodb": {
config: `
storage "dynamodb" {
endpoint = "https://[2001:db8:0:0:0:0:2:1]:5984/my-aws-endpoint"
ha_enabled = "true"
region = "us-west-2"
table = "vault-data"
}`,
expected: &Storage{
Type: "dynamodb",
Config: map[string]string{
"endpoint": "https://[2001:db8::2:1]:5984/my-aws-endpoint",
"ha_enabled": "true",
"region": "us-west-2",
"table": "vault-data",
},
},
},
"etcd": {
config: `
storage "etcd" {
address = "https://[2001:db8:0:0:0:0:2:1]:2379"
discovery_srv = "https://[2001:db8:0:0:1:0:0:1]"
etcd_api = "v3"
}`,
expected: &Storage{
Type: "etcd",
Config: map[string]string{
"address": "https://[2001:db8::2:1]:2379",
"discovery_srv": "https://[2001:db8::1:0:0:1]",
"etcd_api": "v3",
},
},
},
"manta": {
config: `
storage "manta" {
directory = "manta-directory"
user = "myuser"
key_id = "40:9d:d3:f9:0b:86:62:48:f4:2e:a5:8e:43:00:2a:9b"
url = "https://[2001:db8:0:0:0:0:2:1]"
}`,
expected: &Storage{
Type: "manta",
Config: map[string]string{
"directory": "manta-directory",
"user": "myuser",
"key_id": "40:9d:d3:f9:0b:86:62:48:f4:2e:a5:8e:43:00:2a:9b",
"url": "https://[2001:db8::2:1]",
},
},
},
"mssql": {
config: `
storage "mssql" {
server = "2001:db8:0:0:0:0:2:1"
port = 1433
username = "user1234"
password = "secret123!"
database = "vault"
table = "vault"
appname = "vault"
schema = "dbo"
connectionTimeout = 30
logLevel = 0
}`,
expected: &Storage{
Type: "mssql",
Config: map[string]string{
"server": "2001:db8::2:1",
"port": "1433",
"username": "user1234",
"password": "secret123!",
"database": "vault",
"table": "vault",
"appname": "vault",
"schema": "dbo",
"connectionTimeout": "30",
"logLevel": "0",
},
},
},
"mysql": {
config: `
storage "mysql" {
address = "2001:db8:0:0:0:0:2:1:3306"
username = "user1234"
password = "secret123!"
database = "vault"
}`,
expected: &Storage{
Type: "mysql",
Config: map[string]string{
"address": "2001:db8::2:1:3306",
"username": "user1234",
"password": "secret123!",
"database": "vault",
},
},
},
"postgresql": {
config: `
storage "postgresql" {
connection_url = "postgres://user123:secret123!@2001:db8:0:0:0:0:2:1:5432/vault"
table = "vault_kv_store"
}`,
expected: &Storage{
Type: "postgresql",
Config: map[string]string{
"connection_url": "postgres://user123:secret123%21@[2001:db8::2:1]:5432/vault",
"table": "vault_kv_store",
},
},
},
"s3": {
config: `
storage "s3" {
endpoint = "https://[2001:db8:0:0:0:0:2:1]:5984/my-aws-endpoint"
access_key = "abcd1234"
secret_key = "defg5678"
bucket = "my-bucket"
}`,
expected: &Storage{
Type: "s3",
Config: map[string]string{
"endpoint": "https://[2001:db8::2:1]:5984/my-aws-endpoint",
"access_key": "abcd1234",
"secret_key": "defg5678",
"bucket": "my-bucket",
},
},
},
"swift": {
config: `
storage "swift" {
auth_url = "https://[2001:db8:0:0:0:0:2:1]/auth"
storage_url = "https://[2001:db8:0:0:0:0:2:1]/storage"
username = "admin"
password = "secret123!"
container = "my-storage-container"
}`,
expected: &Storage{
Type: "swift",
Config: map[string]string{
"auth_url": "https://[2001:db8::2:1]/auth",
"storage_url": "https://[2001:db8::2:1]/storage",
"username": "admin",
"password": "secret123!",
"container": "my-storage-container",
},
},
},
"zookeeper": {
config: `
storage "zookeeper" {
address = "2001:db8:0:0:0:0:2:1:2181"
path = "vault/"
}`,
expected: &Storage{
Type: "zookeeper",
Config: map[string]string{
"address": "2001:db8::2:1:2181",
"path": "vault/",
},
},
},
} {
t.Run(name, func(t *testing.T) {
t.Parallel()
config, err := ParseConfig(tc.config, "")
require.NoError(t, err)
require.EqualValues(t, tc.expected, config.Storage)
})
}
}
func testParseSeals(t *testing.T) { func testParseSeals(t *testing.T) {
config, err := LoadConfigFile("./test-fixtures/config_seals.hcl") config, err := LoadConfigFile("./test-fixtures/config_seals.hcl")
if err != nil { if err != nil {

View File

@ -26,6 +26,7 @@ ha_storage "consul" {
service_registration "consul" { service_registration "consul" {
foo = "bar" foo = "bar"
address = "https://[2001:0db8::0001]:8500"
} }
telemetry { telemetry {

View File

@ -1,22 +0,0 @@
# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: BUSL-1.1
storage "raft" {
path = "/storage/path/raft"
node_id = "raft1"
retry_join = [
{
"leader_api_addr" = "http://127.0.0.1:8200"
},
{
"leader_api_addr" = "http://127.0.0.2:8200"
},
{
"leader_api_addr" = "http://127.0.0.3:8200"
}
]
}
listener "tcp" {
address = "127.0.0.1:8200"
}
disable_mlock = true

View File

@ -0,0 +1,32 @@
# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: BUSL-1.1
storage "raft" {
path = "/storage/path/raft"
node_id = "raft1"
retry_join = [
{ "leader_api_addr" = "http://127.0.0.1:8200" },
{ "leader_api_addr" = "http://[2001:db8:0:0:0:0:2:1]:8200" }
]
retry_join = [
{ "auto_join" = "provider=mdns service=consul domain=2001:db8:0:0:0:0:2:1" }
]
retry_join = [
{ "auto_join" = "provider=os tag_key=consul tag_value=server username=foo password=bar auth_url=https://[2001:db8:0:0:0:0:2:1]/auth" }
]
retry_join = [
{ "auto_join" = "provider=triton account=testaccount url=https://[2001:db8:0:0:0:0:2:1] key_id=1234 tag_key=consul-role tag_value=server" }
]
retry_join = [
{ "auto_join" = "provider=packet auth_token=token project=uuid url=https://[2001:db8:0:0:0:0:2:1] address_type=public_v6" }
]
retry_join = [
{ "auto_join" = "provider=vsphere category_name=consul-role tag_name=consul-server host=https://[2001:db8:0:0:0:0:2:1] user=foo password=bar insecure_ssl=false" }
]
}
listener "tcp" {
address = "127.0.0.1:8200"
}
disable_mlock = true

View File

@ -0,0 +1,35 @@
# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: BUSL-1.1
storage "raft" {
path = "/storage/path/raft"
node_id = "raft1"
retry_join {
"leader_api_addr" = "http://127.0.0.1:8200"
}
retry_join {
"leader_api_addr" = "http://[2001:db8:0:0:0:0:2:1]:8200"
}
retry_join {
"auto_join" = "provider=mdns service=consul domain=2001:db8:0:0:0:0:2:1"
}
retry_join {
"auto_join" = "provider=os tag_key=consul tag_value=server username=foo password=bar auth_url=https://[2001:db8:0:0:0:0:2:1]/auth"
}
retry_join {
"auto_join" = "provider=triton account=testaccount url=https://[2001:db8:0:0:0:0:2:1] key_id=1234 tag_key=consul-role tag_value=server"
}
retry_join {
"auto_join" = "provider=packet auth_token=token project=uuid url=https://[2001:db8:0:0:0:0:2:1] address_type=public_v6"
}
retry_join {
"auto_join" = "provider=vsphere category_name=consul-role tag_name=consul-server host=https://[2001:db8:0:0:0:0:2:1] user=foo password=bar insecure_ssl=false"
}
}
listener "tcp" {
address = "127.0.0.1:8200"
}
disable_mlock = true

View File

@ -0,0 +1,32 @@
# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: BUSL-1.1
storage "raft" {
path = "/storage/path/raft"
node_id = "raft1"
retry_join = [
{ "leader_api_addr" = "http://127.0.0.1:8200" },
{ "leader_api_addr" = "http://[2001:db8:0:0:0:0:2:1]:8200" }
]
retry_join {
"auto_join" = "provider=mdns service=consul domain=2001:db8:0:0:0:0:2:1"
}
retry_join = [
{ "auto_join" = "provider=os tag_key=consul tag_value=server username=foo password=bar auth_url=https://[2001:db8:0:0:0:0:2:1]/auth" }
]
retry_join {
"auto_join" = "provider=triton account=testaccount url=https://[2001:db8:0:0:0:0:2:1] key_id=1234 tag_key=consul-role tag_value=server"
}
retry_join = [
{ "auto_join" = "provider=packet auth_token=token project=uuid url=https://[2001:db8:0:0:0:0:2:1] address_type=public_v6" }
]
retry_join {
"auto_join" = "provider=vsphere category_name=consul-role tag_name=consul-server host=https://[2001:db8:0:0:0:0:2:1] user=foo password=bar insecure_ssl=false"
}
}
listener "tcp" {
address = "127.0.0.1:8200"
}
disable_mlock = true

View File

@ -11,6 +11,7 @@ import (
"io" "io"
"os" "os"
"regexp" "regexp"
"slices"
"strings" "strings"
"github.com/hashicorp/errwrap" "github.com/hashicorp/errwrap"
@ -157,7 +158,10 @@ func parseKMS(result *[]*KMS, list *ast.ObjectList, blockName string, maxKMS int
if err != nil { if err != nil {
return multierror.Prefix(err, fmt.Sprintf("%s.%s:", blockName, key)) return multierror.Prefix(err, fmt.Sprintf("%s.%s:", blockName, key))
} }
strMap[k] = s strMap[k], err = normalizeKMSSealConfigAddrs(key, k, s)
if err != nil {
return multierror.Prefix(err, fmt.Sprintf("%s.%s:", blockName, key))
}
} }
seal := &KMS{ seal := &KMS{
@ -214,27 +218,76 @@ func ParseKMSes(d string) ([]*KMS, error) {
return result.Seals, nil return result.Seals, nil
} }
func configureWrapper(configKMS *KMS, infoKeys *[]string, info *map[string]string, logger hclog.Logger, opts ...wrapping.Option) (wrapping.Wrapper, error) { // kmsSealAddressKeys maps seal key types to corresponding config keys whose
var wrapper wrapping.Wrapper // values might contain URLs, IP addresses, or host:port addresses. All seal
var kmsInfo map[string]string // types must contain an entry here, otherwise our normalization check will fail
var err error // when parsing the seal config. Seal types which do not contain such
// configurations ought to have an empty array as the value in the map.
var kmsSealAddressKeys = map[string][]string{
wrapping.WrapperTypeAliCloudKms.String(): {"domain"},
wrapping.WrapperTypeAwsKms.String(): {"endpoint"},
wrapping.WrapperTypeAzureKeyVault.String(): {"resource"},
wrapping.WrapperTypeGcpCkms.String(): {},
wrapping.WrapperTypeOciKms.String(): {"key_id", "crypto_endpoint", "management_endpoint"},
wrapping.WrapperTypePkcs11.String(): {},
wrapping.WrapperTypeTransit.String(): {"address"},
}
// normalizeKMSSealConfigAddrs takes a kms seal type, a config key, and its
// associated value and will normalize any URLs, IP addresses, or host:port
// addresses contained in the value if the config key is known in the
// kmsSealAddressKeys.
func normalizeKMSSealConfigAddrs(seal string, key string, value string) (string, error) {
keys, ok := kmsSealAddressKeys[seal]
if !ok {
return "", fmt.Errorf("unknown seal type %s", seal)
}
if slices.Contains(keys, key) {
return NormalizeAddr(value), nil
}
return value, nil
}
// mergeKMSEnvConfig takes a KMS and merges any normalized values set via
// environment variables.
func mergeKMSEnvConfig(configKMS *KMS) error {
envConfig := GetEnvConfigFunc(configKMS) envConfig := GetEnvConfigFunc(configKMS)
if len(envConfig) > 0 && configKMS.Config == nil { if len(envConfig) > 0 && configKMS.Config == nil {
configKMS.Config = make(map[string]string) configKMS.Config = make(map[string]string)
} }
// transit is a special case, because some config values take precedence over env vars // transit is a special case, because some config values take precedence over env vars
if configKMS.Type == wrapping.WrapperTypeTransit.String() { if configKMS.Type == wrapping.WrapperTypeTransit.String() {
mergeTransitConfig(configKMS.Config, envConfig) if err := mergeTransitConfig(configKMS.Config, envConfig); err != nil {
return err
}
} else { } else {
for name, val := range envConfig { for name, val := range envConfig {
configKMS.Config[name] = val var err error
configKMS.Config[name], err = normalizeKMSSealConfigAddrs(configKMS.Type, name, val)
if err != nil {
return err
} }
} }
}
return nil
}
func configureWrapper(configKMS *KMS, infoKeys *[]string, info *map[string]string, logger hclog.Logger, opts ...wrapping.Option) (wrapping.Wrapper, error) {
var wrapper wrapping.Wrapper
var kmsInfo map[string]string
var err error
// Get any seal config set as env variables and merge it into the KMS.
if err = mergeKMSEnvConfig(configKMS); err != nil {
return nil, err
}
switch wrapping.WrapperType(configKMS.Type) { switch wrapping.WrapperType(configKMS.Type) {
case wrapping.WrapperTypeShamir: case wrapping.WrapperTypeShamir:
return nil, nil return wrapper, nil
case wrapping.WrapperTypeAead: case wrapping.WrapperTypeAead:
wrapper, kmsInfo, err = GetAEADKMSFunc(configKMS, opts...) wrapper, kmsInfo, err = GetAEADKMSFunc(configKMS, opts...)
@ -456,7 +509,7 @@ func getEnvConfig(kms *KMS) map[string]string {
return envValues return envValues
} }
func mergeTransitConfig(config map[string]string, envConfig map[string]string) { func mergeTransitConfig(config map[string]string, envConfig map[string]string) error {
useFileTlsConfig := false useFileTlsConfig := false
for _, varName := range TransitTLSConfigVars { for _, varName := range TransitTLSConfigVars {
if _, ok := config[varName]; ok { if _, ok := config[varName]; ok {
@ -471,14 +524,20 @@ func mergeTransitConfig(config map[string]string, envConfig map[string]string) {
} }
} }
var err error
for varName, val := range envConfig { for varName, val := range envConfig {
// for some values, file config takes precedence // for some values, file config takes precedence
if strutil.StrListContains(TransitPrioritizeConfigValues, varName) && config[varName] != "" { if strutil.StrListContains(TransitPrioritizeConfigValues, varName) && config[varName] != "" {
continue continue
} }
config[varName] = val config[varName], err = normalizeKMSSealConfigAddrs(wrapping.WrapperTypeTransit.String(), varName, val)
if err != nil {
return err
} }
}
return nil
} }
func (k *KMS) Clone() *KMS { func (k *KMS) Clone() *KMS {

View File

@ -4,9 +4,11 @@
package configutil package configutil
import ( import (
"os"
"reflect" "reflect"
"testing" "testing"
"github.com/hashicorp/go-kms-wrapping/wrappers/ocikms/v2"
"github.com/stretchr/testify/require"
) )
func Test_getEnvConfig(t *testing.T) { func Test_getEnvConfig(t *testing.T) {
@ -83,20 +85,377 @@ func Test_getEnvConfig(t *testing.T) {
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
for envName, envVal := range tt.envVars { for envName, envVal := range tt.envVars {
if err := os.Setenv(envName, envVal); err != nil { t.Setenv(envName, envVal)
t.Errorf("error setting environment vars for test: %s", err)
}
} }
if got := GetEnvConfigFunc(tt.kms); !reflect.DeepEqual(got, tt.want) { if got := GetEnvConfigFunc(tt.kms); !reflect.DeepEqual(got, tt.want) {
t.Errorf("getEnvConfig() = %v, want %v", got, tt.want) t.Errorf("getEnvConfig() = %v, want %v", got, tt.want)
} }
})
for env := range tt.envVars { }
if err := os.Unsetenv(env); err != nil { }
t.Errorf("error unsetting environment vars for test: %s", err)
} // TestParseKMSesURLConformance tests that all config attrs whose values can be
} // URLs, IP addresses, or host:port addresses, when configured with an IPv6
// address, the normalized to be conformant with RFC-5942 §4
// See: https://rfc-editor.org/rfc/rfc5952.html
func TestParseKMSesURLConformance(t *testing.T) {
t.Parallel()
for name, tc := range map[string]struct {
config string
expected map[string]string
shouldFail bool
}{
"alicloudkms ipv4": {
config: `
seal "alicloudkms" {
region = "us-east-1"
domain = "kms.us-east-1.aliyuncs.com"
access_key = "0wNEpMMlzy7szvai"
secret_key = "PupkTg8jdmau1cXxYacgE736PJj4cA"
kms_key_id = "08c33a6f-4e0a-4a1b-a3fa-7ddfa1d4fb73"
}`,
expected: map[string]string{
"region": "us-east-1",
"domain": "kms.us-east-1.aliyuncs.com",
"access_key": "0wNEpMMlzy7szvai",
"secret_key": "PupkTg8jdmau1cXxYacgE736PJj4cA",
"kms_key_id": "08c33a6f-4e0a-4a1b-a3fa-7ddfa1d4fb73",
},
},
"alicloudkms ipv6": {
config: `
seal "alicloudkms" {
region = "us-east-1"
domain = "2001:db8:0:0:0:0:2:1"
access_key = "0wNEpMMlzy7szvai"
secret_key = "PupkTg8jdmau1cXxYacgE736PJj4cA"
kms_key_id = "08c33a6f-4e0a-4a1b-a3fa-7ddfa1d4fb73"
}`,
expected: map[string]string{
"region": "us-east-1",
"domain": "2001:db8::2:1",
"access_key": "0wNEpMMlzy7szvai",
"secret_key": "PupkTg8jdmau1cXxYacgE736PJj4cA",
"kms_key_id": "08c33a6f-4e0a-4a1b-a3fa-7ddfa1d4fb73",
},
},
"awskms ipv4": {
config: `
seal "awskms" {
region = "us-east-1"
access_key = "AKIAIOSFODNN7EXAMPLE"
secret_key = "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"
kms_key_id = "19ec80b0-dfdd-4d97-8164-c6examplekey"
endpoint = "https://vpce-0e1bb1852241f8cc6-pzi0do8n.kms.us-east-1.vpce.amazonaws.com"
}`,
expected: map[string]string{
"region": "us-east-1",
"access_key": "AKIAIOSFODNN7EXAMPLE",
"secret_key": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
"kms_key_id": "19ec80b0-dfdd-4d97-8164-c6examplekey",
"endpoint": "https://vpce-0e1bb1852241f8cc6-pzi0do8n.kms.us-east-1.vpce.amazonaws.com",
},
},
"awskms ipv6": {
config: `
seal "awskms" {
region = "us-east-1"
access_key = "AKIAIOSFODNN7EXAMPLE"
secret_key = "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"
kms_key_id = "19ec80b0-dfdd-4d97-8164-c6examplekey"
endpoint = "https://[2001:db8:0:0:0:0:2:1]:5984/my-aws-endpoint"
}`,
expected: map[string]string{
"region": "us-east-1",
"access_key": "AKIAIOSFODNN7EXAMPLE",
"secret_key": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
"kms_key_id": "19ec80b0-dfdd-4d97-8164-c6examplekey",
"endpoint": "https://[2001:db8::2:1]:5984/my-aws-endpoint",
},
},
"azurekeyvault ipv4": {
config: `
seal "azurekeyvault" {
tenant_id = "46646709-b63e-4747-be42-516edeaf1e14"
client_id = "03dc33fc-16d9-4b77-8152-3ec568f8af6e"
client_secret = "DUJDS3..."
vault_name = "hc-vault"
key_name = "vault_key"
resource = "vault.azure.net"
}`,
expected: map[string]string{
"tenant_id": "46646709-b63e-4747-be42-516edeaf1e14",
"client_id": "03dc33fc-16d9-4b77-8152-3ec568f8af6e",
"client_secret": "DUJDS3...",
"vault_name": "hc-vault",
"key_name": "vault_key",
"resource": "vault.azure.net",
},
},
"azurekeyvault ipv6": {
config: `
seal "azurekeyvault" {
tenant_id = "46646709-b63e-4747-be42-516edeaf1e14"
client_id = "03dc33fc-16d9-4b77-8152-3ec568f8af6e"
client_secret = "DUJDS3..."
vault_name = "hc-vault"
key_name = "vault_key"
resource = "2001:db8:0:0:0:0:2:1",
}`,
expected: map[string]string{
"tenant_id": "46646709-b63e-4747-be42-516edeaf1e14",
"client_id": "03dc33fc-16d9-4b77-8152-3ec568f8af6e",
"client_secret": "DUJDS3...",
"vault_name": "hc-vault",
"key_name": "vault_key",
"resource": "2001:db8::2:1",
},
},
"ocikms ipv4": {
config: `
seal "ocikms" {
key_id = "ocid1.key.oc1.iad.afnxza26aag4s.abzwkljsbapzb2nrha5nt3s7s7p42ctcrcj72vn3kq5qx"
crypto_endpoint = "https://afnxza26aag4s-crypto.kms.us-ashburn-1.oraclecloud.com"
management_endpoint = "https://afnxza26aag4s-management.kms.us-ashburn-1.oraclecloud.com"
auth_type_api_key = "true"
}`,
expected: map[string]string{
"key_id": "ocid1.key.oc1.iad.afnxza26aag4s.abzwkljsbapzb2nrha5nt3s7s7p42ctcrcj72vn3kq5qx",
"crypto_endpoint": "https://afnxza26aag4s-crypto.kms.us-ashburn-1.oraclecloud.com",
"management_endpoint": "https://afnxza26aag4s-management.kms.us-ashburn-1.oraclecloud.com",
"auth_type_api_key": "true",
},
},
"ocikms ipv6": {
config: `
seal "ocikms" {
key_id = "https://[2001:db8:0:0:0:0:2:1]/abzwkljsbapzb2nrha5nt3s7s7p42ctcrcj72vn3kq5qx"
crypto_endpoint = "https://[2001:db8:0:0:0:0:2:1]/afnxza26aag4s-crypto"
management_endpoint = "https://[2001:db8:0:0:0:0:2:1]/afnxza26aag4s-management"
auth_type_api_key = "true"
}`,
expected: map[string]string{
"key_id": "https://[2001:db8::2:1]/abzwkljsbapzb2nrha5nt3s7s7p42ctcrcj72vn3kq5qx",
"crypto_endpoint": "https://[2001:db8::2:1]/afnxza26aag4s-crypto",
"management_endpoint": "https://[2001:db8::2:1]/afnxza26aag4s-management",
"auth_type_api_key": "true",
},
},
"transit ipv4": {
config: `
seal "transit" {
address = "https://vault:8200"
token = "s.Qf1s5zigZ4OX6akYjQXJC1jY"
disable_renewal = "false"
key_name = "transit_key_name"
mount_path = "transit/"
namespace = "ns1/"
}
`,
expected: map[string]string{
"address": "https://vault:8200",
"token": "s.Qf1s5zigZ4OX6akYjQXJC1jY",
"disable_renewal": "false",
"key_name": "transit_key_name",
"mount_path": "transit/",
"namespace": "ns1/",
},
},
"transit ipv6": {
config: `
seal "transit" {
address = "https://[2001:db8:0:0:0:0:2:1]:8200"
token = "s.Qf1s5zigZ4OX6akYjQXJC1jY"
disable_renewal = "false"
key_name = "transit_key_name"
mount_path = "transit/"
namespace = "ns1/"
}
`,
expected: map[string]string{
"address": "https://[2001:db8::2:1]:8200",
"token": "s.Qf1s5zigZ4OX6akYjQXJC1jY",
"disable_renewal": "false",
"key_name": "transit_key_name",
"mount_path": "transit/",
"namespace": "ns1/",
},
},
} {
t.Run(name, func(t *testing.T) {
t.Parallel()
kmses, err := ParseKMSes(tc.config)
require.NoError(t, err)
require.Len(t, kmses, 1)
require.EqualValues(t, tc.expected, kmses[0].Config)
})
}
}
// TestMergeKMSEnvConfigAddrConformance tests that all env config whose values
// can be URLs, IP addresses, or host:port addresses, when configured with an
// an IPv6 address, the normalized to be conformant with RFC-5942 §4
// See: https://rfc-editor.org/rfc/rfc5952.html
func TestMergeKMSEnvConfigAddrConformance(t *testing.T) {
for name, tc := range map[string]struct {
sealType string // default to name if none given
kmsConfig map[string]string
envVars map[string]string
expected map[string]string
}{
"alicloudkms": {
kmsConfig: map[string]string{
"region": "us-east-1",
"domain": "kms.us-east-1.aliyuncs.com",
"access_key": "0wNEpMMlzy7szvai",
"secret_key": "PupkTg8jdmau1cXxYacgE736PJj4cA",
"kms_key_id": "08c33a6f-4e0a-4a1b-a3fa-7ddfa1d4fb73",
},
envVars: map[string]string{"ALICLOUD_DOMAIN": "2001:db8:0:0:0:0:2:1"},
expected: map[string]string{
"region": "us-east-1",
"domain": "2001:db8::2:1",
"access_key": "0wNEpMMlzy7szvai",
"secret_key": "PupkTg8jdmau1cXxYacgE736PJj4cA",
"kms_key_id": "08c33a6f-4e0a-4a1b-a3fa-7ddfa1d4fb73",
},
},
"awskms": {
kmsConfig: map[string]string{
"region": "us-east-1",
"access_key": "AKIAIOSFODNN7EXAMPLE",
"secret_key": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
"kms_key_id": "19ec80b0-dfdd-4d97-8164-c6examplekey",
"endpoint": "https://vpce-0e1bb1852241f8cc6-pzi0do8n.kms.us-east-1.vpce.amazonaws.com",
},
envVars: map[string]string{"AWS_KMS_ENDPOINT": "https://[2001:db8:0:0:0:0:2:1]:5984/my-aws-endpoint"},
expected: map[string]string{
"region": "us-east-1",
"access_key": "AKIAIOSFODNN7EXAMPLE",
"secret_key": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
"kms_key_id": "19ec80b0-dfdd-4d97-8164-c6examplekey",
"endpoint": "https://[2001:db8::2:1]:5984/my-aws-endpoint",
},
},
"azurekeyvault": {
kmsConfig: map[string]string{
"tenant_id": "46646709-b63e-4747-be42-516edeaf1e14",
"client_id": "03dc33fc-16d9-4b77-8152-3ec568f8af6e",
"client_secret": "DUJDS3...",
"vault_name": "hc-vault",
"key_name": "vault_key",
"resource": "vault.azure.net",
},
envVars: map[string]string{"AZURE_AD_RESOURCE": "2001:db8:0:0:0:0:2:1"},
expected: map[string]string{
"tenant_id": "46646709-b63e-4747-be42-516edeaf1e14",
"client_id": "03dc33fc-16d9-4b77-8152-3ec568f8af6e",
"client_secret": "DUJDS3...",
"vault_name": "hc-vault",
"key_name": "vault_key",
"resource": "2001:db8::2:1",
},
},
"ocikms wrapper env vars": {
sealType: "ocikms",
kmsConfig: map[string]string{
"key_id": "ocid1.key.oc1.iad.afnxza26aag4s.abzwkljsbapzb2nrha5nt3s7s7p42ctcrcj72vn3kq5qx",
"crypto_endpoint": "https://afnxza26aag4s-crypto.kms.us-ashburn-1.oraclecloud.com",
"management_endpoint": "https://afnxza26aag4s-management.kms.us-ashburn-1.oraclecloud.com",
"auth_type_api_key": "true",
},
envVars: map[string]string{
ocikms.EnvOciKmsWrapperKeyId: "https://[2001:db8:0:0:0:0:2:1]/abzwkljsbapzb2nrha5nt3s7s7p42ctcrcj72vn3kq5qx",
ocikms.EnvOciKmsWrapperCryptoEndpoint: "https://[2001:db8:0:0:0:0:2:1]/afnxza26aag4s-crypto",
ocikms.EnvOciKmsWrapperManagementEndpoint: "https://[2001:db8:0:0:0:0:2:1]/afnxza26aag4s-management",
},
expected: map[string]string{
"key_id": "https://[2001:db8::2:1]/abzwkljsbapzb2nrha5nt3s7s7p42ctcrcj72vn3kq5qx",
"crypto_endpoint": "https://[2001:db8::2:1]/afnxza26aag4s-crypto",
"management_endpoint": "https://[2001:db8::2:1]/afnxza26aag4s-management",
"auth_type_api_key": "true",
},
},
"ocikms vault env vars": {
sealType: "ocikms",
kmsConfig: map[string]string{
"key_id": "ocid1.key.oc1.iad.afnxza26aag4s.abzwkljsbapzb2nrha5nt3s7s7p42ctcrcj72vn3kq5qx",
"crypto_endpoint": "https://afnxza26aag4s-crypto.kms.us-ashburn-1.oraclecloud.com",
"management_endpoint": "https://afnxza26aag4s-management.kms.us-ashburn-1.oraclecloud.com",
"auth_type_api_key": "true",
},
envVars: map[string]string{
ocikms.EnvVaultOciKmsSealKeyId: "https://[2001:db8:0:0:0:0:2:1]/abzwkljsbapzb2nrha5nt3s7s7p42ctcrcj72vn3kq5qx",
ocikms.EnvVaultOciKmsSealCryptoEndpoint: "https://[2001:db8:0:0:0:0:2:1]/afnxza26aag4s-crypto",
ocikms.EnvVaultOciKmsSealManagementEndpoint: "https://[2001:db8:0:0:0:0:2:1]/afnxza26aag4s-management",
},
expected: map[string]string{
"key_id": "https://[2001:db8::2:1]/abzwkljsbapzb2nrha5nt3s7s7p42ctcrcj72vn3kq5qx",
"crypto_endpoint": "https://[2001:db8::2:1]/afnxza26aag4s-crypto",
"management_endpoint": "https://[2001:db8::2:1]/afnxza26aag4s-management",
"auth_type_api_key": "true",
},
},
"transit addr not in config": {
sealType: "transit",
kmsConfig: map[string]string{
"token": "s.Qf1s5zigZ4OX6akYjQXJC1jY",
"disable_renewal": "false",
"key_name": "transit_key_name",
"mount_path": "transit/",
"namespace": "ns1/",
},
envVars: map[string]string{"VAULT_ADDR": "https://[2001:db8:0:0:0:0:2:1]:8200"},
expected: map[string]string{
// NOTE: If our address has not been configured we'll fall back to VAULT_ADDR for transit.
"address": "https://[2001:db8::2:1]:8200",
"token": "s.Qf1s5zigZ4OX6akYjQXJC1jY",
"disable_renewal": "false",
"key_name": "transit_key_name",
"mount_path": "transit/",
"namespace": "ns1/",
},
},
"transit addr in config": {
sealType: "transit",
kmsConfig: map[string]string{
"address": "https://vault:8200",
"token": "s.Qf1s5zigZ4OX6akYjQXJC1jY",
"disable_renewal": "false",
"key_name": "transit_key_name",
"mount_path": "transit/",
"namespace": "ns1/",
},
envVars: map[string]string{"VAULT_ADDR": "https://[2001:db8:0:0:0:0:2:1]:8200"},
expected: map[string]string{
// NOTE: If our address has been configured we don't consider VAULT_ADDR
"address": "https://vault:8200",
"token": "s.Qf1s5zigZ4OX6akYjQXJC1jY",
"disable_renewal": "false",
"key_name": "transit_key_name",
"mount_path": "transit/",
"namespace": "ns1/",
},
},
} {
t.Run(name, func(t *testing.T) {
typ := name
if tc.sealType != "" {
typ = tc.sealType
}
kms := &KMS{
Type: typ,
Config: tc.kmsConfig,
}
for envName, envVal := range tc.envVars {
t.Setenv(envName, envVal)
}
require.NoError(t, mergeKMSEnvConfig(kms))
require.EqualValues(t, tc.expected, kms.Config)
}) })
} }
} }

View File

@ -177,7 +177,7 @@ func (l *Listener) Validate(path string) []ConfigError {
func ParseSingleIPTemplate(ipTmpl string) (string, error) { func ParseSingleIPTemplate(ipTmpl string) (string, error) {
r := regexp.MustCompile("{{.*?}}") r := regexp.MustCompile("{{.*?}}")
if !r.MatchString(ipTmpl) { if !r.MatchString(ipTmpl) {
return ipTmpl, nil return NormalizeAddr(ipTmpl), nil
} }
out, err := template.Parse(ipTmpl) out, err := template.Parse(ipTmpl)

View File

@ -16,17 +16,49 @@ import (
// ensure that we only attempt to parse templates when the input contains a // ensure that we only attempt to parse templates when the input contains a
// template placeholder (see: go-sockaddr/template). // template placeholder (see: go-sockaddr/template).
func TestListener_ParseSingleIPTemplate(t *testing.T) { func TestListener_ParseSingleIPTemplate(t *testing.T) {
t.Parallel()
tests := map[string]struct { tests := map[string]struct {
arg string arg string
want string want string
isErrorExpected bool isErrorExpected bool
errorMessage string errorMessage string
}{ }{
"test https addr": { "test hostname": {
arg: "https://vaultproject.io:8200", arg: "https://vaultproject.io:8200",
want: "https://vaultproject.io:8200", want: "https://vaultproject.io:8200",
isErrorExpected: false, isErrorExpected: false,
}, },
"test ipv4": {
arg: "https://10.10.1.10:8200",
want: "https://10.10.1.10:8200",
isErrorExpected: false,
},
"test ipv6 RFC-5952 4.1 conformance leading zeroes": {
arg: "https://[2001:0db8::0001]:8200",
want: "https://[2001:db8::1]:8200",
isErrorExpected: false,
},
"test ipv6 RFC-5952 4.2.2 conformance one 16-bit 0 field": {
arg: "https://[2001:db8:0:1:1:1:1:1]:8200",
want: "https://[2001:db8:0:1:1:1:1:1]:8200",
isErrorExpected: false,
},
"test ipv6 RFC-5952 4.2.3 conformance longest run of 0 bits shortened": {
arg: "https://[2001:0:0:1:0:0:0:1]:8200",
want: "https://[2001:0:0:1::1]:8200",
isErrorExpected: false,
},
"test ipv6 RFC-5952 4.2.3 conformance equal runs of 0 bits shortened": {
arg: "https://[2001:db8:0:0:1:0:0:1]:8200",
want: "https://[2001:db8::1:0:0:1]:8200",
isErrorExpected: false,
},
"test ipv6 RFC-5952 4.3 conformance downcase hex letters": {
arg: "https://[2001:DB8:AC3:FE4::1]:8200",
want: "https://[2001:db8:ac3:fe4::1]:8200",
isErrorExpected: false,
},
"test invalid template func": { "test invalid template func": {
arg: "{{ FooBar }}", arg: "{{ FooBar }}",
want: "", want: "",
@ -43,6 +75,7 @@ func TestListener_ParseSingleIPTemplate(t *testing.T) {
name := name name := name
tc := tc tc := tc
t.Run(name, func(t *testing.T) { t.Run(name, func(t *testing.T) {
t.Parallel()
got, err := ParseSingleIPTemplate(tc.arg) got, err := ParseSingleIPTemplate(tc.arg)
if tc.isErrorExpected { if tc.isErrorExpected {

View File

@ -0,0 +1,91 @@
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: BUSL-1.1
package configutil
import (
"fmt"
"net"
"net/url"
"strings"
)
// NormalizeAddr takes an address as a string and returns a normalized copy.
// If the addr is a URL, IP Address, or host:port address that includes an IPv6
// address, the normalized copy will be conformant with RFC-5942 §4
// See: https://rfc-editor.org/rfc/rfc5952.html
func NormalizeAddr(address string) string {
if address == "" {
return ""
}
var ip net.IP
var port string
bracketedIPv6 := false
// Try parsing it as a URL
pu, err := url.Parse(address)
if err == nil {
// We've been given something that appears to be a URL. See if the hostname
// is an IP address
ip = net.ParseIP(pu.Hostname())
} else {
// We haven't been given a URL. Try and parse it as an IP address
ip = net.ParseIP(address)
if ip == nil {
// We haven't been given a URL or IP address, try parsing an IP:Port
// combination.
idx := strings.LastIndex(address, ":")
if idx > 0 {
// We've perhaps received an IP:Port address
addr := address[:idx]
port = address[idx+1:]
if strings.HasPrefix(addr, "[") && strings.HasSuffix(addr, "]") {
addr = strings.TrimPrefix(strings.TrimSuffix(addr, "]"), "[")
bracketedIPv6 = true
}
ip = net.ParseIP(addr)
}
}
}
// If our IP is nil whatever was passed in does not contain an IP address.
if ip == nil {
return address
}
if v4 := ip.To4(); v4 != nil {
return address
}
if v6 := ip.To16(); v6 != nil {
// net.IP String() will return IPv6 RFC-5952 conformant addresses.
if pu != nil {
// Return the URL in conformant fashion
if port := pu.Port(); port != "" {
pu.Host = fmt.Sprintf("[%s]:%s", v6.String(), port)
} else {
pu.Host = fmt.Sprintf("[%s]", v6.String())
}
return pu.String()
}
// Handle IP:Port addresses
if port != "" {
// Return the address:port or [address]:port
if bracketedIPv6 {
return fmt.Sprintf("[%s]:%s", v6.String(), port)
} else {
return fmt.Sprintf("%s:%s", v6.String(), port)
}
}
// Handle just an IP address
return v6.String()
}
// It shouldn't be possible to get to this point. If we somehow we manage
// to, return the string unchanged.
return address
}

View File

@ -0,0 +1,96 @@
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: BUSL-1.1
package configutil
import (
"testing"
"github.com/stretchr/testify/require"
)
// TestNormalizeAddr ensures that strings that match either an IP address or URL
// and contain an IPv6 address conform to RFC-5942 §4
// See: https://rfc-editor.org/rfc/rfc5952.html
func TestNormalizeAddr(t *testing.T) {
t.Parallel()
tests := map[string]struct {
addr string
expected string
isErrorExpected bool
}{
"hostname": {
addr: "https://vaultproject.io:8200",
expected: "https://vaultproject.io:8200",
},
"ipv4": {
addr: "10.10.1.10",
expected: "10.10.1.10",
},
"ipv4 IP:Port addr": {
addr: "10.10.1.10:8500",
expected: "10.10.1.10:8500",
},
"ipv4 URL": {
addr: "https://10.10.1.10:8200",
expected: "https://10.10.1.10:8200",
},
"ipv6 IP:Port addr no brackets": {
addr: "2001:0db8::0001:8500",
expected: "2001:db8::1:8500",
},
"ipv6 IP:Port addr with brackets": {
addr: "[2001:0db8::0001]:8500",
expected: "[2001:db8::1]:8500",
},
"ipv6 RFC-5952 4.1 conformance leading zeroes": {
addr: "2001:0db8::0001",
expected: "2001:db8::1",
},
"ipv6 URL RFC-5952 4.1 conformance leading zeroes": {
addr: "https://[2001:0db8::0001]:8200",
expected: "https://[2001:db8::1]:8200",
},
"ipv6 RFC-5952 4.2.2 conformance one 16-bit 0 field": {
addr: "2001:db8:0:1:1:1:1:1",
expected: "2001:db8:0:1:1:1:1:1",
},
"ipv6 URL RFC-5952 4.2.2 conformance one 16-bit 0 field": {
addr: "https://[2001:db8:0:1:1:1:1:1]:8200",
expected: "https://[2001:db8:0:1:1:1:1:1]:8200",
},
"ipv6 RFC-5952 4.2.3 conformance longest run of 0 bits shortened": {
addr: "2001:0:0:1:0:0:0:1",
expected: "2001:0:0:1::1",
},
"ipv6 URL RFC-5952 4.2.3 conformance longest run of 0 bits shortened": {
addr: "https://[2001:0:0:1:0:0:0:1]:8200",
expected: "https://[2001:0:0:1::1]:8200",
},
"ipv6 RFC-5952 4.2.3 conformance equal runs of 0 bits shortened": {
addr: "2001:db8:0:0:1:0:0:1",
expected: "2001:db8::1:0:0:1",
},
"ipv6 URL RFC-5952 4.2.3 conformance equal runs of 0 bits shortened": {
addr: "https://[2001:db8:0:0:1:0:0:1]:8200",
expected: "https://[2001:db8::1:0:0:1]:8200",
},
"ipv6 RFC-5952 4.3 conformance downcase hex letters": {
addr: "2001:DB8:AC3:FE4::1",
expected: "2001:db8:ac3:fe4::1",
},
"ipv6 URL RFC-5952 4.3 conformance downcase hex letters": {
addr: "https://[2001:DB8:AC3:FE4::1]:8200",
expected: "https://[2001:db8:ac3:fe4::1]:8200",
},
}
for name, tc := range tests {
name := name
tc := tc
t.Run(name, func(t *testing.T) {
t.Parallel()
require.Equal(t, tc.expected, NormalizeAddr(tc.addr))
})
}
}

View File

@ -34,7 +34,7 @@ const (
NumLeaseMetricsTimeBucketsDefault = 168 NumLeaseMetricsTimeBucketsDefault = 168
) )
// Telemetry is the telemetry configuration for the server // Telemetry is the telemetry configuration for the server.
type Telemetry struct { type Telemetry struct {
FoundKeys []string `hcl:",decodedFields"` FoundKeys []string `hcl:",decodedFields"`
UnusedKeys UnusedKeyMap `hcl:",unusedKeyPositions"` UnusedKeys UnusedKeyMap `hcl:",unusedKeyPositions"`
@ -192,6 +192,11 @@ func parseTelemetry(result *SharedConfig, list *ast.ObjectList) error {
return multierror.Prefix(err, "telemetry:") return multierror.Prefix(err, "telemetry:")
} }
// Make sure addresses conform to RFC-5942 §4. If you've added new fields that
// are an address or URL be sure to update normalizeTelemetryAddresses().
// See: https://rfc-editor.org/rfc/rfc5952.html
normalizeTelemetryAddresses(result.Telemetry)
if result.Telemetry.PrometheusRetentionTimeRaw != nil { if result.Telemetry.PrometheusRetentionTimeRaw != nil {
var err error var err error
if result.Telemetry.PrometheusRetentionTime, err = parseutil.ParseDurationSecond(result.Telemetry.PrometheusRetentionTimeRaw); err != nil { if result.Telemetry.PrometheusRetentionTime, err = parseutil.ParseDurationSecond(result.Telemetry.PrometheusRetentionTimeRaw); err != nil {
@ -241,6 +246,33 @@ func parseTelemetry(result *SharedConfig, list *ast.ObjectList) error {
return nil return nil
} }
// normalizeTelemetryAddresses ensures that any telemetry configuration that can
// be a URL, IP Address, or host:port address is conformant with RFC-5942 §4
// See: https://rfc-editor.org/rfc/rfc5952.html
func normalizeTelemetryAddresses(in *Telemetry) {
if in == nil {
return
}
// Make sure addresses conform to RFC-5952
for _, addr := range []*string{
&in.CirconusAPIURL,
&in.CirconusCheckSubmissionURL,
&in.DogStatsDAddr,
&in.StatsdAddr,
&in.StatsiteAddr,
} {
if addr == nil {
continue
}
if url := *addr; url != "" {
n := NormalizeAddr(url)
*addr = n
}
}
}
type SetupTelemetryOpts struct { type SetupTelemetryOpts struct {
Config *Telemetry Config *Telemetry
Ui cli.Ui Ui cli.Ui

View File

@ -7,6 +7,7 @@ import (
"testing" "testing"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
) )
func TestParsePrefixFilters(t *testing.T) { func TestParsePrefixFilters(t *testing.T) {
@ -54,3 +55,47 @@ func TestParsePrefixFilters(t *testing.T) {
} }
}) })
} }
// TestNormalizeTelemetryAddresses ensures that any telemetry configuration that
// can be a URL, IP Address, or host:port address is conformant with RFC-5942 §4
// See: https://rfc-editor.org/rfc/rfc5952.html
func TestNormalizeTelemetryAddresses(t *testing.T) {
t.Parallel()
tests := map[string]struct {
given *Telemetry
expected *Telemetry
}{
"ipv6-conformance": {
given: &Telemetry{
// RFC-5952 4.1 leading zeroes
CirconusAPIURL: "https://[2001:0db8::0001]:443",
// RFC-5952 4.2.3 longest run of 0 bits shortened
CirconusCheckSubmissionURL: "https://[2001:0:0:1:0:0:0:1]:443",
// RFC-5952 4.2.3 equal runs of 0 bits shortened
DogStatsDAddr: "https://[2001:db8:0:0:1:0:0:1]:443",
// RFC-5952 4.3 downcase hex letters
StatsdAddr: "https://[2001:DB8:AC3:FE4::1]:443",
StatsiteAddr: "https://[2001:DB8:AC3:FE4::1]:443",
},
expected: &Telemetry{
CirconusAPIURL: "https://[2001:db8::1]:443",
CirconusCheckSubmissionURL: "https://[2001:0:0:1::1]:443",
DogStatsDAddr: "https://[2001:db8::1:0:0:1]:443",
StatsdAddr: "https://[2001:db8:ac3:fe4::1]:443",
StatsiteAddr: "https://[2001:db8:ac3:fe4::1]:443",
},
},
}
for name, tc := range tests {
name := name
tc := tc
t.Run(name, func(t *testing.T) {
t.Parallel()
normalizeTelemetryAddresses(tc.given)
require.EqualValues(t, tc.expected, tc.given)
})
}
}

View File

@ -18,10 +18,6 @@ import (
memdb "github.com/hashicorp/go-memdb" memdb "github.com/hashicorp/go-memdb"
"github.com/hashicorp/go-secure-stdlib/strutil" "github.com/hashicorp/go-secure-stdlib/strutil"
uuid "github.com/hashicorp/go-uuid" uuid "github.com/hashicorp/go-uuid"
"github.com/stretchr/testify/require"
"google.golang.org/protobuf/types/known/anypb"
"google.golang.org/protobuf/types/known/timestamppb"
"github.com/hashicorp/vault/helper/activationflags" "github.com/hashicorp/vault/helper/activationflags"
"github.com/hashicorp/vault/helper/identity" "github.com/hashicorp/vault/helper/identity"
"github.com/hashicorp/vault/helper/identity/mfa" "github.com/hashicorp/vault/helper/identity/mfa"
@ -29,6 +25,9 @@ import (
"github.com/hashicorp/vault/helper/storagepacker" "github.com/hashicorp/vault/helper/storagepacker"
"github.com/hashicorp/vault/sdk/helper/consts" "github.com/hashicorp/vault/sdk/helper/consts"
"github.com/hashicorp/vault/sdk/logical" "github.com/hashicorp/vault/sdk/logical"
"github.com/stretchr/testify/require"
"google.golang.org/protobuf/types/known/anypb"
"google.golang.org/protobuf/types/known/timestamppb"
) )
var ( var (