mirror of
https://source.denx.de/u-boot/u-boot.git
synced 2025-08-09 16:56:58 +02:00
8b8b35a4f5
An attempt to add the already added LMB region using lmb_add_region_flags() ends up in lmb_addrs_overlap() check, which eventually leads to either returning 0 if 'flags' is LMB_NONE, or -1 otherwise. It makes it impossible for the user of this function to catch the case when the region is already added and differentiate it from regular errors. That in turn may lead to incorrect error handling in the caller code, like reporting misleading errors or interrupting the normal code path where it could be treated as the normal case. An example is boot_fdt_reserve_region() function, which might be called twice (e.g. during board startup in initr_lmb(), and then during 'booti' command booting the OS), thus trying to reserve exactly the same memory regions described in the device tree twice, which produces an error message on second call. Return -EEXIST error code in case when the added region exists and it's not LMB_NONE; for LMB_NONE return 0, to conform to unit tests (specifically test_alloc_addr() in test/lib/lmb.c) and the preferred behavior described in commit |
||
|---|---|---|
| .. | ||
| boot | ||
| cmd | ||
| common | ||
| dm | ||
| env | ||
| fs | ||
| fuzz | ||
| hush | ||
| image | ||
| lib | ||
| log | ||
| optee | ||
| overlay | ||
| py | ||
| stdint | ||
| cmd_ut.c | ||
| Kconfig | ||
| Makefile | ||
| run | ||
| test-main.c | ||
| ut.c | ||