mirror of
				https://source.denx.de/u-boot/u-boot.git
				synced 2025-10-31 08:21:36 +01:00 
			
		
		
		
	The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
		
			
				
	
	
		
			55 lines
		
	
	
		
			1018 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			55 lines
		
	
	
		
			1018 B
		
	
	
	
		
			C
		
	
	
	
	
	
| // SPDX-License-Identifier: GPL-2.0+
 | |
| /*
 | |
|  * Copyright (C) 2007,2008
 | |
|  * Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
 | |
|  */
 | |
| 
 | |
| #include <common.h>
 | |
| #include <ide.h>
 | |
| #include <init.h>
 | |
| #include <net.h>
 | |
| #include <netdev.h>
 | |
| #include <asm/processor.h>
 | |
| #include <asm/io.h>
 | |
| 
 | |
| int checkboard(void)
 | |
| {
 | |
| 	puts("BOARD: Renesas Solutions R2D Plus\n");
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| int board_init(void)
 | |
| {
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| int board_late_init(void)
 | |
| {
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| #define FPGA_BASE		0xA4000000
 | |
| #define FPGA_CFCTL		(FPGA_BASE + 0x04)
 | |
| #define CFCTL_EN		(0x432)
 | |
| #define FPGA_CFPOW		(FPGA_BASE + 0x06)
 | |
| #define CFPOW_ON		(0x02)
 | |
| #define FPGA_CFCDINTCLR	(FPGA_BASE + 0x2A)
 | |
| #define CFCDINTCLR_EN	(0x01)
 | |
| 
 | |
| void ide_set_reset(int idereset)
 | |
| {
 | |
| 	/* if reset = 1 IDE reset will be asserted */
 | |
| 	if (idereset) {
 | |
| 		outw(CFCTL_EN, FPGA_CFCTL);	/* CF enable */
 | |
| 		outw(inw(FPGA_CFPOW)|CFPOW_ON, FPGA_CFPOW); /* Power OM */
 | |
| 		outw(CFCDINTCLR_EN, FPGA_CFCDINTCLR); /* Int clear */
 | |
| 	}
 | |
| }
 | |
| 
 | |
| #ifndef CONFIG_DM_ETH
 | |
| int board_eth_init(struct bd_info *bis)
 | |
| {
 | |
| 	return pci_eth_init(bis);
 | |
| }
 | |
| #endif
 |