mirror of
				https://source.denx.de/u-boot/u-boot.git
				synced 2025-11-03 18:01:41 +01:00 
			
		
		
		
	The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
		
			
				
	
	
		
			240 lines
		
	
	
		
			5.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			240 lines
		
	
	
		
			5.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0+
 | 
						|
/*
 | 
						|
 * Copyright 2009-2010, 2013 Freescale Semiconductor, Inc.
 | 
						|
 *	Jun-jie Zhang <b18070@freescale.com>
 | 
						|
 *	Mingkai Hu <Mingkai.hu@freescale.com>
 | 
						|
 */
 | 
						|
 | 
						|
#include <common.h>
 | 
						|
#include <miiphy.h>
 | 
						|
#include <phy.h>
 | 
						|
#include <fsl_mdio.h>
 | 
						|
#include <asm/io.h>
 | 
						|
#include <linux/errno.h>
 | 
						|
 | 
						|
#ifdef CONFIG_DM_MDIO
 | 
						|
struct tsec_mdio_priv {
 | 
						|
	struct tsec_mii_mng __iomem *regs;
 | 
						|
};
 | 
						|
#endif
 | 
						|
 | 
						|
void tsec_local_mdio_write(struct tsec_mii_mng __iomem *phyregs, int port_addr,
 | 
						|
		int dev_addr, int regnum, int value)
 | 
						|
{
 | 
						|
	int timeout = 1000000;
 | 
						|
 | 
						|
	out_be32(&phyregs->miimadd, (port_addr << 8) | (regnum & 0x1f));
 | 
						|
	out_be32(&phyregs->miimcon, value);
 | 
						|
	/* Memory barrier */
 | 
						|
	mb();
 | 
						|
 | 
						|
	while ((in_be32(&phyregs->miimind) & MIIMIND_BUSY) && timeout--)
 | 
						|
		;
 | 
						|
}
 | 
						|
 | 
						|
int tsec_local_mdio_read(struct tsec_mii_mng __iomem *phyregs, int port_addr,
 | 
						|
		int dev_addr, int regnum)
 | 
						|
{
 | 
						|
	int value;
 | 
						|
	int timeout = 1000000;
 | 
						|
 | 
						|
	/* Put the address of the phy, and the register number into MIIMADD */
 | 
						|
	out_be32(&phyregs->miimadd, (port_addr << 8) | (regnum & 0x1f));
 | 
						|
 | 
						|
	/* Clear the command register, and wait */
 | 
						|
	out_be32(&phyregs->miimcom, 0);
 | 
						|
	/* Memory barrier */
 | 
						|
	mb();
 | 
						|
 | 
						|
	/* Initiate a read command, and wait */
 | 
						|
	out_be32(&phyregs->miimcom, MIIMCOM_READ_CYCLE);
 | 
						|
	/* Memory barrier */
 | 
						|
	mb();
 | 
						|
 | 
						|
	/* Wait for the the indication that the read is done */
 | 
						|
	while ((in_be32(&phyregs->miimind) & (MIIMIND_NOTVALID | MIIMIND_BUSY))
 | 
						|
			&& timeout--)
 | 
						|
		;
 | 
						|
 | 
						|
	/* Grab the value read from the PHY */
 | 
						|
	value = in_be32(&phyregs->miimstat);
 | 
						|
 | 
						|
	return value;
 | 
						|
}
 | 
						|
 | 
						|
#if defined(CONFIG_PHYLIB)
 | 
						|
static int fsl_pq_mdio_reset(struct mii_dev *bus)
 | 
						|
{
 | 
						|
	struct tsec_mii_mng __iomem *regs;
 | 
						|
#ifndef CONFIG_DM_MDIO
 | 
						|
	regs = (struct tsec_mii_mng __iomem *)bus->priv;
 | 
						|
#else
 | 
						|
	struct tsec_mdio_priv *priv;
 | 
						|
 | 
						|
	if (!bus->priv)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	priv = dev_get_priv(bus->priv);
 | 
						|
	regs = priv->regs;
 | 
						|
#endif
 | 
						|
 | 
						|
	/* Reset MII (due to new addresses) */
 | 
						|
	out_be32(®s->miimcfg, MIIMCFG_RESET_MGMT);
 | 
						|
 | 
						|
	out_be32(®s->miimcfg, MIIMCFG_INIT_VALUE);
 | 
						|
 | 
						|
	while (in_be32(®s->miimind) & MIIMIND_BUSY)
 | 
						|
		;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
#endif
 | 
						|
 | 
						|
int tsec_phy_read(struct mii_dev *bus, int addr, int dev_addr, int regnum)
 | 
						|
{
 | 
						|
	struct tsec_mii_mng __iomem *phyregs;
 | 
						|
#ifndef CONFIG_DM_MDIO
 | 
						|
	phyregs = (struct tsec_mii_mng __iomem *)bus->priv;
 | 
						|
#else
 | 
						|
	struct tsec_mdio_priv *priv;
 | 
						|
 | 
						|
	if (!bus->priv)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	priv = dev_get_priv(bus->priv);
 | 
						|
	phyregs = priv->regs;
 | 
						|
#endif
 | 
						|
 | 
						|
	return tsec_local_mdio_read(phyregs, addr, dev_addr, regnum);
 | 
						|
}
 | 
						|
 | 
						|
int tsec_phy_write(struct mii_dev *bus, int addr, int dev_addr, int regnum,
 | 
						|
			u16 value)
 | 
						|
{
 | 
						|
	struct tsec_mii_mng __iomem *phyregs;
 | 
						|
#ifndef CONFIG_DM_MDIO
 | 
						|
	phyregs = (struct tsec_mii_mng __iomem *)bus->priv;
 | 
						|
#else
 | 
						|
	struct tsec_mdio_priv *priv;
 | 
						|
 | 
						|
	if (!bus->priv)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	priv = dev_get_priv(bus->priv);
 | 
						|
	phyregs = priv->regs;
 | 
						|
#endif
 | 
						|
 | 
						|
	tsec_local_mdio_write(phyregs, addr, dev_addr, regnum, value);
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
#ifndef CONFIG_DM_MDIO
 | 
						|
int fsl_pq_mdio_init(struct bd_info *bis, struct fsl_pq_mdio_info *info)
 | 
						|
{
 | 
						|
	struct mii_dev *bus = mdio_alloc();
 | 
						|
 | 
						|
	if (!bus) {
 | 
						|
		printf("Failed to allocate FSL MDIO bus\n");
 | 
						|
		return -1;
 | 
						|
	}
 | 
						|
 | 
						|
	bus->read = tsec_phy_read;
 | 
						|
	bus->write = tsec_phy_write;
 | 
						|
	bus->reset = fsl_pq_mdio_reset;
 | 
						|
	strcpy(bus->name, info->name);
 | 
						|
 | 
						|
	bus->priv = (void *)info->regs;
 | 
						|
 | 
						|
	return mdio_register(bus);
 | 
						|
}
 | 
						|
#else /* CONFIG_DM_MDIO */
 | 
						|
#if defined(CONFIG_PHYLIB)
 | 
						|
static int tsec_mdio_read(struct udevice *dev, int addr, int devad, int reg)
 | 
						|
{
 | 
						|
	struct mdio_perdev_priv *pdata = (dev) ? dev_get_uclass_priv(dev) :
 | 
						|
						 NULL;
 | 
						|
 | 
						|
	if (pdata && pdata->mii_bus)
 | 
						|
		return tsec_phy_read(pdata->mii_bus, addr, devad, reg);
 | 
						|
 | 
						|
	return -1;
 | 
						|
}
 | 
						|
 | 
						|
static int tsec_mdio_write(struct udevice *dev, int addr, int devad, int reg,
 | 
						|
			   u16 val)
 | 
						|
{
 | 
						|
	struct mdio_perdev_priv *pdata = (dev) ? dev_get_uclass_priv(dev) :
 | 
						|
						 NULL;
 | 
						|
 | 
						|
	if (pdata && pdata->mii_bus)
 | 
						|
		return tsec_phy_write(pdata->mii_bus, addr, devad, reg, val);
 | 
						|
 | 
						|
	return -1;
 | 
						|
}
 | 
						|
 | 
						|
static int tsec_mdio_reset(struct udevice *dev)
 | 
						|
{
 | 
						|
	struct mdio_perdev_priv *pdata = (dev) ? dev_get_uclass_priv(dev) :
 | 
						|
						 NULL;
 | 
						|
 | 
						|
	if (pdata && pdata->mii_bus)
 | 
						|
		return fsl_pq_mdio_reset(pdata->mii_bus);
 | 
						|
 | 
						|
	return -1;
 | 
						|
}
 | 
						|
 | 
						|
static const struct mdio_ops tsec_mdio_ops = {
 | 
						|
	.read = tsec_mdio_read,
 | 
						|
	.write = tsec_mdio_write,
 | 
						|
	.reset = tsec_mdio_reset,
 | 
						|
};
 | 
						|
 | 
						|
static const struct udevice_id tsec_mdio_ids[] = {
 | 
						|
	{ .compatible = "fsl,gianfar-tbi" },
 | 
						|
	{ .compatible = "fsl,gianfar-mdio" },
 | 
						|
	{ .compatible = "fsl,etsec2-tbi" },
 | 
						|
	{ .compatible = "fsl,etsec2-mdio" },
 | 
						|
	{ .compatible = "fsl,fman-mdio" },
 | 
						|
	{}
 | 
						|
};
 | 
						|
 | 
						|
static int tsec_mdio_probe(struct udevice *dev)
 | 
						|
{
 | 
						|
	struct tsec_mdio_priv *priv = (dev) ? dev_get_priv(dev) : NULL;
 | 
						|
	struct mdio_perdev_priv *pdata = (dev) ? dev_get_uclass_priv(dev) :
 | 
						|
						 NULL;
 | 
						|
 | 
						|
	if (!dev) {
 | 
						|
		printf("%s dev = NULL\n", __func__);
 | 
						|
		return -1;
 | 
						|
	}
 | 
						|
	if (!priv) {
 | 
						|
		printf("dev_get_priv(dev %p) = NULL\n", dev);
 | 
						|
		return -1;
 | 
						|
	}
 | 
						|
	priv->regs = (void *)(uintptr_t)dev_read_addr(dev);
 | 
						|
	debug("%s priv %p @ regs %p, pdata %p\n", __func__,
 | 
						|
	      priv, priv->regs, pdata);
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int tsec_mdio_remove(struct udevice *dev)
 | 
						|
{
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
U_BOOT_DRIVER(tsec_mdio) = {
 | 
						|
	.name = "tsec_mdio",
 | 
						|
	.id = UCLASS_MDIO,
 | 
						|
	.of_match = tsec_mdio_ids,
 | 
						|
	.probe = tsec_mdio_probe,
 | 
						|
	.remove = tsec_mdio_remove,
 | 
						|
	.ops = &tsec_mdio_ops,
 | 
						|
	.priv_auto_alloc_size = sizeof(struct tsec_mdio_priv),
 | 
						|
	.platdata_auto_alloc_size = sizeof(struct mdio_perdev_priv),
 | 
						|
};
 | 
						|
#endif /* CONFIG_PHYLIB */
 | 
						|
#endif /* CONFIG_DM_MDIO */
 |