mirror of
https://source.denx.de/u-boot/u-boot.git
synced 2025-12-20 17:01:50 +01:00
2dbde3f9b0
SPL recover data section is broken which causes reboot failure on
some i.MX platforms (iMX8QM/iMX95).
The global variable cold_reboot_flag is assigned to weak reset_flag
function which always return 1, so restore never been executed in
warm reboot.
Fixes: 1c37e59bfbba ("arm: armv8: Improve SPL data save and restore implementation")
Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
34 lines
743 B
C
34 lines
743 B
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright 2020 NXP
|
|
*/
|
|
|
|
#include <spl.h>
|
|
|
|
char __data_start[0] __section(".__data_start");
|
|
char __data_save_start[0] __section(".__data_save_start");
|
|
char __data_save_end[0] __section(".__data_save_end");
|
|
|
|
u32 cold_reboot_flag = 1;
|
|
|
|
u32 __weak reset_flag(u32 flag)
|
|
{
|
|
return flag;
|
|
}
|
|
|
|
void spl_save_restore_data(void)
|
|
{
|
|
u32 data_size = __data_save_end - __data_save_start;
|
|
cold_reboot_flag = reset_flag(cold_reboot_flag);
|
|
|
|
if (cold_reboot_flag == 1) {
|
|
/* Save data section to data_save section */
|
|
memcpy(__data_save_start, __data_start, data_size);
|
|
} else {
|
|
/* Restore the data_save section to data section */
|
|
memcpy(__data_start, __data_save_start, data_size);
|
|
}
|
|
|
|
cold_reboot_flag++;
|
|
}
|