Stephen Warren 0e285b503c dfu: fix some issues with reads/uploads
DFU read support appears to rely upon dfu->read_medium() updating the
passed-by-reference len parameter to indicate the remaining size
available for reading.

dfu_read_medium_mmc() never does this, and the implementation of
dfu_read_medium_nand() will only work if called just once; it hard-codes
the value to the total size of the NAND device irrespective of read
offset.

I believe that overloading dfu->read_medium() is confusing. As such,
this patch introduces a new function dfu->get_medium_size() which can
be used to explicitly find out the medium size, and nothing else.
dfu_read() is modified to use this function to set the initial value for
dfu->r_left, rather than attempting to use the side-effects of
dfu->read_medium() for this purpose.

Due to this change, dfu_read() must initially set dfu->b_left to 0, since
no data has been read.

dfu_read_buffer_fill() must also be modified not to adjust dfu->r_left
when simply copying data from dfu->i_buf_start to the upload request
buffer. r_left represents the amount of data left to be read from HW.
That value is not affected by the memcpy(), but only by calls to
dfu->read_medium().

After this change, I can read from either a 4MB or 1.5MB chunk of a 4MB
eMMC boot partion with CONFIG_SYS_DFU_DATA_BUF_SIZE==1MB. Without this
change, attempting to do that would result in DFU read returning no data
at all due to r_left never being set.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
2014-08-09 11:16:58 -04:00
..
2014-07-30 08:48:03 -04:00
2014-07-22 07:44:27 -04:00
2014-07-18 19:42:16 +01:00
2014-07-18 19:42:10 +01:00
2014-05-29 17:45:31 -04:00
2014-02-04 16:32:20 +01:00
2014-07-07 19:43:02 -04:00
2014-02-21 08:42:47 -05:00
2014-03-17 20:05:48 -06:00
2014-08-09 11:16:58 -04:00
2014-05-27 10:21:32 -04:00
2014-06-21 10:06:58 -06:00
2014-05-16 14:54:26 +09:00
2014-08-09 11:16:57 -04:00
2014-08-09 11:16:57 -04:00
2014-08-09 11:16:57 -04:00
2014-07-07 19:47:18 -04:00
2014-06-19 11:18:55 -04:00
2014-02-20 06:48:23 +01:00
2013-09-24 09:10:33 -04:00
2014-07-07 19:47:19 -04:00
2014-05-28 10:58:19 +09:00
2014-06-20 11:54:29 -06:00
2014-07-07 19:43:02 -04:00
2013-09-20 10:30:54 -04:00
2014-07-18 17:53:24 -04:00
2014-05-30 14:03:24 -04:00
2013-11-09 17:21:01 +01:00
2014-08-01 18:44:56 +03:00
2014-03-17 20:05:49 -06:00
2013-11-09 17:21:01 +01:00
2014-07-07 19:43:02 -04:00
2014-08-06 09:12:30 -04:00
2014-02-19 10:47:43 -05:00
2014-06-11 16:27:06 -04:00
2013-12-04 08:11:28 -05:00