u-boot/cmd/test.c
Rasmus Villemoes f7e7c55e53 cmd: test: add bug-compatibility special case for 'test -n'
It turns out that there is lots of code in the wild, including in the
U-Boot tree itself, which used to rely on

  test -n $somevar

to yield false when $somevar is not defined or empty. See for example
all the occurrences of 'test -n $fdtfile'. That was really only a
quirk of the implementation that refused calls with argc < 3, and not
because it was interpreted as

  test -n "$somevar"

which is how this should be spelled.

While not exactly conforming to POSIX, we can accomodate such scripts
by special-casing a single argument "-n" to be interpreted as if it
comes from code as above with empty $somevar.

Since we only just added the ability to test a string for emptiness
using the single-argument form, it is very unlikely that there is code
doing

  test "$str"

which would now fail if $str happens to be exactly "-n"; such a test
should really always be spelled

  test -n "$str"

Fixes: 8b0619579b2 ("cmd: test: fix handling of single-argument form of test")
Reported-by: Franz Schnyder <franz.schnyder@toradex.com>
Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>
Reviewed-by: Simon Glass <sjg@chromium.org>
2026-04-02 16:00:29 -06:00

277 lines
5.6 KiB
C

// SPDX-License-Identifier: GPL-2.0+
/*
* Copyright 2000-2009
* Wolfgang Denk, DENX Software Engineering, wd@denx.de.
*/
#include <command.h>
#include <fs.h>
#include <log.h>
#include <slre.h>
#include <vsprintf.h>
#include <linux/string.h>
#define OP_INVALID 0
#define OP_NOT 1
#define OP_OR 2
#define OP_AND 3
#define OP_STR_EMPTY 4
#define OP_STR_NEMPTY 5
#define OP_STR_EQ 6
#define OP_STR_NEQ 7
#define OP_STR_LT 8
#define OP_STR_GT 9
#define OP_INT_EQ 10
#define OP_INT_NEQ 11
#define OP_INT_LT 12
#define OP_INT_LE 13
#define OP_INT_GT 14
#define OP_INT_GE 15
#define OP_FILE_EXISTS 16
#define OP_REGEX 17
const struct {
int arg;
const char *str;
int op;
int adv;
} op_adv[] = {
{1, "=", OP_STR_EQ, 3},
{1, "!=", OP_STR_NEQ, 3},
{1, "<", OP_STR_LT, 3},
{1, ">", OP_STR_GT, 3},
{1, "-eq", OP_INT_EQ, 3},
{1, "-ne", OP_INT_NEQ, 3},
{1, "-lt", OP_INT_LT, 3},
{1, "-le", OP_INT_LE, 3},
{1, "-gt", OP_INT_GT, 3},
{1, "-ge", OP_INT_GE, 3},
{0, "!", OP_NOT, 1},
{0, "-o", OP_OR, 1},
{0, "-a", OP_AND, 1},
{0, "-z", OP_STR_EMPTY, 2},
{0, "-n", OP_STR_NEMPTY, 2},
{0, "-e", OP_FILE_EXISTS, 4},
#ifdef CONFIG_REGEX
{1, "=~", OP_REGEX, 3},
#endif
};
static int do_test(struct cmd_tbl *cmdtp, int flag, int argc,
char *const argv[])
{
char * const *ap;
int i, op, left, adv, expr, last_expr, last_unop, last_binop;
if (!strcmp(argv[0], "[")) {
if (strcmp(argv[argc - 1], "]")) {
printf("[: missing terminating ]\n");
return 1;
}
argc--;
}
/*
* Per POSIX, 'test' with 0 arguments should return 1, while
* 'test <arg>' should be equivalent to 'test -n <arg>',
* i.e. true if and only if <arg> is not empty.
*
* However, due to previous versions of U-Boot unconditionally
* returning false when 'test' was given less than two
* arguments, there are existing scripts that do
*
* test -n $somevar
*
* (i.e. without properly quoting $somevar) and expecting that
* to return false when $somevar expands to nothing. It is
* quite unlikely that anyone would use the single-argument
* form to test a string for being empty and a possible
* non-empty value for that string to be exactly "-n". So we
* interpret 'test -n' as if it was 'test -n ""'.
*/
if (argc < 2)
return 1;
if (argc == 2)
return !strcmp(argv[1], "") || !strcmp(argv[1], "-n");
#ifdef DEBUG
{
debug("test(%d):", argc);
left = 1;
while (argv[left])
debug(" '%s'", argv[left++]);
}
#endif
left = argc - 1;
ap = argv + 1;
expr = 0;
last_unop = OP_INVALID;
last_binop = OP_INVALID;
last_expr = -1;
while (left > 0) {
for (i = 0; i < ARRAY_SIZE(op_adv); i++) {
if (left <= op_adv[i].arg)
continue;
if (!strcmp(ap[op_adv[i].arg], op_adv[i].str)) {
op = op_adv[i].op;
adv = op_adv[i].adv;
break;
}
}
if (i == ARRAY_SIZE(op_adv)) {
expr = 1;
break;
}
if (left < adv) {
expr = 1;
break;
}
switch (op) {
case OP_STR_EMPTY:
expr = strlen(ap[1]) == 0 ? 1 : 0;
break;
case OP_STR_NEMPTY:
expr = strlen(ap[1]) == 0 ? 0 : 1;
break;
case OP_STR_EQ:
expr = strcmp(ap[0], ap[2]) == 0;
break;
case OP_STR_NEQ:
expr = strcmp(ap[0], ap[2]) != 0;
break;
case OP_STR_LT:
expr = strcmp(ap[0], ap[2]) < 0;
break;
case OP_STR_GT:
expr = strcmp(ap[0], ap[2]) > 0;
break;
case OP_INT_EQ:
expr = simple_strtol(ap[0], NULL, 0) ==
simple_strtol(ap[2], NULL, 0);
break;
case OP_INT_NEQ:
expr = simple_strtol(ap[0], NULL, 0) !=
simple_strtol(ap[2], NULL, 0);
break;
case OP_INT_LT:
expr = simple_strtol(ap[0], NULL, 0) <
simple_strtol(ap[2], NULL, 0);
break;
case OP_INT_LE:
expr = simple_strtol(ap[0], NULL, 0) <=
simple_strtol(ap[2], NULL, 0);
break;
case OP_INT_GT:
expr = simple_strtol(ap[0], NULL, 0) >
simple_strtol(ap[2], NULL, 0);
break;
case OP_INT_GE:
expr = simple_strtol(ap[0], NULL, 0) >=
simple_strtol(ap[2], NULL, 0);
break;
case OP_FILE_EXISTS:
expr = file_exists(ap[1], ap[2], ap[3], FS_TYPE_ANY);
break;
#ifdef CONFIG_REGEX
case OP_REGEX: {
struct slre slre;
if (slre_compile(&slre, ap[2]) == 0) {
printf("Error compiling regex: %s\n", slre.err_str);
expr = 0;
break;
}
expr = slre_match(&slre, ap[0], strlen(ap[0]), NULL);
break;
}
#endif
}
switch (op) {
case OP_OR:
last_expr = expr;
last_binop = OP_OR;
break;
case OP_AND:
last_expr = expr;
last_binop = OP_AND;
break;
case OP_NOT:
if (last_unop == OP_NOT)
last_unop = OP_INVALID;
else
last_unop = OP_NOT;
break;
default:
if (last_unop == OP_NOT) {
expr = !expr;
last_unop = OP_INVALID;
}
if (last_binop == OP_OR)
expr = last_expr || expr;
else if (last_binop == OP_AND)
expr = last_expr && expr;
last_binop = OP_INVALID;
break;
}
ap += adv; left -= adv;
}
expr = !expr;
debug (": returns %d\n", expr);
return expr;
}
#undef true
#undef false
U_BOOT_CMD(
test, CONFIG_SYS_MAXARGS, 1, do_test,
"minimal test like /bin/sh",
"[args..]"
);
/*
* This does not use the U_BOOT_CMD macro as [ can't be used in symbol names
*/
ll_entry_declare(struct cmd_tbl, lbracket, cmd) = {
"[", CONFIG_SYS_MAXARGS, cmd_always_repeatable, do_test,
"alias for 'test'",
#ifdef CONFIG_SYS_LONGHELP
" <test expression> ]"
#endif /* CONFIG_SYS_LONGHELP */
};
static int do_false(struct cmd_tbl *cmdtp, int flag, int argc,
char *const argv[])
{
return 1;
}
U_BOOT_CMD(
false, CONFIG_SYS_MAXARGS, 1, do_false,
"do nothing, unsuccessfully",
NULL
);
static int do_true(struct cmd_tbl *cmdtp, int flag, int argc,
char *const argv[])
{
return 0;
}
U_BOOT_CMD(
true, CONFIG_SYS_MAXARGS, 1, do_true,
"do nothing, successfully",
NULL
);