mirror of
https://source.denx.de/u-boot/u-boot.git
synced 2026-05-05 12:46:14 +02:00
8019e3b35d
The virtio-rng test to verify effective handling of oversized return buffers checks that an (undocumented) error is raised, instead of the real concern, which is the surrounding buffer integrity following a rng function call. Update the test to check that the other contents of a buffer remain unchanged instead of looking for an error code. Signed-off-by: Kavin Gunasekara <kavin.gunasekara@arm.com> Signed-off-by: Meet Patel <meet.patel2@arm.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
62 lines
1.7 KiB
C
62 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (c) 2022 Google, Inc.
|
|
* Written by Andrew Scull <ascull@google.com>
|
|
*/
|
|
|
|
#include <dm.h>
|
|
#include <virtio_types.h>
|
|
#include <virtio.h>
|
|
#include <virtio_ring.h>
|
|
#include <dm/device-internal.h>
|
|
#include <dm/test.h>
|
|
#include <rng.h>
|
|
#include <test/test.h>
|
|
#include <test/ut.h>
|
|
|
|
/* This is a brittle means of getting access to the virtqueue */
|
|
struct virtio_rng_priv {
|
|
struct virtqueue *rng_vq;
|
|
};
|
|
|
|
#define BUFFER_SIZE 16
|
|
#define CANARY "CANARYCANARYCANARYCANARY"
|
|
|
|
/* Test the virtio-rng driver validates the used size */
|
|
static int dm_test_virtio_rng_check_len(struct unit_test_state *uts)
|
|
{
|
|
struct udevice *bus, *dev;
|
|
struct virtio_rng_priv *priv;
|
|
u8 buffer[BUFFER_SIZE + sizeof(CANARY)];
|
|
|
|
/* write known data to buffer */
|
|
memset(buffer, 0xaa, BUFFER_SIZE);
|
|
memcpy(buffer + BUFFER_SIZE, CANARY, sizeof(CANARY));
|
|
|
|
/* check probe success */
|
|
ut_assertok(uclass_first_device_err(UCLASS_VIRTIO, &bus));
|
|
ut_assertnonnull(bus);
|
|
|
|
/* check the child virtio-rng device is bound */
|
|
ut_assertok(device_find_first_child(bus, &dev));
|
|
ut_assertnonnull(dev);
|
|
|
|
/* probe the virtio-rng driver */
|
|
ut_assertok(device_probe(dev));
|
|
|
|
/* simulate the device returning the buffer with too much data */
|
|
priv = dev_get_priv(dev);
|
|
priv->rng_vq->vring.used->idx = 1;
|
|
priv->rng_vq->vring.used->ring[0].id = 0;
|
|
priv->rng_vq->vring.used->ring[0].len = U32_MAX;
|
|
|
|
/* check the driver gracefully handles the error */
|
|
dm_rng_read(dev, buffer, BUFFER_SIZE);
|
|
|
|
/* check for the canary bytes behind the real buffer */
|
|
ut_asserteq_mem(buffer + BUFFER_SIZE, CANARY, sizeof(CANARY));
|
|
|
|
return 0;
|
|
}
|
|
DM_TEST(dm_test_virtio_rng_check_len, UTF_SCAN_PDATA | UTF_SCAN_FDT);
|