mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2025-12-24 10:52:13 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

mtd: rawnand: cortina_nand: Fix -ENOMEM detection

Browse Source 
In init_nand_dma there was code to detect failure to allocate memory but
it had two problems. Firstly the 2nd clause when info->tx_desc was NULL
attempted to free info->tx_desc when it should be freeing info->rx_desc.
Secondly there was no detection of both allocations failing, arguably
the more likely scenario. Refactor the code to simplify it and just fail
as soon as either allocation fails.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
This commit is contained in:
Andrew Goodbody 2025-08-01 10:54:04 +01:00 committed by Michael Trimarchi
parent 56372f834c
commit ebf8aaf7af
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/mtd/nand/raw/cortina_nand.c
View File

@ -186,14 +186,13 @@ int init_nand_dma(struct nand_chip *nand)
info->tx_desc = malloc_cache_aligned((sizeof(struct tx_descriptor_t) *
CA_DMA_DESC_NUM));
if (!info->tx_desc) {
printf("Fail to alloc DMA descript!\n");
return -ENOMEM;
}
info->rx_desc = malloc_cache_aligned((sizeof(struct rx_descriptor_t) *
CA_DMA_DESC_NUM));
if (!info->rx_desc && info->tx_desc) {
printf("Fail to alloc DMA descript!\n");
kfree(info->tx_desc);
return -ENOMEM;
} else if (info->rx_desc && !info->tx_desc) {
if (!info->rx_desc) {
printf("Fail to alloc DMA descript!\n");
kfree(info->tx_desc);
return -ENOMEM;