mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2025-12-06 18:11:47 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

tools: moveconfig: fix --dry-run option

Browse Source 
Since commit 96464badc794 ("moveconfig: Always run savedefconfig on
the moved config"), --dry-run option is broken.

The --dry-run option prevents the .config from being modified,
but defconfig files might be updated by "make savedefconfig"
regardless of the --dry-run option.

Move the "if not self.options.dry_run" conditional to the correct
place.

Fixes 96464badc794 ("moveconfig: Always run savedefconfig on the moved config")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
This commit is contained in:
Masahiro Yamada 2016-05-19 15:51:49 +09:00
parent 6b3943f1b0
commit e423d17fcc
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/moveconfig.py
View File

@ -511,7 +511,6 @@ class KconfigParser:
# Print log in one shot to not mix up logs from different threads. # Print log in one shot to not mix up logs from different threads.
print log, print log,
if not self.options.dry_run:
with open(dotconfig_path, 'a') as f: with open(dotconfig_path, 'a') as f:
for (action, value) in results: for (action, value) in results:
if action == ACTION_MOVE: if action == ACTION_MOVE:
@ -647,8 +646,8 @@ class Slot:
return False return False
if self.state == STATE_SAVEDEFCONFIG: if self.state == STATE_SAVEDEFCONFIG:
defconfig_path = os.path.join(self.build_dir, 'defconfig') if not self.options.dry_run:
shutil.move(defconfig_path, shutil.move(os.path.join(self.build_dir, 'defconfig'),
os.path.join('configs', self.defconfig)) os.path.join('configs', self.defconfig))
self.state = STATE_IDLE self.state = STATE_IDLE
return True return True