mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2025-12-19 16:31:27 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

pinctrl: qcom: sdm845: Limit check off by 1

Browse Source 
The driver specifies 154 pins so should have a maximum selector of 153
to ensure that the index into the array special_pins_names does not
overflow.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Link: https://lore.kernel.org/r/20250807-pinctrl_qcom-v1-2-42fac6707fd5@linaro.org
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
This commit is contained in:
Andrew Goodbody 2025-08-07 12:20:02 +01:00 committed by Casey Connolly
parent be12b6e158
commit d9fbc1d70b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/pinctrl/qcom/pinctrl-sdm845.c
View File

@ -72,7 +72,7 @@ static const char *sdm845_get_pin_name(struct udevice *dev,
"sdc2_data", "sdc2_data",
}; };
if (selector >= 150 && selector <= 154) if (selector >= 150 && selector <= 153)
snprintf(pin_name, MAX_PIN_NAME_LEN, special_pins_names[selector - 150]); snprintf(pin_name, MAX_PIN_NAME_LEN, special_pins_names[selector - 150]);
else else
snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector); snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector);