mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2026-05-05 04:36:13 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

clk: cdce9xx: Fix use of dev_read_u32_default

Browse Source 
The function dev_read_u32_default does not return an error and the
variable 'val' is unsigned so testing for >= 0 will always be true. It
looks like the code was attempting to return -1 if xtal-load-pf was not
present but that cannot work. Instead use dev_read_u32 which returns an
error code separately from writing the value into the passed pointer.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Fixes: 260777fc2333 ("clk: cdce9xx: add support for cdce9xx clock  synthesizer")
Acked-by: Quentin Schulz <quentin.schulz@cherry.de>
This commit is contained in:
Andrew Goodbody 2025-07-25 11:41:12 +01:00 committed by Tom Rini
parent 493c3da3ac
commit bd644d9613
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/clk/clk-cdce9xx.c
View File

@ -116,8 +116,7 @@ static int cdce9xx_clk_probe(struct udevice *dev)
ret = clk_get_by_index(dev, 0, &clk);
data->xtal_rate = clk_get_rate(&clk);
val = dev_read_u32_default(dev, "xtal-load-pf", -1);
if (val >= 0)
if (!dev_read_u32(dev, "xtal-load-pf", &val))
cdce9xx_reg_write(dev, CDCE9XX_REG_XCSEL, val << 3);
return 0;