mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2026-05-05 04:36:13 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

dm: core: use u32 instead of int for dev_read_u32_default

Browse Source 
dev_read_u32_default is for getting a u32 from a Device Tree property
and allows to take a default value if that property is missing.

Considering it calls ofnode_read_u32_default which takes a u32 and
returns a u32, it should do the same instead of using an int, especially
considering that int size is typically architecture-specific, as opposed
to u32.

This incidentally matches all other dev_read_*_default functions (except
dev_read_s32_default which will be tackled in the next commit).

Fixes: 47a0fd3bad38 ("dm: core: Implement live tree 'read' functions")
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Quentin Schulz 2025-05-28 15:06:18 +02:00 committed by Tom Rini
parent e04d137231
commit b4b66e2f29
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/core/read.c
View File

@ -38,8 +38,8 @@ int dev_read_u32(const struct udevice *dev, const char *propname, u32 *outp)
return ofnode_read_u32(dev_ofnode(dev), propname, outp);
}
int dev_read_u32_default(const struct udevice *dev, const char *propname,
int def)
u32 dev_read_u32_default(const struct udevice *dev, const char *propname,
u32 def)
{
return ofnode_read_u32_default(dev_ofnode(dev), propname, def);
}

6
include/dm/read.h
View File

@ -90,8 +90,8 @@ int dev_read_u32(const struct udevice *dev, const char *propname, u32 *outp);
* @def: default value to return if the property has no value
* Return: property value, or @def if not found
*/
int dev_read_u32_default(const struct udevice *dev, const char *propname,
int def);
u32 dev_read_u32_default(const struct udevice *dev, const char *propname,
u32 def);
/**
* dev_read_u32_index() - read an indexed 32-bit integer from a device's DT
@ -896,7 +896,7 @@ static inline int dev_read_u32(const struct udevice *dev,
}
static inline int dev_read_u32_default(const struct udevice *dev,
const char *propname, int def)
const char *propname, u32 def)
{
return ofnode_read_u32_default(dev_ofnode(dev), propname, def);
}