patman: Pass aliases to Series.MakeCcFile()

Rather than accessing settings directly, pass the aliases in, so that
we can do the same from tests. With further work this will allow the
tests to work without using settings.alias

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass 2025-04-07 22:51:46 +12:00
parent e10201aa8c
commit abfd67cccf
3 changed files with 13 additions and 5 deletions

View File

@ -253,7 +253,7 @@ class TestFunctional(unittest.TestCase):
series.DoChecks() series.DoChecks()
cc_file = series.MakeCcFile(process_tags, cover_fname, cc_file = series.MakeCcFile(process_tags, cover_fname,
not ignore_bad_tags, add_maintainers, not ignore_bad_tags, add_maintainers,
None, get_maintainer_script) None, get_maintainer_script, alias)
cmd = gitutil.email_patches( cmd = gitutil.email_patches(
series, cover_fname, args, dry_run, not ignore_bad_tags, series, cover_fname, args, dry_run, not ignore_bad_tags,
cc_file, alias, in_reply_to=in_reply_to, thread=None) cc_file, alias, in_reply_to=in_reply_to, thread=None)

View File

@ -87,7 +87,8 @@ def email_patches(col, series, cover_fname, patch_files, process_tags, its_a_go,
smtp_server (str): SMTP server to use to send patches (None for default) smtp_server (str): SMTP server to use to send patches (None for default)
""" """
cc_file = series.MakeCcFile(process_tags, cover_fname, not ignore_bad_tags, cc_file = series.MakeCcFile(process_tags, cover_fname, not ignore_bad_tags,
add_maintainers, limit, get_maintainer_script) add_maintainers, limit, get_maintainer_script,
settings.alias)
# Email the patches out (giving the user time to check / cancel) # Email the patches out (giving the user time to check / cancel)
cmd = '' cmd = ''

View File

@ -242,7 +242,7 @@ class Series(dict):
def GetCcForCommit(self, commit, process_tags, warn_on_error, def GetCcForCommit(self, commit, process_tags, warn_on_error,
add_maintainers, limit, get_maintainer_script, add_maintainers, limit, get_maintainer_script,
all_skips): all_skips, alias):
"""Get the email CCs to use with a particular commit """Get the email CCs to use with a particular commit
Uses subject tags and get_maintainers.pl script to find people to cc Uses subject tags and get_maintainers.pl script to find people to cc
@ -262,6 +262,9 @@ class Series(dict):
all_skips (set of str): Updated to include the set of bouncing email all_skips (set of str): Updated to include the set of bouncing email
addresses that were dropped from the output. This is essentially addresses that were dropped from the output. This is essentially
a return value from this function. a return value from this function.
alias (dict): Alias dictionary
key: alias
value: list of aliases or email addresses
Returns: Returns:
list of str: List of email addresses to cc list of str: List of email addresses to cc
@ -284,7 +287,7 @@ class Series(dict):
return cc return cc
def MakeCcFile(self, process_tags, cover_fname, warn_on_error, def MakeCcFile(self, process_tags, cover_fname, warn_on_error,
add_maintainers, limit, get_maintainer_script): add_maintainers, limit, get_maintainer_script, alias):
"""Make a cc file for us to use for per-commit Cc automation """Make a cc file for us to use for per-commit Cc automation
Also stores in self._generated_cc to make ShowActions() faster. Also stores in self._generated_cc to make ShowActions() faster.
@ -300,6 +303,9 @@ class Series(dict):
limit (int): Limit the length of the Cc list (None if no limit) limit (int): Limit the length of the Cc list (None if no limit)
get_maintainer_script (str): The file name of the get_maintainer.pl get_maintainer_script (str): The file name of the get_maintainer.pl
script (or compatible). script (or compatible).
alias (dict): Alias dictionary
key: alias
value: list of aliases or email addresses
Return: Return:
Filename of temp file created Filename of temp file created
""" """
@ -314,7 +320,8 @@ class Series(dict):
commit.seq = i commit.seq = i
commit.future = executor.submit( commit.future = executor.submit(
self.GetCcForCommit, commit, process_tags, warn_on_error, self.GetCcForCommit, commit, process_tags, warn_on_error,
add_maintainers, limit, get_maintainer_script, all_skips) add_maintainers, limit, get_maintainer_script, all_skips,
alias)
# Show progress any commits that are taking forever # Show progress any commits that are taking forever
lastlen = 0 lastlen = 0