mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2025-12-23 18:32:07 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

power: power_i2c: ret is uninitialised if not DM_I2C

Browse Source 
In pmic_reg_read ret is only assigned to inside #if
CONFIG_IS_ENABLED(DM_I2C) so move the test and return ret inside as well
and also guard the declaration of ret with CONFIG_IS_ENABLED(DM_I2C) to
prevent a warning about an unused variable.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
This commit is contained in:
Andrew Goodbody 2025-08-07 15:28:58 +01:00 committed by Tom Rini
parent 446b7b8f2d
commit aa136393c8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/power/power_i2c.c
View File

@ -75,7 +75,7 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val)
{ {
unsigned char buf[4] = { 0 }; unsigned char buf[4] = { 0 };
u32 ret_val = 0; u32 ret_val = 0;
int ret; int __maybe_unused ret;
if (check_reg(p, reg)) if (check_reg(p, reg))
return -EINVAL; return -EINVAL;
@ -91,9 +91,9 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val)
return -ENXIO; return -ENXIO;
} }
ret = dm_i2c_read(dev, reg, buf, pmic_i2c_tx_num); ret = dm_i2c_read(dev, reg, buf, pmic_i2c_tx_num);
#endif
if (ret) if (ret)
return ret; return ret;
#endif
switch (pmic_i2c_tx_num) { switch (pmic_i2c_tx_num) {
case 3: case 3: