mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2026-05-08 14:16:12 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

mtd: nand: Prevent dereference of NULL pointer

Browse Source 
In nand_wait_ready there is a loop that includes a NULL check for
chip->dev_ready before it is dereferenced. Use a NULL check once the
loop is exited as well to cover the case where it exits due to a timeout
and it is therefore not known if chip->dev_ready is NULL or not.

This issue found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
This commit is contained in:
Andrew Goodbody 2025-07-01 17:12:44 +01:00 committed by Tom Rini
parent ce1bdedd2f
commit a5c83da3cc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/mtd/nand/raw/nand_base.c
View File

@ -566,7 +566,7 @@ void nand_wait_ready(struct mtd_info *mtd)
break;
}
if (!chip->dev_ready(mtd))
if (!chip->dev_ready || !chip->dev_ready(mtd))
pr_warn("timeout while waiting for chip to become ready\n");
}
EXPORT_SYMBOL_GPL(nand_wait_ready);