mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2025-11-29 14:41:26 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

x86: broadwell: Improve SDRAM debugging output

Browse Source 
Add debugging during SDRAM init so that problems are easier to
diagnose.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
This commit is contained in:
Simon Glass 2019-04-25 21:58:48 -06:00 committed by Bin Meng
parent 62be5dd885
commit 9f6486bff4
1 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
arch/x86/cpu/broadwell/sdram.c
View File

@ -204,16 +204,18 @@ int dram_init(void)
/* Print ME state before MRC */ /* Print ME state before MRC */
ret = syscon_get_by_driver_data(X86_SYSCON_ME, &me_dev); ret = syscon_get_by_driver_data(X86_SYSCON_ME, &me_dev);
if (ret) if (ret) {
debug("Cannot get ME (err=%d)\n", ret);
return ret; return ret;
}
intel_me_status(me_dev); intel_me_status(me_dev);
/* Save ME HSIO version */ /* Save ME HSIO version */
ret = uclass_first_device(UCLASS_PCH, &pch_dev); ret = uclass_first_device_err(UCLASS_PCH, &pch_dev);
if (ret) if (ret) {
debug("Cannot get PCH (err=%d)\n", ret);
return ret; return ret;
if (!pch_dev) }
return -ENODEV;
power_state_get(pch_dev, &ps); power_state_get(pch_dev, &ps);
intel_me_hsio_version(me_dev, &ps.hsio_version, &ps.hsio_checksum); intel_me_hsio_version(me_dev, &ps.hsio_version, &ps.hsio_checksum);
@ -221,15 +223,17 @@ int dram_init(void)
broadwell_fill_pei_data(pei_data); broadwell_fill_pei_data(pei_data);
mainboard_fill_pei_data(pei_data); mainboard_fill_pei_data(pei_data);
ret = uclass_first_device(UCLASS_NORTHBRIDGE, &dev); ret = uclass_first_device_err(UCLASS_NORTHBRIDGE, &dev);
if (ret) if (ret) {
debug("Cannot get Northbridge (err=%d)\n", ret);
return ret; return ret;
if (!dev) }
return -ENODEV;
size = 256; size = 256;
ret = mrc_locate_spd(dev, size, &spd_data); ret = mrc_locate_spd(dev, size, &spd_data);
if (ret) if (ret) {
debug("Cannot locate SPD (err=%d)\n", ret);
return ret; return ret;
}
memcpy(pei_data->spd_data[0][0], spd_data, size); memcpy(pei_data->spd_data[0][0], spd_data, size);
memcpy(pei_data->spd_data[1][0], spd_data, size); memcpy(pei_data->spd_data[1][0], spd_data, size);
@ -239,13 +243,17 @@ int dram_init(void)
debug("PEI version %#x\n", pei_data->pei_version); debug("PEI version %#x\n", pei_data->pei_version);
ret = mrc_common_init(dev, pei_data, true); ret = mrc_common_init(dev, pei_data, true);
if (ret) if (ret) {
debug("mrc_common_init() failed(err=%d)\n", ret);
return ret; return ret;
}
debug("Memory init done\n"); debug("Memory init done\n");
ret = sdram_find(dev); ret = sdram_find(dev);
if (ret) if (ret) {
debug("sdram_find() failed (err=%d)\n", ret);
return ret; return ret;
}
gd->ram_size = gd->arch.meminfo.total_32bit_memory; gd->ram_size = gd->arch.meminfo.total_32bit_memory;
debug("RAM size %llx\n", (unsigned long long)gd->ram_size); debug("RAM size %llx\n", (unsigned long long)gd->ram_size);