mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2025-08-13 18:56:59 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

x86: Remove x86 specific GD flags as they are not referenced at all

Browse Source 
This patch removes the x86 architecture specific GD flags
(GD_FLG_COLD_BOOT & GD_FLG_WARM_BOOT), as they are not used. Only
GD_FLG_COLD_BOOT is referenced in coreboot.c but assigned in start16.S.
But the coreboot target does not use start16.S at all and boots directly
from the 32-bit start code.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
This commit is contained in:
Stefan Roese 2019-08-16 14:45:28 +02:00 committed by Bin Meng
parent ad79d603aa
commit 8ad01ce36f
4 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
arch/x86/cpu/coreboot/coreboot.c
View File

@ -73,9 +73,6 @@ static void board_final_cleanup(void)
int last_stage_init(void) int last_stage_init(void)
{ {
if (gd->flags & GD_FLG_COLD_BOOT)
timestamp_add_to_bootstage();
/* start usb so that usb keyboard can be used as input device */ /* start usb so that usb keyboard can be used as input device */
if (CONFIG_IS_ENABLED(USB_KEYBOARD)) if (CONFIG_IS_ENABLED(USB_KEYBOARD))
usb_init(); usb_init();

9
arch/x86/cpu/start.S
View File

@ -40,9 +40,6 @@ _x86boot_start:
movl %eax, %cr0 movl %eax, %cr0
wbinvd wbinvd
/* Tell 32-bit code it is being entered from an in-RAM copy */
movl $GD_FLG_WARM_BOOT, %ebx
/* /*
* Zero the BIST (Built-In Self Test) value since we don't have it. * Zero the BIST (Built-In Self Test) value since we don't have it.
* It must be 0 or the previous loader would have reported an error. * It must be 0 or the previous loader would have reported an error.
@ -55,11 +52,7 @@ _x86boot_start:
.align 4 .align 4
.long 0x12345678 .long 0x12345678
_start: _start:
/* /* This is the 32-bit cold-reset entry point, coming from start16 */
* This is the 32-bit cold-reset entry point, coming from start16.
* Set %ebx to GD_FLG_COLD_BOOT to indicate this.
*/
movl $GD_FLG_COLD_BOOT, %ebx
/* Save BIST */ /* Save BIST */
movl %eax, %ebp movl %eax, %ebp

3
arch/x86/cpu/start16.S
View File

@ -23,9 +23,6 @@ start16:
/* Save BIST */ /* Save BIST */
movl %eax, %ecx movl %eax, %ecx
/* Set the Cold Boot / Hard Reset flag */
movl $GD_FLG_COLD_BOOT, %ebx
xorl %eax, %eax xorl %eax, %eax
movl %eax, %cr3 /* Invalidate TLB */ movl %eax, %cr3 /* Invalidate TLB */

6
arch/x86/include/asm/global_data.h
View File

@ -137,10 +137,4 @@ static inline __attribute__((no_instrument_function)) gd_t *get_fs_gd_ptr(void)
#endif #endif
/*
* Our private Global Data Flags
*/
#define GD_FLG_COLD_BOOT 0x10000 /* Cold Boot */
#define GD_FLG_WARM_BOOT 0x20000 /* Warm Boot */
#endif /* __ASM_GBL_DATA_H */ #endif /* __ASM_GBL_DATA_H */