mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2025-12-18 16:01:32 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

cmd: mtd: benchmark: use lldiv() instead of 64-bit division

Browse Source 
As was noted by Heinrich Schuchardt, some SoCs may not support 64-bit
divisions. Fix an issue by using lldiv() instead.

The code assumes that the benchmark never takes more than 4294 seconds
and thus the difference will be less than U32_MAX.

Also replace (speed / 1024) by (speed >> 10) to avoid potential 64-bit
division.

Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
This commit is contained in:
Mikhail Kshevetskiy 2025-11-01 09:24:23 +03:00 committed by Michael Trimarchi
parent 75153d92a5
commit 5572d94100
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/mtd.c
View File

@ -10,6 +10,7 @@
#include <command.h> #include <command.h>
#include <console.h> #include <console.h>
#include <div64.h>
#include <led.h> #include <led.h>
#if CONFIG_IS_ENABLED(CMD_MTD_OTP) #if CONFIG_IS_ENABLED(CMD_MTD_OTP)
#include <hexdump.h> #include <hexdump.h>
@ -595,10 +596,10 @@ static int do_mtd_io(struct cmd_tbl *cmdtp, int flag, int argc,
if (benchmark && bench_start) { if (benchmark && bench_start) {
bench_end = timer_get_us(); bench_end = timer_get_us();
speed = (len * 1000000) / (bench_end - bench_start); speed = lldiv(len * 1000000, bench_end - bench_start);
printf("%s speed: %lukiB/s\n", printf("%s speed: %lukiB/s\n",
read ? "Read" : "Write", read ? "Read" : "Write",
(unsigned long)(speed / 1024)); (unsigned long)(speed >> 10));
} }
led_activity_off(); led_activity_off();