From 3dafdeface93a68c78f0921ea3d9237c7c622fdc Mon Sep 17 00:00:00 2001 From: Tanmay Kathpalia Date: Wed, 3 Dec 2025 04:21:37 -0800 Subject: [PATCH] mmc: sdhci-cadence: Enable software tuning for both SD and eMMC interfaces Remove interface type restrictions in sdhci_cdns_execute_tuning() to enable software tuning for both SD and eMMC devices. The previous assumption that SD timing should be handled by SDHCI core is incorrect based on the actual function assignment logic. The execute_tuning function is assigned based on MMC_SUPPORTS_TUNING config, which is enabled by both MMC_UHS_SUPPORT and MMC_HS200_SUPPORT. Changes: Remove IS_MMC() check that restricted tuning to eMMC only Remove opcode validation limited to MMC_CMD_SEND_TUNING_BLOCK_HS200 Signed-off-by: Tanmay Kathpalia Reviewed-by: Balsundar Ponnusamy Reviewed-by: Peng Fan Signed-off-by: Peng Fan --- drivers/mmc/sdhci-cadence.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/sdhci-cadence.c b/drivers/mmc/sdhci-cadence.c index a0b9434e4f0..c7f88977ef9 100644 --- a/drivers/mmc/sdhci-cadence.c +++ b/drivers/mmc/sdhci-cadence.c @@ -207,16 +207,10 @@ static int __maybe_unused sdhci_cdns_execute_tuning(struct udevice *dev, int i; /* - * This handler only implements the eMMC tuning that is specific to - * this controller. The tuning for SD timing should be handled by the - * SDHCI core. + * This function performs the tuning process for both SD and eMMC + * interfaces. It sweeps through all available tuning points, + * sending tuning commands at each step. */ - if (!IS_MMC(mmc)) - return -ENOTSUPP; - - if (WARN_ON(opcode != MMC_CMD_SEND_TUNING_BLOCK_HS200)) - return -EINVAL; - for (i = 0; i < SDHCI_CDNS_MAX_TUNING_LOOP; i++) { if (sdhci_cdns_set_tune_val(plat, i) || mmc_send_tuning(mmc, opcode)) { /* bad */