mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2025-11-28 22:21:49 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

x86: Do sanity test on the cache record in mrccache_update()

Browse Source 
For the cache record to write in mrccache_update(), we should
perform a sanity test to see if it is a valid one.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Bin Meng 2015-10-11 21:37:37 -07:00 committed by Simon Glass
parent f6220f1a86
commit 2fe66dbcbc
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/x86/include/asm/mrccache.h
View File

@ -43,7 +43,7 @@ struct mrc_data_container *mrccache_find_current(struct fmap_entry *entry);
* @entry: Position and size of MRC cache in SPI flash * @entry: Position and size of MRC cache in SPI flash
* @cur: Record to write * @cur: Record to write
* @return 0 if updated, -EEXIST if the record is the same as the latest * @return 0 if updated, -EEXIST if the record is the same as the latest
* record, other error if SPI write failed * record, -EINVAL if the record is not valid, other error if SPI write failed
*/ */
int mrccache_update(struct udevice *sf, struct fmap_entry *entry, int mrccache_update(struct udevice *sf, struct fmap_entry *entry,
struct mrc_data_container *cur); struct mrc_data_container *cur);

3
arch/x86/lib/mrccache.c
View File

@ -112,6 +112,9 @@ int mrccache_update(struct udevice *sf, struct fmap_entry *entry,
ulong base_addr; ulong base_addr;
int ret; int ret;
if (!is_mrc_cache(cur))
return -EINVAL;
/* Find the last used block */ /* Find the last used block */
base_addr = (1ULL << 32) - CONFIG_ROM_SIZE + entry->offset; base_addr = (1ULL << 32) - CONFIG_ROM_SIZE + entry->offset;
debug("Updating MRC cache data\n"); debug("Updating MRC cache data\n");