mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2025-12-22 18:01:29 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

usb: host: ehci-msm: Disable clocks after all register accesses

Browse Source 
We need the USB clocks to do accesses like
  wait_for_bit_le32(&ehci->usbcmd, CMD_RESET, ...)
so we should disable them only after all of them are done.

At the moment this works only because the clock driver doesn't actually
disabling these clocks in U-Boot.

Fixes: 9b3a9f896e66 ("ehci: msm: bring up iface + core clocks")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Acked-by: Caleb Connolly <caleb.connolly@linaro.org>
Tested-by: Sam Day <me@samcday.com>
Link: https://patch.msgid.link/20250407-ehci-msm-fixes-v1-3-f8b30eb05d07@linaro.org
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
This commit is contained in:
Stephan Gerhold 2025-04-07 11:54:23 +02:00 committed by Tom Rini
parent e4e47da7e8
commit 2faabff358
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/host/ehci-msm.c
View File

@ -110,9 +110,6 @@ static int ehci_usb_remove(struct udevice *dev)
/* Stop controller. */ /* Stop controller. */
clrbits_le32(&ehci->usbcmd, CMD_RUN); clrbits_le32(&ehci->usbcmd, CMD_RUN);
clk_disable_unprepare(&p->iface_clk);
clk_disable_unprepare(&p->core_clk);
ret = generic_shutdown_phy(&p->phy); ret = generic_shutdown_phy(&p->phy);
if (ret) if (ret)
return ret; return ret;
@ -130,6 +127,8 @@ static int ehci_usb_remove(struct udevice *dev)
return -ETIMEDOUT; return -ETIMEDOUT;
} }
clk_disable_unprepare(&p->iface_clk);
clk_disable_unprepare(&p->core_clk);
return 0; return 0;
} }