mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2025-08-06 07:17:01 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

fastboot: Fix off by 1 error

Browse Source 
strlen only reports length of string not including terminating 0 byte
but this has to be included in length of receiving buffer on copy so
adjust length check to be correct.

This issue found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
This commit is contained in:
Andrew Goodbody 2025-07-17 09:43:29 +01:00 committed by Tom Rini
parent afca60620a
commit 23d2c182d4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/fastboot/fb_command.c
View File

@ -413,7 +413,7 @@ static void __maybe_unused run_acmd(char *cmd_parameter, char *response)
return;
}
if (strlen(cmd_parameter) > sizeof(g_a_cmd_buff)) {
if (strlen(cmd_parameter) >= sizeof(g_a_cmd_buff)) {
pr_err("too long command\n");
fastboot_fail("too long command", response);
return;