mirrors/u-boot
1
0
Fork 0
mirror of https://source.denx.de/u-boot/u-boot.git synced 2025-08-15 03:36:59 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

test/cmd/wget.c: move net_test_wget() to the cmd test suite

Browse Source 
Since net_test_wget() is testing a command and is in test/cmd it should
be in the 'cmd' test suite, not 'lib'.

Saving and restoring the values of the environment variables that the
test manipulates is necessary to avoid a regression when running the
whole ut test suite. A minimal reproducer is:

 $ ./u-boot -T -c "ut cmd net_test_wget; ut dm dm_test_eth_act" | \
     grep -E "(Test:|Failures:)"

Reported-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
This commit is contained in:
Jerome Forissier 2024-11-15 17:45:14 +01:00 committed by Tom Rini
parent 6ceb861882
commit 20f641987f
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/cmd/wget.c
View File

@ -19,7 +19,7 @@
#include <dm/test.h> #include <dm/test.h>
#include <dm/device-internal.h> #include <dm/device-internal.h>
#include <dm/uclass-internal.h> #include <dm/uclass-internal.h>
#include <test/lib.h> #include <test/cmd.h>
#include <test/test.h> #include <test/test.h>
#include <test/ut.h> #include <test/ut.h>
@ -206,6 +206,10 @@ static int sb_http_handler(struct udevice *dev, void *packet,
static int net_test_wget(struct unit_test_state *uts) static int net_test_wget(struct unit_test_state *uts)
{ {
char *prev_ethact = env_get("ethact");
char *prev_ethrotate = env_get("ethrotate");
char *prev_loadaddr = env_get("loadaddr");
sandbox_eth_set_tx_handler(0, sb_http_handler); sandbox_eth_set_tx_handler(0, sb_http_handler);
sandbox_eth_set_priv(0, uts); sandbox_eth_set_priv(0, uts);
@ -223,6 +227,10 @@ static int net_test_wget(struct unit_test_state *uts)
ut_assert_nextline("md5 for 00020000 ... 0002001f ==> 234af48e94b0085060249ecb5942ab57"); ut_assert_nextline("md5 for 00020000 ... 0002001f ==> 234af48e94b0085060249ecb5942ab57");
ut_assert_console_end(); ut_assert_console_end();
env_set("ethact", prev_ethact);
env_set("ethrotate", prev_ethrotate);
env_set("loadaddr", prev_loadaddr);
return 0; return 0;
} }
LIB_TEST(net_test_wget, UTF_CONSOLE); CMD_TEST(net_test_wget, UTF_CONSOLE);