net: sh-eth: Use memalign instead of orignal memroy alignment function

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
This commit is contained in:
Nobuhiro Iwamatsu 2014-11-04 09:15:47 +09:00 committed by Nobuhiro Iwamatsu
parent 703949e495
commit 000889cdb9
2 changed files with 41 additions and 48 deletions

View File

@ -181,7 +181,7 @@ static int sh_eth_reset(struct sh_eth_dev *eth)
static int sh_eth_tx_desc_init(struct sh_eth_dev *eth) static int sh_eth_tx_desc_init(struct sh_eth_dev *eth)
{ {
int port = eth->port, i, ret = 0; int port = eth->port, i, ret = 0;
u32 tmp_addr; u32 alloc_desc_size = NUM_TX_DESC * sizeof(struct tx_desc_s);
struct sh_eth_info *port_info = &eth->port_info[port]; struct sh_eth_info *port_info = &eth->port_info[port];
struct tx_desc_s *cur_tx_desc; struct tx_desc_s *cur_tx_desc;
@ -189,21 +189,19 @@ static int sh_eth_tx_desc_init(struct sh_eth_dev *eth)
* Allocate rx descriptors. They must be aligned to size of struct * Allocate rx descriptors. They must be aligned to size of struct
* tx_desc_s. * tx_desc_s.
*/ */
port_info->tx_desc_malloc = malloc(NUM_TX_DESC * port_info->tx_desc_alloc =
sizeof(struct tx_desc_s) + memalign(sizeof(struct tx_desc_s), alloc_desc_size);
sizeof(struct tx_desc_s) - 1); if (!port_info->tx_desc_alloc) {
if (!port_info->tx_desc_malloc) { printf(SHETHER_NAME ": memalign failed\n");
printf(SHETHER_NAME ": malloc failed\n");
ret = -ENOMEM; ret = -ENOMEM;
goto err; goto err;
} }
tmp_addr = (u32) (((int)port_info->tx_desc_malloc + flush_cache_wback((u32)port_info->tx_desc_alloc, alloc_desc_size);
sizeof(struct tx_desc_s) - 1) &
~(sizeof(struct tx_desc_s) - 1));
flush_cache_wback(tmp_addr, NUM_TX_DESC * sizeof(struct tx_desc_s));
/* Make sure we use a P2 address (non-cacheable) */ /* Make sure we use a P2 address (non-cacheable) */
port_info->tx_desc_base = (struct tx_desc_s *)ADDR_TO_P2(tmp_addr); port_info->tx_desc_base =
(struct tx_desc_s *)ADDR_TO_P2((u32)port_info->tx_desc_alloc);
port_info->tx_desc_cur = port_info->tx_desc_base; port_info->tx_desc_cur = port_info->tx_desc_base;
/* Initialize all descriptors */ /* Initialize all descriptors */
@ -234,49 +232,44 @@ err:
static int sh_eth_rx_desc_init(struct sh_eth_dev *eth) static int sh_eth_rx_desc_init(struct sh_eth_dev *eth)
{ {
int port = eth->port, i , ret = 0; int port = eth->port, i , ret = 0;
u32 alloc_desc_size = NUM_RX_DESC * sizeof(struct rx_desc_s);
struct sh_eth_info *port_info = &eth->port_info[port]; struct sh_eth_info *port_info = &eth->port_info[port];
struct rx_desc_s *cur_rx_desc; struct rx_desc_s *cur_rx_desc;
u32 tmp_addr;
u8 *rx_buf; u8 *rx_buf;
/* /*
* Allocate rx descriptors. They must be aligned to size of struct * Allocate rx descriptors. They must be aligned to size of struct
* rx_desc_s. * rx_desc_s.
*/ */
port_info->rx_desc_malloc = malloc(NUM_RX_DESC * port_info->rx_desc_alloc =
sizeof(struct rx_desc_s) + memalign(sizeof(struct rx_desc_s), alloc_desc_size);
sizeof(struct rx_desc_s) - 1); if (!port_info->rx_desc_alloc) {
if (!port_info->rx_desc_malloc) { printf(SHETHER_NAME ": memalign failed\n");
printf(SHETHER_NAME ": malloc failed\n");
ret = -ENOMEM; ret = -ENOMEM;
goto err; goto err;
} }
tmp_addr = (u32) (((int)port_info->rx_desc_malloc + flush_cache_wback(port_info->rx_desc_alloc, alloc_desc_size);
sizeof(struct rx_desc_s) - 1) &
~(sizeof(struct rx_desc_s) - 1));
flush_cache_wback(tmp_addr, NUM_RX_DESC * sizeof(struct rx_desc_s));
/* Make sure we use a P2 address (non-cacheable) */ /* Make sure we use a P2 address (non-cacheable) */
port_info->rx_desc_base = (struct rx_desc_s *)ADDR_TO_P2(tmp_addr); port_info->rx_desc_base =
(struct rx_desc_s *)ADDR_TO_P2((u32)port_info->rx_desc_alloc);
port_info->rx_desc_cur = port_info->rx_desc_base; port_info->rx_desc_cur = port_info->rx_desc_base;
/* /*
* Allocate rx data buffers. They must be 32 bytes aligned and in * Allocate rx data buffers. They must be RX_BUF_ALIGNE_SIZE bytes
* P2 area * aligned and in P2 area.
*/ */
port_info->rx_buf_malloc = malloc( port_info->rx_buf_alloc =
NUM_RX_DESC * MAX_BUF_SIZE + RX_BUF_ALIGNE_SIZE - 1); memalign(RX_BUF_ALIGNE_SIZE, NUM_RX_DESC * MAX_BUF_SIZE);
if (!port_info->rx_buf_malloc) { if (!port_info->rx_buf_alloc) {
printf(SHETHER_NAME ": malloc failed\n"); printf(SHETHER_NAME ": alloc failed\n");
ret = -ENOMEM; ret = -ENOMEM;
goto err_buf_malloc; goto err_buf_alloc;
} }
tmp_addr = (u32)(((int)port_info->rx_buf_malloc port_info->rx_buf_base = (u8 *)ADDR_TO_P2((u32)port_info->rx_buf_alloc);
+ (RX_BUF_ALIGNE_SIZE - 1)) &
~(RX_BUF_ALIGNE_SIZE - 1));
port_info->rx_buf_base = (u8 *)ADDR_TO_P2(tmp_addr);
/* Initialize all descriptors */ /* Initialize all descriptors */
for (cur_rx_desc = port_info->rx_desc_base, for (cur_rx_desc = port_info->rx_desc_base,
@ -301,9 +294,9 @@ static int sh_eth_rx_desc_init(struct sh_eth_dev *eth)
return ret; return ret;
err_buf_malloc: err_buf_alloc:
free(port_info->rx_desc_malloc); free(port_info->rx_desc_alloc);
port_info->rx_desc_malloc = NULL; port_info->rx_desc_alloc = NULL;
err: err:
return ret; return ret;
@ -314,9 +307,9 @@ static void sh_eth_tx_desc_free(struct sh_eth_dev *eth)
int port = eth->port; int port = eth->port;
struct sh_eth_info *port_info = &eth->port_info[port]; struct sh_eth_info *port_info = &eth->port_info[port];
if (port_info->tx_desc_malloc) { if (port_info->tx_desc_alloc) {
free(port_info->tx_desc_malloc); free(port_info->tx_desc_alloc);
port_info->tx_desc_malloc = NULL; port_info->tx_desc_alloc = NULL;
} }
} }
@ -325,14 +318,14 @@ static void sh_eth_rx_desc_free(struct sh_eth_dev *eth)
int port = eth->port; int port = eth->port;
struct sh_eth_info *port_info = &eth->port_info[port]; struct sh_eth_info *port_info = &eth->port_info[port];
if (port_info->rx_desc_malloc) { if (port_info->rx_desc_alloc) {
free(port_info->rx_desc_malloc); free(port_info->rx_desc_alloc);
port_info->rx_desc_malloc = NULL; port_info->rx_desc_alloc = NULL;
} }
if (port_info->rx_buf_malloc) { if (port_info->rx_buf_alloc) {
free(port_info->rx_buf_malloc); free(port_info->rx_buf_alloc);
port_info->rx_buf_malloc = NULL; port_info->rx_buf_alloc = NULL;
} }
} }

View File

@ -78,13 +78,13 @@ struct rx_desc_s {
}; };
struct sh_eth_info { struct sh_eth_info {
struct tx_desc_s *tx_desc_malloc; struct tx_desc_s *tx_desc_alloc;
struct tx_desc_s *tx_desc_base; struct tx_desc_s *tx_desc_base;
struct tx_desc_s *tx_desc_cur; struct tx_desc_s *tx_desc_cur;
struct rx_desc_s *rx_desc_malloc; struct rx_desc_s *rx_desc_alloc;
struct rx_desc_s *rx_desc_base; struct rx_desc_s *rx_desc_base;
struct rx_desc_s *rx_desc_cur; struct rx_desc_s *rx_desc_cur;
u8 *rx_buf_malloc; u8 *rx_buf_alloc;
u8 *rx_buf_base; u8 *rx_buf_base;
u8 mac_addr[6]; u8 mac_addr[6];
u8 phy_addr; u8 phy_addr;