1136 Commits

Author SHA1 Message Date
Frenck Lutke
27b676b7b2 fix checkboxes shown as checked when they're not with mysql
The issue occurs because boolean/tinyint values are retrieved from mysql
as strings, and in php/js all non-empty strings are cast as boolean
true.

Current PDO mysql driver doesn't support `PDO::ATTR_STRINGIFY_FETCHES =
false`, and if I disable prepare-emulation so it uses the native MySQL
driver instead which supposedly does support it, prepare statements no
longer play nice with named parameters.

Every remaining clean solution that comes to mind that can cover all
cases, just for MySQL, adds an annoying amount of additional code /
overhead.

As long as the `App.FormFields.checkbox_tag()` JS function is the only
one suffering from the lack of conversion, I'll go with easy ugly over
here.
2021-02-25 12:24:23 +01:00
Andrew Dolgov
db583287b2 add hide/show events for feeds sidebar 2021-02-24 17:01:40 +03:00
Andrew Dolgov
7f41228a71 decouple runtime-info object from counters 2021-02-24 15:40:19 +03:00
Andrew Dolgov
553548b689 request label counters conditionally 2021-02-24 15:07:31 +03:00
Andrew Dolgov
8b09e653e0 pass array to setScore 2021-02-24 12:10:09 +03:00
Andrew Dolgov
155e4f6125 pass a bunch of related arrays properly to backend 2021-02-24 12:07:25 +03:00
Andrew Dolgov
96182597c4 fix typo 2021-02-24 10:38:54 +03:00
Andrew Dolgov
9ad5f04e51 only request counters once for headline mutations 2021-02-24 10:31:03 +03:00
Andrew Dolgov
6ea1430a04 no special counter handling for catchupAll 2021-02-24 10:01:39 +03:00
Andrew Dolgov
d6203bf350 try to calculate counters conditionally based on feed ids 2021-02-24 09:47:26 +03:00
Andrew Dolgov
8d2e3c2528 drop errors.php and simplify error handling 2021-02-23 22:26:07 +03:00
Andrew Dolgov
37d46411c7 App.requestCounters() is not a thing 2021-02-23 17:43:35 +03:00
Andrew Dolgov
33fff26869 reinstate HOOK_RENDER_ENCLOSURE 2021-02-22 10:00:50 +03:00
Andrew Dolgov
861a632ac7 move published opml JS code to pref helpers 2021-02-21 18:04:44 +03:00
Andrew Dolgov
c6b7a7f8d0 Merge branch 'master' of git.tt-rss.org:fox/tt-rss 2021-02-21 16:06:57 +03:00
Andrew Dolgov
2ab215daca batch editor: comment out getChildByName 2021-02-21 16:06:46 +03:00
Andrew Dolgov
521d0b65c7 batch feed editor: use tab layout, cleanup 2021-02-21 16:02:57 +03:00
wn_
1bd5152c80 Open the default feed after unsubscribing.
Previously the UI appeared to hang, even though the backend request had already completed successfully.
2021-02-21 12:48:15 +00:00
Andrew Dolgov
2843b99171 minor filter UI layout fix 2021-02-21 13:08:34 +03:00
Andrew Dolgov
810afdaf5a prevent creation of filter rules matching no feeds 2021-02-21 12:28:25 +03:00
Andrew Dolgov
fb471652c0 Merge branch 'wip-filter-stuff' 2021-02-21 10:35:39 +03:00
Andrew Dolgov
9e56896bd4 Element visible: check for offsetHeight/offsetWidth 2021-02-21 10:34:28 +03:00
Andrew Dolgov
3b8d69206c deal with filter actions UI 2021-02-21 10:28:59 +03:00
Andrew Dolgov
94560132dd for the most part, deal with filter rules UI 2021-02-21 09:35:07 +03:00
Andrew Dolgov
b4e96374bc more filter stuff 2021-02-20 21:48:05 +03:00
Andrew Dolgov
da97b29dbe prevent filter selected text dialog from opening in wrong order 2021-02-20 21:07:28 +03:00
Andrew Dolgov
590b1fc39e a few more methods shuffled around 2021-02-20 18:21:36 +03:00
Andrew Dolgov
be91355c20 first for filter frontend overhaul 2021-02-20 18:15:08 +03:00
Andrew Dolgov
d6de021ae6 haven't i fixed this already 2021-02-20 13:52:02 +03:00
Andrew Dolgov
22fe9b54d2 feed editor: use client dialog 2021-02-20 13:32:09 +03:00
Andrew Dolgov
9586c72a17 wip: feed editor client-side 2021-02-20 10:26:09 +03:00
Andrew Dolgov
c9ccb0791d fix for startup crash because of classes containing spaces 2021-02-19 20:05:56 +03:00
Andrew Dolgov
cf249d7e8c modify classname helpers to use element.classList; fix feed debugger & share--get 2021-02-19 19:29:43 +03:00
Andrew Dolgov
d5f4979831 headlines.select: maybe fix another one 2021-02-19 18:50:02 +03:00
Andrew Dolgov
737cffc241 render feed icon markup on the client 2021-02-19 17:40:11 +03:00
Andrew Dolgov
d445530fa0 format note on the client 2021-02-19 17:15:22 +03:00
Andrew Dolgov
921b5ca2ce add onTagsUpdated similar to onLabelsUpdated 2021-02-19 15:34:28 +03:00
Andrew Dolgov
e73779fec1 render tags on the client 2021-02-19 15:31:50 +03:00
Andrew Dolgov
d9fe14a012 use template strings in a bunch of places instead of id concatenation 2021-02-19 15:09:53 +03:00
Andrew Dolgov
131f34648d render headline labels on the client 2021-02-19 15:03:48 +03:00
Andrew Dolgov
660a1bbe01 * switch to xhr.post() almost everywhere
* call App.handlerpcjson() automatically on json request (if possible)
 * show net/log indicators in prefs
2021-02-19 13:44:56 +03:00
Andrew Dolgov
bb4e4282f4 migrate a bunch of xhrPost invocations 2021-02-19 11:28:14 +03:00
Andrew Dolgov
6b43b788d9 migrate xhrJson invocations to the new helper 2021-02-19 10:22:00 +03:00
Andrew Dolgov
dba6dce3b3 add element fadeout/fadein and a shorter xhr helper 2021-02-19 10:15:36 +03:00
Andrew Dolgov
f645120641 table helpers: don't try to iterate over a single element 2021-02-19 07:54:44 +03:00
Andrew Dolgov
d26269865f use .closest() instead of .up() to lookup parent by selector 2021-02-19 07:43:05 +03:00
Andrew Dolgov
bec35200e9 fix some eslint-related stuff 2021-02-19 07:29:21 +03:00
Andrew Dolgov
00310d2d23 cleanup some unused code, fix App.byId() invoked by wrong name 2021-02-19 06:58:50 +03:00
Andrew Dolgov
dcfea9baac properly validate feed editor dialog 2021-02-19 06:51:15 +03:00
Andrew Dolgov
d57e7eaa98 move stuff in common.js around a bit 2021-02-19 06:40:35 +03:00