LaurentGH
dfc42cf777
In Notify.info(), progress() and error() add a default value parameter
...
Instead of setting the parameter in the first line inside the function, add a default value for the keep parameter.
2025-11-20 17:44:26 +01:00
LaurentGH
3159887deb
Notify.progress() and Notify.error() parameter was useless
...
The second parameter "keep" of Notify.progress() and Notify.error() indicates if the windows is kept open or automatically closed.
The developer intent was to have keep=true when unset.
However, the code contained:
keep = keep || true;
If keep was unset the result was true, but if keep was false the result was also true.
If all cases (undef, false, true), this parameter was thus true, and it was impossible to automatically close this window.
It can be noted that a "grep -rs 'Notify.progress.*true' " finds 27 places where the second parameter true could be removed because this is the default value.
2025-11-20 13:48:12 +01:00
supahgreg
84697e4b66
Reduce JS logging, tweak some levels.
2025-10-18 20:32:20 +00:00
supahgreg
f85559735b
Remove 'App.byId()', which was essentially an alias of 'document.getElementById()'.
2025-10-14 23:23:01 +00:00
supahgreg
6bd52b28c2
Remove 'App.findAll()', which was essentially an alias of 'document.querySelectorAll()'.
2025-10-14 23:18:13 +00:00
supahgreg
6d36197247
Remove various Element and Array prototype extensions (and similar).
2025-10-14 22:43:09 +00:00
supahgreg
8b46ab31a9
Fix some more issues related to ESLint 'eqeqeq' changes (again).
2025-10-14 04:36:36 +00:00
supahgreg
47848d0198
Fix various ESLint 'no-undef' rule instances.
...
https://eslint.org/docs/latest/rules/no-undef
2025-10-12 22:32:55 +00:00
supahgreg
cde120b3d7
Clean up unnecessary eslint-disable directives (per ESLint).
2025-10-12 22:27:18 +00:00
supahgreg
360c552da4
Address rule 'no-redeclare' for 'dojo' and 'dijit' (defined as globals in 'eslint.config.js').
...
Also take care of 2 'no-prototype-builtins' and a 'no-useless-escape'.
* https://eslint.org/docs/latest/rules/no-redeclare
* https://eslint.org/docs/latest/rules/no-prototype-builtins
* https://eslint.org/docs/latest/rules/no-useless-escape
2025-10-12 21:48:10 +00:00
supahgreg
39182a76e4
Address ESLint rule 'eqeqeq'.
...
https://eslint.org/docs/latest/rules/eqeqeq
2025-10-12 21:34:29 +00:00
supahgreg
bb08b0acd5
Improve 'App.getSelectedText()'.
...
This also drops 'String.prototype.stripTags', which is no longer used.
2025-10-10 23:30:34 +00:00
Andrew Dolgov
31ef788e02
add window.requestIdleCallback polyfill for safari
2023-04-09 10:29:42 +03:00
Andrew Dolgov
8b743f7249
xhr.json: properly pass failure callback to xhr.post()
2021-11-14 16:08:01 +03:00
Andrew Dolgov
9b5d199ad9
xhr.json: don't call resolve() on failed to parse data
2021-11-14 15:57:56 +03:00
Andrew Dolgov
a0e41f41a4
add svg loading indicators
2021-03-16 21:32:44 +03:00
Andrew Dolgov
b74e313844
use computed style for element.prototype.visible
2021-03-04 14:53:33 +03:00
Andrew Dolgov
cb7f322f09
add basic plugin installer (uses tt-rss.org)
2021-03-03 19:07:39 +03:00
Andrew Dolgov
adf7189e94
show timing information in xhr.post/json
2021-03-03 09:56:35 +03:00
Andrew Dolgov
6359259dbb
simplify internal authentication code and bump default algo to SSHA-512
2021-03-01 15:24:18 +03:00
Andrew Dolgov
56b10fea18
pass translations to frontend as a json object
2021-02-26 09:21:17 +03:00
Andrew Dolgov
8d2e3c2528
drop errors.php and simplify error handling
2021-02-23 22:26:07 +03:00
Andrew Dolgov
fb471652c0
Merge branch 'wip-filter-stuff'
2021-02-21 10:35:39 +03:00
Andrew Dolgov
9e56896bd4
Element visible: check for offsetHeight/offsetWidth
2021-02-21 10:34:28 +03:00
Andrew Dolgov
da97b29dbe
prevent filter selected text dialog from opening in wrong order
2021-02-20 21:07:28 +03:00
Andrew Dolgov
cf249d7e8c
modify classname helpers to use element.classList; fix feed debugger & share--get
2021-02-19 19:29:43 +03:00
Andrew Dolgov
d445530fa0
format note on the client
2021-02-19 17:15:22 +03:00
Andrew Dolgov
660a1bbe01
* switch to xhr.post() almost everywhere
...
* call App.handlerpcjson() automatically on json request (if possible)
* show net/log indicators in prefs
2021-02-19 13:44:56 +03:00
Andrew Dolgov
bb4e4282f4
migrate a bunch of xhrPost invocations
2021-02-19 11:28:14 +03:00
Andrew Dolgov
6b43b788d9
migrate xhrJson invocations to the new helper
2021-02-19 10:22:00 +03:00
Andrew Dolgov
dba6dce3b3
add element fadeout/fadein and a shorter xhr helper
2021-02-19 10:15:36 +03:00
Andrew Dolgov
f645120641
table helpers: don't try to iterate over a single element
2021-02-19 07:54:44 +03:00
Andrew Dolgov
d26269865f
use .closest() instead of .up() to lookup parent by selector
2021-02-19 07:43:05 +03:00
Andrew Dolgov
bec35200e9
fix some eslint-related stuff
2021-02-19 07:29:21 +03:00
Andrew Dolgov
00310d2d23
cleanup some unused code, fix App.byId() invoked by wrong name
2021-02-19 06:58:50 +03:00
Andrew Dolgov
d57e7eaa98
move stuff in common.js around a bit
2021-02-19 06:40:35 +03:00
Andrew Dolgov
b6c3dde1cc
add $/423 shims
2021-02-18 22:26:00 +03:00
Andrew Dolgov
89fd9ec8c3
compat shim fixes
2021-02-18 22:15:54 +03:00
Andrew Dolgov
e61e7c8356
compat shim fixes
2021-02-18 22:14:40 +03:00
Andrew Dolgov
f77c17c6f0
add Element toggleClassName
2021-02-18 22:05:06 +03:00
Andrew Dolgov
70fa423026
initial for RIP prototype/scriptaculous
2021-02-18 21:51:18 +03:00
Andrew Dolgov
7f0800537e
silence (or fix) a bunch of eslint warnings
2021-02-12 19:02:09 +03:00
Andrew Dolgov
d01ad09800
eslint-related fixes; move a few things from global context to App
2020-06-05 07:44:57 +03:00
Andrew Dolgov
788ea95fbd
feed tree: do not mark Labels as Special
2020-02-22 16:44:31 +03:00
Andrew Dolgov
7a98105960
remove old fatalError(), move everything to App.Error
...
update exception dialog css
2018-12-11 13:18:38 +03:00
Andrew Dolgov
2cbc2f5261
bring back frontend sanity check w/ App.checkBrowserFeatures()
2018-12-11 12:30:48 +03:00
Andrew Dolgov
7cfd04ffb4
xhr helpers: wrap in promises
2018-12-11 08:42:38 +03:00
Andrew Dolgov
bd66a9ef28
render article on the client using headlines data
2018-12-08 09:32:14 +03:00
Andrew Dolgov
c31ae870c9
popupOpenArticle: don't cause an exception if popups are blocked
2018-12-07 22:07:13 +03:00
Andrew Dolgov
0b8cbc9156
remove some bitmaps and rework stuff using it to use iconfont instead
2018-12-06 15:22:52 +03:00
