mirror of
https://github.com/siderolabs/talos.git
synced 2025-08-10 16:47:04 +02:00
dc6ea74c35
The problem was that some of the health checks sort the list of the nodes in place (via `sort.Strings()`). If cluster info provider returns original slice, it might be mutated in such a way that it gets corrupted. We never noticed it before CAPI clusters, as in our tests IPs are assigned sequentially, and sort operation is a no-op. Specifically, the problem was with the `Nodes()` function, it returns `append(controlPlaneNodes, workerNodes...)` slice, which by definition might share memory with `controlPlaneNodes` slice. For example, if control plane nodes were `4, 5, 6` and worker nodes were `3`, the returned slice will be `4, 5, 6, 3`, and it shares memory with `controlPlaneNodes` slice (firs three items). If we apply `sort` to the returned slice, it re-orders it as `3, 4, 5, 6`, but as it is done in-place, the `controlPlaneNodes` slice is now `3, 4, 5`, which is obviously wrong. Fix that by always returning a copy of the slice from the functions implementing `ClusterInfo` interface. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
32 lines
854 B
Go
32 lines
854 B
Go
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
// +build integration
|
|
|
|
package base
|
|
|
|
import "github.com/talos-systems/talos/pkg/machinery/config/types/v1alpha1/machine"
|
|
|
|
type infoWrapper struct {
|
|
masterNodes []string
|
|
workerNodes []string
|
|
}
|
|
|
|
func (wrapper *infoWrapper) Nodes() []string {
|
|
return append([]string(nil), append(wrapper.masterNodes, wrapper.workerNodes...)...)
|
|
}
|
|
|
|
func (wrapper *infoWrapper) NodesByType(t machine.Type) []string {
|
|
switch t {
|
|
case machine.TypeInit:
|
|
return nil
|
|
case machine.TypeControlPlane:
|
|
return append([]string(nil), wrapper.masterNodes...)
|
|
case machine.TypeJoin:
|
|
return append([]string(nil), wrapper.workerNodes...)
|
|
default:
|
|
panic("unreachable")
|
|
}
|
|
}
|