mirror of
				https://github.com/siderolabs/talos.git
				synced 2025-11-04 02:11:12 +01:00 
			
		
		
		
	Bump golangci-lint and fixup new warnings. Ignore check that checks for used function parameters, it's kind of noisy and makes it confusing to read interface implementations. Signed-off-by: Noel Georgi <git@frezbo.dev>
		
			
				
	
	
		
			96 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			96 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// This Source Code Form is subject to the terms of the Mozilla Public
 | 
						|
// License, v. 2.0. If a copy of the MPL was not distributed with this
 | 
						|
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
 | 
						|
 | 
						|
package extensions
 | 
						|
 | 
						|
import (
 | 
						|
	"fmt"
 | 
						|
	"io/fs"
 | 
						|
	"os"
 | 
						|
	"path/filepath"
 | 
						|
	"strings"
 | 
						|
 | 
						|
	hashiversion "github.com/hashicorp/go-version"
 | 
						|
 | 
						|
	"github.com/siderolabs/talos/pkg/machinery/extensions"
 | 
						|
	"github.com/siderolabs/talos/pkg/version"
 | 
						|
)
 | 
						|
 | 
						|
// Validate the extension: compatibility, contents, etc.
 | 
						|
func (ext *Extension) Validate() error {
 | 
						|
	if err := ext.validateConstraints(); err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	return ext.validateContents()
 | 
						|
}
 | 
						|
 | 
						|
func (ext *Extension) validateConstraints() error {
 | 
						|
	if ext.Manifest.Metadata.Compatibility.Talos.Version != "" {
 | 
						|
		talosVersion, err := hashiversion.NewVersion(version.Tag)
 | 
						|
		if err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
 | 
						|
		versionConstraint, err := hashiversion.NewConstraint(ext.Manifest.Metadata.Compatibility.Talos.Version)
 | 
						|
		if err != nil {
 | 
						|
			return fmt.Errorf("error parsing Talos version constraint: %w", err)
 | 
						|
		}
 | 
						|
 | 
						|
		if !versionConstraint.Check(talosVersion.Core()) {
 | 
						|
			return fmt.Errorf("version constraint %s can't be satisfied with Talos version %s", versionConstraint, talosVersion)
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
//nolint:gocyclo
 | 
						|
func (ext *Extension) validateContents() error {
 | 
						|
	return filepath.WalkDir(ext.rootfsPath, func(path string, d fs.DirEntry, err error) error {
 | 
						|
		if err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
 | 
						|
		itemPath, err := filepath.Rel(ext.rootfsPath, path)
 | 
						|
		if err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
 | 
						|
		itemPath = filepath.Join("/", itemPath)
 | 
						|
 | 
						|
		// check for -------w-
 | 
						|
		if d.Type().Perm()&0o002 > 0 {
 | 
						|
			return fmt.Errorf("world-writeable files are not allowed: %q", itemPath)
 | 
						|
		}
 | 
						|
 | 
						|
		// no special files
 | 
						|
		if !d.IsDir() && !d.Type().IsRegular() && d.Type().Type() != os.ModeSymlink {
 | 
						|
			return fmt.Errorf("special files are not allowed: %q", itemPath)
 | 
						|
		}
 | 
						|
 | 
						|
		// regular file: check for file path being whitelisted
 | 
						|
		if !d.IsDir() {
 | 
						|
			allowed := false
 | 
						|
 | 
						|
			for _, allowedPath := range extensions.AllowedPaths {
 | 
						|
				if strings.HasPrefix(itemPath, allowedPath) {
 | 
						|
					_, err = filepath.Rel(allowedPath, itemPath)
 | 
						|
					if err == nil {
 | 
						|
						allowed = true
 | 
						|
 | 
						|
						break
 | 
						|
					}
 | 
						|
				}
 | 
						|
			}
 | 
						|
 | 
						|
			if !allowed {
 | 
						|
				return fmt.Errorf("path %q is not allowed in extensions", itemPath)
 | 
						|
			}
 | 
						|
		}
 | 
						|
 | 
						|
		return nil
 | 
						|
	})
 | 
						|
}
 |