talos/internal/pkg/dns/dns_test.go
Dmitriy Matrenichev a5bd770bf9
fix: retry with another upstream if the previous failed
Do not return response to the client if we got SERVFAIL or REFUSED,
until we run out of upstreams.

Fixes #9143

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
2024-08-14 22:19:10 +03:00

186 lines
4.3 KiB
Go

// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
package dns_test
import (
"context"
"net"
"net/netip"
"testing"
"time"
"github.com/coredns/coredns/plugin/pkg/proxy"
dnssrv "github.com/miekg/dns"
"github.com/siderolabs/gen/ensure"
"github.com/siderolabs/gen/xslices"
"github.com/siderolabs/gen/xtesting/check"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"
"github.com/siderolabs/talos/internal/pkg/dns"
)
func TestDNS(t *testing.T) {
tests := []struct {
name string
hostname string
nameservers []string
expectedCode int
errCheck check.Check
}{
{
name: "success",
hostname: "google.com",
nameservers: []string{"8.8.8.8"},
expectedCode: dnssrv.RcodeSuccess,
errCheck: check.NoError(),
},
{
name: "failure",
hostname: "google.com",
nameservers: []string{"242.242.242.242"},
errCheck: check.ErrorContains("i/o timeout"),
},
{
name: "empty destinations",
hostname: "google.com",
nameservers: nil,
expectedCode: dnssrv.RcodeServerFailure,
errCheck: check.NoError(),
},
{
name: "empty destinations but node exists",
hostname: "talos-default-worker-1",
nameservers: nil,
expectedCode: dnssrv.RcodeSuccess,
errCheck: check.NoError(),
},
{
name: "empty destinations but node doesn't exists",
hostname: "talos-default-worker-2",
nameservers: []string{"8.8.8.8"},
expectedCode: dnssrv.RcodeNameError,
errCheck: check.NoError(),
},
{
// The first one will return SERVFAIL and the second will return REFUSED. We should try both.
name: `should return "refused"`,
hostname: "dnssec-failed.org",
nameservers: []string{"1.1.1.1", "ns-1098.awsdns-09.org."},
expectedCode: dnssrv.RcodeRefused,
errCheck: check.NoError(),
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
stop := newServer(t, test.nameservers...)
t.Cleanup(stop)
time.Sleep(10 * time.Millisecond)
r, err := dnssrv.Exchange(createQuery(test.hostname), "127.0.0.53:10700")
test.errCheck(t, err)
if r != nil {
require.Equal(t, test.expectedCode, r.Rcode, r)
}
t.Logf("r: %s", r)
})
}
}
func TestDNSEmptyDestinations(t *testing.T) {
stop := newServer(t)
defer stop()
time.Sleep(10 * time.Millisecond)
r, err := dnssrv.Exchange(createQuery("google.com"), "127.0.0.53:10700")
require.NoError(t, err)
require.Equal(t, dnssrv.RcodeServerFailure, r.Rcode, r)
r, err = dnssrv.Exchange(createQuery("google.com"), "127.0.0.53:10700")
require.NoError(t, err)
require.Equal(t, dnssrv.RcodeServerFailure, r.Rcode, r)
stop()
}
func newServer(t *testing.T, nameservers ...string) func() {
l := zaptest.NewLogger(t)
handler := dns.NewHandler(l)
t.Cleanup(handler.Stop)
pxs := xslices.Map(nameservers, func(ns string) *proxy.Proxy {
p := proxy.NewProxy(ns, net.JoinHostPort(ns, "53"), "dns")
p.Start(500 * time.Millisecond)
t.Cleanup(p.Stop)
return p
})
handler.SetProxy(pxs)
pc, err := dns.NewUDPPacketConn("udp", "127.0.0.53:10700", ensure.Value(dns.MakeControl("udp", false)))
require.NoError(t, err)
nodeHandler := dns.NewNodeHandler(handler, &testResolver{}, l)
nodeHandler.SetEnabled(true)
srv := dns.NewServer(dns.ServerOptions{
PacketConn: pc,
Handler: dns.NewCache(nodeHandler, l),
Logger: l,
})
stop, _ := srv.Start(func(err error) {
if err != nil {
t.Errorf("error running dns server: %v", err)
}
t.Logf("dns server stopped")
})
return stop
}
func createQuery(name string) *dnssrv.Msg {
return &dnssrv.Msg{
MsgHdr: dnssrv.MsgHdr{
Id: dnssrv.Id(),
RecursionDesired: true,
},
Question: []dnssrv.Question{
{
Name: dnssrv.Fqdn(name),
Qtype: dnssrv.TypeA,
Qclass: dnssrv.ClassINET,
},
},
}
}
type testResolver struct{}
func (*testResolver) ResolveAddr(_ context.Context, qType uint16, name string) []netip.Addr {
if qType != dnssrv.TypeA {
return nil
}
switch name {
case "talos-default-controlplane-1.":
return []netip.Addr{netip.MustParseAddr("172.20.0.2")}
case "talos-default-worker-1.":
return []netip.Addr{netip.MustParseAddr("172.20.0.3")}
default:
return nil
}
}