talos/pkg/proc/reaper/hunter.go
Andrey Smirnov c0698c1815 chore(machined): implement process reaper for PID 1 machined process
In UNIX, any zombies without parent process get re-parented to process
with PID 1 (usually running init), and PID 1 process should take care of
them (usually simply clean them up). Cleaning up zombies is important,
as they still take kerner resources, and having enormous amount of
zombie processes signifcantly degrades system performance.

For Talos, PID 1 process is machined, and machined itself forks to run
other processes in process runner and `pkg/cmd` one-time commands. Naive
solution of running `wait()` loop doesn't work as it might race with
`Process.Wait()` and clean up zombie which wasn't re-parented which
leads to process execution false failure.

After considering other solutions, we decided to go with the simple
approach: machined runs global zombie process reaper which publishes
information about reaped zombies. Any call to `Process.Wait()` (or
`Command.Wait()` which calls it) should be replaced with listening to
reaper's channel for notifications to catch info about the process which
was created in this call.

There are several changes in this PR:

1. Reaper implementation itself, started from machined.

2. Process runner and `pkg/cmd` can either use regular `Command.Wait()`
or use reaper notifications depending on reaper status (running/not
running). This allows using this code outside of machined.

3. Small bug fixes with process log which was affecting the tests.

Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
2019-09-05 10:01:02 -07:00

147 lines
2.5 KiB
Go

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
package reaper
import (
"log"
"os"
"os/signal"
"sync"
"syscall"
)
type zombieHunter struct {
mu sync.Mutex
running bool
listeners map[chan<- ProcessInfo]struct{}
shutdown chan struct{}
}
func (zh *zombieHunter) Run() {
zh.mu.Lock()
defer zh.mu.Unlock()
if zh.running {
panic("zombie hunter is already running")
}
zh.running = true
zh.shutdown = make(chan struct{})
zh.listeners = make(map[chan<- ProcessInfo]struct{})
go zh.run()
}
func (zh *zombieHunter) Shutdown() {
zh.mu.Lock()
running := zh.running
zh.mu.Unlock()
if !running {
return
}
zh.shutdown <- struct{}{}
<-zh.shutdown
}
func (zh *zombieHunter) Notify(ch chan<- ProcessInfo) bool {
zh.mu.Lock()
defer zh.mu.Unlock()
if !zh.running {
return false
}
zh.listeners[ch] = struct{}{}
return true
}
func (zh *zombieHunter) Stop(ch chan<- ProcessInfo) {
zh.mu.Lock()
defer zh.mu.Unlock()
delete(zh.listeners, ch)
}
func (zh *zombieHunter) run() {
sigCh := make(chan os.Signal, 1)
signal.Notify(sigCh, syscall.SIGCHLD)
defer signal.Stop(sigCh)
for {
// wait for SIGCHLD
select {
case <-sigCh:
case <-zh.shutdown:
zh.mu.Lock()
zh.running = false
zh.mu.Unlock()
zh.shutdown <- struct{}{}
return
}
// reap all the zombies
zh.reapLoop()
}
}
// reapLoop processes all the known zombies at the moment
func (zh *zombieHunter) reapLoop() {
for {
var (
wstatus syscall.WaitStatus
pid int
err error
)
for {
// retry EINTR on wait4()
pid, err = syscall.Wait4(-1, &wstatus, syscall.WNOHANG, nil)
if err != syscall.EINTR {
break
}
}
if err == syscall.ECHILD || pid == 0 {
// no more zombies
return
}
if err != nil {
log.Printf("zombie reaper error in wait4: %s", err)
return
}
zh.send(pid, wstatus)
}
}
// send notification about reaped zombie to all listeners
func (zh *zombieHunter) send(pid int, wstatus syscall.WaitStatus) {
zh.mu.Lock()
listeners := make([]chan<- ProcessInfo, 0, len(zh.listeners))
for ch := range zh.listeners {
listeners = append(listeners, ch)
}
zh.mu.Unlock()
notification := ProcessInfo{
Pid: pid,
Status: wstatus,
}
for _, listener := range listeners {
select {
case listener <- notification:
default:
// drop notifications if listener is not keeping up
}
}
}