Andrey Smirnov a068acfbe4 feat: split routerd from apid
New service `routerd` performs exactly single task: based on incoming
API call service name, it routes the requests to the appropriate Talos
service (`networkd`, `osd`, etc.) Service `routerd` listens of file
socket and routes requests to file sockets.

Service `apid` now does single task as well:

* it either fans out request to other `apid` services running on other
nodes and aggregates responses
* or it forwards requests to local `routerd` (when request destination
is local node)

Cons:

* one more proxying layer on request path

Pros:

* more clear service roles
* `routerd` is part of core Talos, services should register with it to
expose their API; no auth in the service (not exposed to the world)
* `apid` might be replaced with other implementation, it depends on TLS infra,
auth, etc.
* `apid` is better segregated from other Talos services (can only access
`routerd`, can't talk to other Talos services directly, so less exposure
in case of a bug)

This change is no-op to the end users.

Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
2020-03-05 22:05:56 +03:00

164 lines
4.9 KiB
Go

// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
// nolint: dupl,golint
package services
import (
"context"
"fmt"
"net"
"path/filepath"
"strings"
"time"
containerdapi "github.com/containerd/containerd"
"github.com/containerd/containerd/oci"
specs "github.com/opencontainers/runtime-spec/specs-go"
"github.com/talos-systems/talos/internal/app/machined/pkg/system/health"
"github.com/talos-systems/talos/internal/app/machined/pkg/system/runner"
"github.com/talos-systems/talos/internal/app/machined/pkg/system/runner/containerd"
"github.com/talos-systems/talos/internal/app/machined/pkg/system/runner/restart"
"github.com/talos-systems/talos/internal/pkg/conditions"
"github.com/talos-systems/talos/internal/pkg/runtime"
"github.com/talos-systems/talos/pkg/config/machine"
"github.com/talos-systems/talos/pkg/constants"
"github.com/talos-systems/talos/pkg/kubernetes"
"github.com/talos-systems/talos/pkg/retry"
)
// APID implements the Service interface. It serves as the concrete type with
// the required methods.
type APID struct{}
// ID implements the Service interface.
func (o *APID) ID(config runtime.Configurator) string {
return "apid"
}
// PreFunc implements the Service interface.
func (o *APID) PreFunc(ctx context.Context, config runtime.Configurator) error {
importer := containerd.NewImporter(constants.SystemContainerdNamespace, containerd.WithContainerdAddress(constants.SystemContainerdAddress))
return importer.Import(&containerd.ImportRequest{
Path: "/usr/images/apid.tar",
Options: []containerdapi.ImportOpt{
containerdapi.WithIndexName("talos/apid"),
},
})
}
// PostFunc implements the Service interface.
func (o *APID) PostFunc(config runtime.Configurator) (err error) {
return nil
}
// Condition implements the Service interface.
func (o *APID) Condition(config runtime.Configurator) conditions.Condition {
if config.Machine().Type() == machine.TypeWorker {
return conditions.WaitForFileToExist(constants.KubeletKubeconfig)
}
return nil
}
// DependsOn implements the Service interface.
func (o *APID) DependsOn(config runtime.Configurator) []string {
return []string{"system-containerd", "containerd"}
}
func (o *APID) Runner(config runtime.Configurator) (runner.Runner, error) {
image := "talos/apid"
endpoints := []string{"127.0.0.1"}
if config.Machine().Type() == machine.TypeWorker {
opts := []retry.Option{retry.WithUnits(3 * time.Second), retry.WithJitter(time.Second)}
err := retry.Constant(10*time.Minute, opts...).Retry(func() error {
h, err := kubernetes.NewClientFromKubeletKubeconfig()
if err != nil {
return retry.ExpectedError(fmt.Errorf("failed to create client: %w", err))
}
endpoints, err = h.MasterIPs()
if err != nil {
return retry.ExpectedError(err)
}
return nil
})
if err != nil {
return nil, err
}
}
// Set the process arguments.
args := runner.Args{
ID: o.ID(config),
ProcessArgs: []string{
"/apid",
"--config=" + constants.ConfigPath,
"--endpoints=" + strings.Join(endpoints, ","),
},
}
// Set the mounts.
mounts := []specs.Mount{
{Type: "bind", Destination: "/etc/ssl", Source: "/etc/ssl", Options: []string{"bind", "ro"}},
{Type: "bind", Destination: constants.ConfigPath, Source: constants.ConfigPath, Options: []string{"rbind", "ro"}},
{Type: "bind", Destination: filepath.Dir(constants.RouterdSocketPath), Source: filepath.Dir(constants.RouterdSocketPath), Options: []string{"rbind", "ro"}},
}
env := []string{}
for key, val := range config.Machine().Env() {
switch strings.ToLower(key) {
// explicitly exclude proxy variables from apid since this will
// negatively impact grpc connections.
// ref: https://github.com/grpc/grpc-go/blob/0f32486dd3c9bc29705535bd7e2e43801824cbc4/clientconn.go#L199-L206
// ref: https://github.com/grpc/grpc-go/blob/63ae68c9686cc0dd26c4f7476d66bb2f5c31789f/proxy.go#L118-L144
case "no_proxy":
case "http_proxy":
case "https_proxy":
default:
env = append(env, fmt.Sprintf("%s=%s", key, val))
}
}
return restart.New(containerd.NewRunner(
config.Debug(),
&args,
runner.WithContainerdAddress(constants.SystemContainerdAddress),
runner.WithContainerImage(image),
runner.WithEnv(env),
runner.WithOCISpecOpts(
oci.WithHostNamespace(specs.NetworkNamespace),
oci.WithMounts(mounts),
),
),
restart.WithType(restart.Forever),
), nil
}
// HealthFunc implements the HealthcheckedService interface
func (o *APID) HealthFunc(runtime.Configurator) health.Check {
return func(ctx context.Context) error {
var d net.Dialer
conn, err := d.DialContext(ctx, "tcp", fmt.Sprintf("%s:%d", "127.0.0.1", constants.ApidPort))
if err != nil {
return err
}
return conn.Close()
}
}
// HealthSettings implements the HealthcheckedService interface
func (o *APID) HealthSettings(runtime.Configurator) *health.Settings {
return &health.DefaultSettings
}