mirror of
https://github.com/siderolabs/talos.git
synced 2025-10-08 14:11:13 +02:00
Implement a screen for entering/managing the config `${code}` variable. Enable this screen only when the platform is `metal` and there is a `${code}` variable in the `talos.config` kernel cmdline URL query. Additionally, remove the "Delete" button and its functionality from the network config screen to avoid users accidentally deleting PlatformNetworkConfig parts that are not managed by the dashboard. Add some tests for the form data parsing on the network config screen. Remove the unnecessary lock on the summary tab - all updates come from the same goroutine. Closes siderolabs/talos#6993. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
246 lines
5.5 KiB
Go
246 lines
5.5 KiB
Go
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
package dashboard
|
|
|
|
import (
|
|
"fmt"
|
|
"net/netip"
|
|
"strings"
|
|
"unicode"
|
|
|
|
"github.com/hashicorp/go-multierror"
|
|
|
|
"github.com/siderolabs/talos/internal/app/machined/pkg/runtime"
|
|
"github.com/siderolabs/talos/pkg/machinery/nethelpers"
|
|
"github.com/siderolabs/talos/pkg/machinery/resources/network"
|
|
)
|
|
|
|
const (
|
|
interfaceNone = "(none)"
|
|
|
|
// ModeDHCP is the DHCP mode for the link.
|
|
ModeDHCP = "DHCP"
|
|
|
|
// ModeStatic is the static IP mode for the link.
|
|
ModeStatic = "Static"
|
|
)
|
|
|
|
// NetworkConfigFormData is the form data for the network config.
|
|
type NetworkConfigFormData struct {
|
|
Base runtime.PlatformNetworkConfig
|
|
Hostname string
|
|
DNSServers string
|
|
TimeServers string
|
|
Iface string
|
|
Mode string
|
|
Addresses string
|
|
Gateway string
|
|
}
|
|
|
|
// ToPlatformNetworkConfig converts the form data to a PlatformNetworkConfig.
|
|
//
|
|
//nolint:gocyclo
|
|
func (formData *NetworkConfigFormData) ToPlatformNetworkConfig() (*runtime.PlatformNetworkConfig, error) {
|
|
var errs error
|
|
|
|
config := &formData.Base
|
|
|
|
// zero-out the fields managed by the form
|
|
config.Hostnames = nil
|
|
config.Resolvers = nil
|
|
config.TimeServers = nil
|
|
config.Links = nil
|
|
config.Operators = nil
|
|
config.Addresses = nil
|
|
config.Routes = nil
|
|
|
|
if formData.Hostname != "" {
|
|
config.Hostnames = []network.HostnameSpecSpec{
|
|
{
|
|
Hostname: formData.Hostname,
|
|
ConfigLayer: network.ConfigPlatform,
|
|
},
|
|
}
|
|
}
|
|
|
|
dnsServers, err := formData.parseAddresses(formData.DNSServers)
|
|
if err != nil {
|
|
errs = multierror.Append(errs, fmt.Errorf("failed to parse DNS servers: %w", err))
|
|
}
|
|
|
|
if len(dnsServers) > 0 {
|
|
config.Resolvers = []network.ResolverSpecSpec{
|
|
{
|
|
DNSServers: dnsServers,
|
|
ConfigLayer: network.ConfigPlatform,
|
|
},
|
|
}
|
|
}
|
|
|
|
timeServers := formData.splitInputList(formData.TimeServers)
|
|
|
|
if len(timeServers) > 0 {
|
|
config.TimeServers = []network.TimeServerSpecSpec{
|
|
{
|
|
NTPServers: timeServers,
|
|
ConfigLayer: network.ConfigPlatform,
|
|
},
|
|
}
|
|
}
|
|
|
|
ifaceSelected := formData.Iface != "" && formData.Iface != interfaceNone
|
|
if ifaceSelected {
|
|
config.Links = []network.LinkSpecSpec{
|
|
{
|
|
Name: formData.Iface,
|
|
Logical: false,
|
|
Up: true,
|
|
Type: nethelpers.LinkEther,
|
|
ConfigLayer: network.ConfigPlatform,
|
|
},
|
|
}
|
|
|
|
switch formData.Mode {
|
|
case ModeDHCP:
|
|
config.Operators = []network.OperatorSpecSpec{
|
|
{
|
|
Operator: network.OperatorDHCP4,
|
|
LinkName: formData.Iface,
|
|
RequireUp: true,
|
|
DHCP4: network.DHCP4OperatorSpec{
|
|
RouteMetric: 1024,
|
|
},
|
|
ConfigLayer: network.ConfigPlatform,
|
|
},
|
|
}
|
|
case ModeStatic:
|
|
config.Addresses, err = formData.buildAddresses(formData.Iface)
|
|
if err != nil {
|
|
errs = multierror.Append(errs, err)
|
|
}
|
|
|
|
if len(config.Addresses) == 0 {
|
|
errs = multierror.Append(errs, fmt.Errorf("no addresses specified"))
|
|
}
|
|
|
|
config.Routes, err = formData.buildRoutes(formData.Iface)
|
|
if err != nil {
|
|
errs = multierror.Append(errs, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
if errs != nil {
|
|
return nil, errs
|
|
}
|
|
|
|
return config, nil
|
|
}
|
|
|
|
func (formData *NetworkConfigFormData) parseAddresses(text string) ([]netip.Addr, error) {
|
|
var errs error
|
|
|
|
split := formData.splitInputList(text)
|
|
addresses := make([]netip.Addr, 0, len(split))
|
|
|
|
for _, address := range split {
|
|
addr, err := netip.ParseAddr(address)
|
|
if err != nil {
|
|
errs = multierror.Append(errs, fmt.Errorf("address: %w", err))
|
|
|
|
continue
|
|
}
|
|
|
|
addresses = append(addresses, addr)
|
|
}
|
|
|
|
if errs != nil {
|
|
return nil, errs
|
|
}
|
|
|
|
return addresses, nil
|
|
}
|
|
|
|
func (formData *NetworkConfigFormData) buildAddresses(linkName string) ([]network.AddressSpecSpec, error) {
|
|
var errs error
|
|
|
|
addressesSplit := formData.splitInputList(formData.Addresses)
|
|
addresses := make([]network.AddressSpecSpec, 0, len(addressesSplit))
|
|
|
|
for _, address := range addressesSplit {
|
|
prefix, err := netip.ParsePrefix(address)
|
|
if err != nil {
|
|
errs = multierror.Append(errs, err)
|
|
|
|
continue
|
|
}
|
|
|
|
ipFamily := nethelpers.FamilyInet4
|
|
if prefix.Addr().Is6() {
|
|
ipFamily = nethelpers.FamilyInet6
|
|
}
|
|
|
|
addresses = append(addresses, network.AddressSpecSpec{
|
|
Address: prefix,
|
|
LinkName: linkName,
|
|
Family: ipFamily,
|
|
Scope: nethelpers.ScopeGlobal,
|
|
Flags: nethelpers.AddressFlags(nethelpers.AddressPermanent),
|
|
ConfigLayer: network.ConfigPlatform,
|
|
})
|
|
}
|
|
|
|
if errs != nil {
|
|
return nil, errs
|
|
}
|
|
|
|
return addresses, nil
|
|
}
|
|
|
|
func (formData *NetworkConfigFormData) buildRoutes(linkName string) ([]network.RouteSpecSpec, error) {
|
|
gateway := strings.TrimSpace(formData.Gateway)
|
|
|
|
gatewayAddr, err := netip.ParseAddr(gateway)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("gateway: %w", err)
|
|
}
|
|
|
|
family := nethelpers.FamilyInet4
|
|
if gatewayAddr.Is6() {
|
|
family = nethelpers.FamilyInet6
|
|
}
|
|
|
|
return []network.RouteSpecSpec{
|
|
{
|
|
Family: family,
|
|
Gateway: gatewayAddr,
|
|
OutLinkName: linkName,
|
|
Table: nethelpers.TableMain,
|
|
Scope: nethelpers.ScopeGlobal,
|
|
Type: nethelpers.TypeUnicast,
|
|
Protocol: nethelpers.ProtocolStatic,
|
|
ConfigLayer: network.ConfigPlatform,
|
|
},
|
|
}, nil
|
|
}
|
|
|
|
func (formData *NetworkConfigFormData) splitInputList(text string) []string {
|
|
parts := strings.FieldsFunc(text, func(r rune) bool {
|
|
return r == ',' || unicode.IsSpace(r)
|
|
})
|
|
|
|
result := make([]string, 0, len(parts))
|
|
|
|
for _, part := range parts {
|
|
trimmed := strings.TrimSpace(part)
|
|
|
|
if trimmed != "" {
|
|
result = append(result, part)
|
|
}
|
|
}
|
|
|
|
return result
|
|
}
|