Andrey Smirnov 67ac6933d3
fix: handle errors to watch apid/trustd certs
Fixes #8345

Both `apid` and `trustd` services use a gRPC connection back to
`machined` to watch changes to the certificates (new certificates being
issued).

This refactors the code to follow regular conventions, so that a failure
to watch will crash the process, and they have a way to restart and
re-establish the watch.

Use the context and errgroup consistently.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
2024-02-23 17:38:56 +04:00

192 lines
4.9 KiB
Go

// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
// Package provider provides TLS config for client & server.
package provider
import (
"context"
stdlibtls "crypto/tls"
"fmt"
"sync"
"github.com/cosi-project/runtime/pkg/resource"
"github.com/cosi-project/runtime/pkg/state"
"github.com/siderolabs/crypto/tls"
"github.com/siderolabs/talos/pkg/machinery/resources/secrets"
)
// TLSConfig provides client & server TLS configs for apid.
type TLSConfig struct {
certificateProvider *certificateProvider
watchCh <-chan state.Event
}
// NewTLSConfig builds provider from configuration and endpoints.
func NewTLSConfig(ctx context.Context, resources state.State) (*TLSConfig, error) {
watchCh := make(chan state.Event)
if err := resources.Watch(ctx, resource.NewMetadata(secrets.NamespaceName, secrets.APIType, secrets.APIID, resource.VersionUndefined), watchCh); err != nil {
return nil, fmt.Errorf("error setting up watch: %w", err)
}
// wait for the first event to set up certificate provider
provider := &certificateProvider{}
for {
var event state.Event
select {
case <-ctx.Done():
return nil, ctx.Err()
case event = <-watchCh:
}
switch event.Type {
case state.Created, state.Updated:
// expected
case state.Destroyed, state.Bootstrapped:
// ignore, we'll get another event
continue
case state.Errored:
return nil, fmt.Errorf("error watching for API certificates: %w", event.Error)
}
apiCerts := event.Resource.(*secrets.API) //nolint:errcheck,forcetypeassert
if err := provider.Update(apiCerts); err != nil {
return nil, err
}
return &TLSConfig{
certificateProvider: provider,
watchCh: watchCh,
}, nil
}
}
// Watch for changes in API certificates and updates the TLSConfig.
func (tlsConfig *TLSConfig) Watch(ctx context.Context) error {
for {
var event state.Event
select {
case <-ctx.Done():
return nil
case event = <-tlsConfig.watchCh:
}
switch event.Type {
case state.Created, state.Updated:
// expected
case state.Destroyed, state.Bootstrapped:
// ignore, we'll get another event
continue
case state.Errored:
return fmt.Errorf("error watching API certificates: %w", event.Error)
}
apiCerts := event.Resource.(*secrets.API) //nolint:errcheck,forcetypeassert
if err := tlsConfig.certificateProvider.Update(apiCerts); err != nil {
return fmt.Errorf("failed updating cert: %v", err)
}
}
}
// ServerConfig generates server-side tls.Config.
func (tlsConfig *TLSConfig) ServerConfig() (*stdlibtls.Config, error) {
ca, err := tlsConfig.certificateProvider.GetCA()
if err != nil {
return nil, fmt.Errorf("failed to get root CA: %w", err)
}
return tls.New(
tls.WithClientAuthType(tls.Mutual),
tls.WithCACertPEM(ca),
tls.WithServerCertificateProvider(tlsConfig.certificateProvider),
)
}
// ClientConfig generates client-side tls.Config.
func (tlsConfig *TLSConfig) ClientConfig() (*stdlibtls.Config, error) {
if !tlsConfig.certificateProvider.HasClientCertificate() {
return nil, nil
}
ca, err := tlsConfig.certificateProvider.GetCA()
if err != nil {
return nil, fmt.Errorf("failed to get root CA: %w", err)
}
return tls.New(
tls.WithClientAuthType(tls.Mutual),
tls.WithCACertPEM(ca),
tls.WithClientCertificateProvider(tlsConfig.certificateProvider),
)
}
type certificateProvider struct {
mu sync.Mutex
apiCerts *secrets.API
clientCert, serverCert *stdlibtls.Certificate
}
func (p *certificateProvider) Update(apiCerts *secrets.API) error {
p.mu.Lock()
defer p.mu.Unlock()
p.apiCerts = apiCerts
serverCert, err := stdlibtls.X509KeyPair(p.apiCerts.TypedSpec().Server.Crt, p.apiCerts.TypedSpec().Server.Key)
if err != nil {
return fmt.Errorf("failed to parse server cert and key into a TLS Certificate: %w", err)
}
p.serverCert = &serverCert
if p.apiCerts.TypedSpec().Client != nil {
clientCert, err := stdlibtls.X509KeyPair(p.apiCerts.TypedSpec().Client.Crt, p.apiCerts.TypedSpec().Client.Key)
if err != nil {
return fmt.Errorf("failed to parse client cert and key into a TLS Certificate: %w", err)
}
p.clientCert = &clientCert
} else {
p.clientCert = nil
}
return nil
}
func (p *certificateProvider) GetCA() ([]byte, error) {
p.mu.Lock()
defer p.mu.Unlock()
return p.apiCerts.TypedSpec().CA.Crt, nil
}
func (p *certificateProvider) GetCertificate(h *stdlibtls.ClientHelloInfo) (*stdlibtls.Certificate, error) {
p.mu.Lock()
defer p.mu.Unlock()
return p.serverCert, nil
}
func (p *certificateProvider) HasClientCertificate() bool {
p.mu.Lock()
defer p.mu.Unlock()
return p.clientCert != nil
}
func (p *certificateProvider) GetClientCertificate(*stdlibtls.CertificateRequestInfo) (*stdlibtls.Certificate, error) {
p.mu.Lock()
defer p.mu.Unlock()
return p.clientCert, nil
}