talos/pkg/cluster/kubelet.go
Andrey Smirnov 6d13d2cf92 fix: close Kubernetes API client
The problem is that there's no official way to close Kuberentes client
underlying TCP/HTTP connections. So each time Talos initializes
connection to the control plane endpoint, new client is built, but this
client is never closed, so the connection stays active on the load
balancers, on the API server level, etc. It also eats some resources out
of Talos itself.

We add a way to close underlying connections by using helper from the
Kubernetes client libraries to force close all TCP connections which
should shut down all HTTP/2 connections as well.

Alternative approach might be to cache a client for some time, but many
of the clients are created with temporary PKI, so even cached client
still needs to be closed once it gets stale, and it's not clear how to
recreate a client in case existing one is broken for one reason or
another (and we need to force a re-connection).

Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
2021-07-05 14:25:26 -07:00

61 lines
1.4 KiB
Go

// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
package cluster
import (
"context"
k8s "k8s.io/client-go/kubernetes"
"github.com/talos-systems/talos/pkg/kubernetes"
)
// KubernetesFromKubeletClient provides Kubernetes client built from local kubelet config.
type KubernetesFromKubeletClient struct {
KubeHelper *kubernetes.Client
clientset *k8s.Clientset
}
// K8sClient builds Kubernetes client from local kubelet config.
//
// Kubernetes client instance is cached.
func (k *KubernetesFromKubeletClient) K8sClient(ctx context.Context) (*k8s.Clientset, error) {
if k.clientset != nil {
return k.clientset, nil
}
var err error
if k.KubeHelper, err = kubernetes.NewClientFromKubeletKubeconfig(); err != nil {
return nil, err
}
k.clientset = k.KubeHelper.Clientset
return k.clientset, nil
}
// K8sHelper returns wrapper around K8sClient.
func (k *KubernetesFromKubeletClient) K8sHelper(ctx context.Context) (*kubernetes.Client, error) {
if k.KubeHelper != nil {
return k.KubeHelper, nil
}
_, err := k.K8sClient(ctx)
if err != nil {
return nil, err
}
return k.KubeHelper, nil
}
// K8sClose closes Kubernetes client.
func (k *KubernetesFromKubeletClient) K8sClose() error {
if k.KubeHelper == nil {
return nil
}
return k.KubeHelper.Close()
}