talos/internal/integration/cli/read.go
Andrey Smirnov 3d8418a689 feat: force nodes to be set in talosctl commands using the API
With load-balancing enabled by default running `talosctl` without
`--nodes` is risky, as it might hit any control plane by default without
`--nodes`.

Only two commands do not enforce this check, as they do their own node
contexts: `crashdump` and `health` (client-side).

Integration tests were updated to always supply `--nodes` cli argument,
while doing that I refactored the storage for discovered nodes to use
existing `cluster.Info` interface.

The downside is that with e2e CAPI tests CLI tests will be mostly
skipped as we don't support discovery in CLI tests at the momemnt. This
can be fixed by using `talosctl kubeconfig` + `kubectl get nodes` for
node discovery.

Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
2020-07-21 12:17:43 -07:00

43 lines
1.1 KiB
Go

// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
// +build integration_cli
package cli
import (
"regexp"
"github.com/talos-systems/talos/internal/integration/base"
)
// ReadSuite verifies dmesg command.
type ReadSuite struct {
base.CLISuite
}
// SuiteName ...
func (suite *ReadSuite) SuiteName() string {
return "cli.ReadSuite"
}
// TestSuccess runs comand with success.
func (suite *ReadSuite) TestSuccess() {
suite.RunCLI([]string{"read", "--nodes", suite.RandomDiscoveredNode(), "/etc/os-release"},
base.StdoutShouldMatch(regexp.MustCompile(`ID=talos`)))
}
// TestMultiNodeFail verifies that command fails with multiple nodes.
func (suite *ReadSuite) TestMultiNodeFail() {
suite.RunCLI([]string{"read", "--nodes", "127.0.0.1", "--nodes", "127.0.0.1", "/etc/os-release"},
base.ShouldFail(),
base.StderrNotEmpty(),
base.StdoutEmpty(),
base.StderrShouldMatch(regexp.MustCompile(`is not supported with multiple nodes`)))
}
func init() {
allSuites = append(allSuites, new(ReadSuite))
}